From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F9D2C432BE for ; Tue, 17 Aug 2021 04:59:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DC3C960F5C for ; Tue, 17 Aug 2021 04:59:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DC3C960F5C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 6CA8F6B006C; Tue, 17 Aug 2021 00:59:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67A3D6B0072; Tue, 17 Aug 2021 00:59:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5901A6B0073; Tue, 17 Aug 2021 00:59:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0178.hostedemail.com [216.40.44.178]) by kanga.kvack.org (Postfix) with ESMTP id 40EAC6B006C for ; Tue, 17 Aug 2021 00:59:42 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E775211204 for ; Tue, 17 Aug 2021 04:59:41 +0000 (UTC) X-FDA: 78483369762.11.4C234CE Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf26.hostedemail.com (Postfix) with ESMTP id 8D0062011FC2 for ; Tue, 17 Aug 2021 04:59:41 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id C949360E78; Tue, 17 Aug 2021 04:59:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629176379; bh=6dOr1zXUwHMhzllgenVUuv80XsCXUb3BWOhAaYNX7Hw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=upxHrYZG+A6r4Zq5U1nHXvROzqE18aqhztaN/c3MNQB3D+uU40dcQDIeDm1UjJ2eG lzjh4SZBEcAJbqkt0Ngr54qXEeReCw1C6Er+9xI2uXQi2xD0dB+IFOE+KFehwUD5NT YlTB0Ad0+tYBLjK4zp0lMww1M1AGq0sdrppegIyfWK08dNxGbYWo66As0aqA6/q2Gu w900Ri9yyzqRE6egBZv2oIc2cdgSLtZTKV3UpdQ8OMzWjvtvgFwvNH7kI3h6O9IskA JJ6/AUa6HEPUn/EQ7XUTklfmkEN2sQaowMv6cLKPcqyLPqpXRiVCyV8w3WHXw+ZRej JnFT4gRncTQIA== Date: Tue, 17 Aug 2021 07:59:31 +0300 From: Mike Rapoport To: Andrew Morton Cc: Mike Rapoport , Peter Collingbourne , Steven Rostedt , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mmflags.h: add missing __GFP_ZEROTAGS and __GFP_SKIP_KASAN_POISON names Message-ID: References: <20210816133502.590-1-rppt@kernel.org> <20210816170510.9d6afcd53c767397aba758ef@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210816170510.9d6afcd53c767397aba758ef@linux-foundation.org> Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=upxHrYZG; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8D0062011FC2 X-Stat-Signature: d33z61yhbpaha4qo7mapfms41er6bgik X-HE-Tag: 1629176381-5322 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 16, 2021 at 05:05:10PM -0700, Andrew Morton wrote: > On Mon, 16 Aug 2021 16:35:02 +0300 Mike Rapoport wrote: > > > From: Mike Rapoport > > > > Add missing names of __GFP_ZEROTAGS and __GFP_SKIP_KASAN_POISON flags to > > __def_gfpflag_names. > > > > Fixes: 013bb59dbb7c ("arm64: mte: handle tags zeroing at page allocation time") > > Fixes: c275c5c6d50a ("kasan: disable freed user page poisoning with HW tags") > > "fixes" in what way? ie, what problems were caused by the above commits? > > > --- a/include/trace/events/mmflags.h > > +++ b/include/trace/events/mmflags.h > > @@ -48,7 +48,9 @@ > > {(unsigned long)__GFP_WRITE, "__GFP_WRITE"}, \ > > {(unsigned long)__GFP_RECLAIM, "__GFP_RECLAIM"}, \ > > {(unsigned long)__GFP_DIRECT_RECLAIM, "__GFP_DIRECT_RECLAIM"},\ > > - {(unsigned long)__GFP_KSWAPD_RECLAIM, "__GFP_KSWAPD_RECLAIM"}\ > > + {(unsigned long)__GFP_KSWAPD_RECLAIM, "__GFP_KSWAPD_RECLAIM"},\ > > + {(unsigned long)__GFP_ZEROTAGS, "__GFP_ZEROTAGS"}, \ > > + {(unsigned long)__GFP_SKIP_KASAN_POISON,"__GFP_SKIP_KASAN_POISON"}\ > > > > #define show_gfp_flags(flags) \ > > (flags) ? __print_flags(flags, "|", \ > > I'm guessing that the tracing output was messed up in some fashion? I didn't check tracing actually, but printk("%pGg") outputs these two flags as hexadecimal number, rather that string, e.g: GFP_KERNEL|0x1800000 -- Sincerely yours, Mike.