From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D0DEC4338F for ; Mon, 16 Aug 2021 19:38:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9081560F4B for ; Mon, 16 Aug 2021 19:38:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9081560F4B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 300A08D0002; Mon, 16 Aug 2021 15:38:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B05F8D0001; Mon, 16 Aug 2021 15:38:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C61E8D0002; Mon, 16 Aug 2021 15:38:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id F0EA78D0001 for ; Mon, 16 Aug 2021 15:38:54 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9FA4E230EE for ; Mon, 16 Aug 2021 19:38:54 +0000 (UTC) X-FDA: 78481956588.29.73C4192 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id 2696B500827D for ; Mon, 16 Aug 2021 19:38:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HK2ZFnceD4MGP7RS84uFdlWNKcf4FPa/uPZZD88rUwE=; b=i/cQTEecxY0aNKFZ/qiSS1T0SJ q4fsdo7Fk3fjAY0WPvrRjEjAigTJiDVUVSZAd8ycyK7H0i/Ks+Gdhl+cLtlG8nhR93oH9lFe3xo6o K+SQrcL1uyHD6V4ouKsDorVrwt8Mk3rge5QaMfoMLpD7hNjhJSaTdW+/MfrCRmy+zP7lDVs6f9QWK /aeY1Pp3OSL4fBgy5mSJlpX6g3uNaPyjh8w4J1pT9jk86HjZu0dVJMGg6YOnDRF53FH/RYhDWARTq q1SAUj8Q9Wbx5weGKfJfvm73ARBiY0pKTIPaz72oyheJU8puBrUbBS+Cnap0UWrj/iH+sZQruMvkQ ZNKWHFJA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFiQi-001jqC-SS; Mon, 16 Aug 2021 19:37:57 +0000 Date: Mon, 16 Aug 2021 20:37:52 +0100 From: Matthew Wilcox To: Yang Shi Cc: naoya.horiguchi@nec.com, osalvador@suse.de, tdmackey@twitter.com, akpm@linux-foundation.org, corbet@lwn.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm: hwpoison: don't drop slab caches for offlining non-LRU page Message-ID: References: <20210816180909.3603-1-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210816180909.3603-1-shy828301@gmail.com> Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="i/cQTEec"; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2696B500827D X-Stat-Signature: dzbnq31i7uysi6o9pgyxrs9wy3c1q1d3 X-HE-Tag: 1629142733-407006 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 16, 2021 at 11:09:08AM -0700, Yang Shi wrote: > But the most disappointing thing is all the effort doesn't make the page > offline, it just returns: > > soft_offline: 0x1469f2: unknown non LRU page type 5ffff0000000000 () It's a shame it doesn't call dump_page(). There might be more interesting information somewhere in struct page that would help us figure out what kind of page it was in your environment. For example, it might be a page table page or a page allocated for vmalloc(), and in both those cases, there are things we might be able to do (we'd certainly be able to figure out that it isn't worth shrinking slab!)