From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5291C432BE for ; Mon, 16 Aug 2021 03:03:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 478C161458 for ; Mon, 16 Aug 2021 03:03:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 478C161458 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id D52A68D0001; Sun, 15 Aug 2021 23:03:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D02BE6B0072; Sun, 15 Aug 2021 23:03:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C18318D0001; Sun, 15 Aug 2021 23:03:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0211.hostedemail.com [216.40.44.211]) by kanga.kvack.org (Postfix) with ESMTP id A6BF36B0071 for ; Sun, 15 Aug 2021 23:03:30 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 42CA9181AEF07 for ; Mon, 16 Aug 2021 03:03:30 +0000 (UTC) X-FDA: 78479448180.01.4F03868 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id 08370D018757 for ; Mon, 16 Aug 2021 03:03:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sgTeGggd6fSczx52WtMtKzxx473Mj1eHW70jX24joX8=; b=h8xL57ZMQftS7cRG+UsZycv7aT ircyrqajjyn4sB/0lFCcuF6C0VFrsbnwoctiiyrIgZbiio4nFnhDY15xgjIZxwE7pAUAyPNCfEoQk EbWtajs63ibGia+h+hTB1+TjzwO68arEatNVoloEC0eOI3xc2hkRYGdXASTPIHiT8NFeBJEc405Th 4e0DSljoUFCUK9xlACucn50K0CA35cUQ9gdNqO01ShRcuKG80GDzHCKCgXhRTjpuV6vgzQKYyh6Tw CHDMdkzP52QHfmYbB8PQWXxjwwcHsWw5W3ghZiggaw3JlUou1Dj+KCiWiFjkEAoatnaCTmIPeI0WK b/P6Qsdw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFStp-000tom-LL; Mon, 16 Aug 2021 03:03:00 +0000 Date: Mon, 16 Aug 2021 04:02:53 +0100 From: Matthew Wilcox To: David Howells Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v14 088/138] mm/filemap: Add filemap_get_folio Message-ID: References: <20210715033704.692967-89-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> <1815135.1628633133@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1815135.1628633133@warthog.procyon.org.uk> Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=h8xL57ZM; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: fdjwc98a8frnpmq7zqhre4x496ebffor X-Rspamd-Queue-Id: 08370D018757 X-Rspamd-Server: rspam05 X-HE-Tag: 1629083009-76679 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 10, 2021 at 11:05:33PM +0100, David Howells wrote: > Matthew Wilcox (Oracle) wrote: > > > filemap_get_folio() is a replacement for find_get_page(). > > Turn pagecache_get_page() into a wrapper around __filemap_get_folio(). > > Remove find_lock_head() as this use case is now covered by > > filemap_get_folio(). > > > > Reduces overall kernel size by 209 bytes. __filemap_get_folio() is > > 316 bytes shorter than pagecache_get_page() was, but the new > > pagecache_get_page() is 99 bytes > > longer, one presumes. In total -- the old pagecache_get_page() turns into __filemap_get_folio(), but the wrapper is 99 bytes in size. Added the word "wrapper" to make this clearer.