From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDC99C4338F for ; Sat, 14 Aug 2021 01:35:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8BD6B6109D for ; Sat, 14 Aug 2021 01:35:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8BD6B6109D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id E00F56B006C; Fri, 13 Aug 2021 21:35:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8BE98D0002; Fri, 13 Aug 2021 21:35:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C52D08D0001; Fri, 13 Aug 2021 21:35:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0172.hostedemail.com [216.40.44.172]) by kanga.kvack.org (Postfix) with ESMTP id AB32A6B006C for ; Fri, 13 Aug 2021 21:35:06 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2F7941801D3D7 for ; Sat, 14 Aug 2021 01:35:06 +0000 (UTC) X-FDA: 78471967812.14.FB0B7DB Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf06.hostedemail.com (Postfix) with ESMTP id B7E22801AB3D for ; Sat, 14 Aug 2021 01:35:05 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2276B60F91; Sat, 14 Aug 2021 01:35:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628904904; bh=eY9Zlb5Yzq0HV9CL/L0msaxvaE8QXiuQY3wG35nZ65w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AMkJ3trgQJDpgiuFC4las4ZUtIiLDINSYwzzxSDBgDmP0YdztmqDcI6yxQgipJ35l hId17yB1BKbJWLVQXVKnl+LTShlzYyNt2xgY45m6nviHFgfwH04gGKAFaUTrMsHKyw MV434VODCBQkGBrLP4pk8NdfkvoexbuZrY8Sd5V8VIIRz+ZYF7kV/QWAdpPzmkc5UI PtM3dIZdwdmZ1r0A18+oz1+7lO5F/P4KTXdHJiHKVt8b/2Q1tMhOnFevK5ysRb9QL5 HPA+tIpWVhksQN8a2soVHXEBVqGBQNSnb9eUXFxQpVUb3JG8l/pzlb+Thlfq3QjRlM a+7ckrKM8do/w== Date: Fri, 13 Aug 2021 18:35:02 -0700 From: Nathan Chancellor To: kernel test robot Cc: yanghui , akpm@linux-foundation.org, clang-built-linux@googlegroups.com, kbuild-all@lists.01.org, linux-mm@kvack.org, songmuchun@bytedance.com Subject: Re: [PATCH] mm/mempolicy: fix a race between offset_il_node and mpol_rebind_task Message-ID: References: <20210813164053.51481-1-yanghui.def@bytedance.com> <202108140711.JVipVXx2-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202108140711.JVipVXx2-lkp@intel.com> Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AMkJ3trg; spf=pass (imf06.hostedemail.com: domain of nathan@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=nathan@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B7E22801AB3D X-Stat-Signature: abpfakpgupsb6ki4exxp65b3o8kdz6xn X-HE-Tag: 1628904905-147201 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Aug 14, 2021 at 07:16:24AM +0800, kernel test robot wrote: > Hi yanghui, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on v5.14-rc5] > [cannot apply to hnaz-linux-mm/master next-20210813] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/yanghui/mm-mempolicy-fix-a-race-between-offset_il_node-and-mpol_rebind_task/20210814-004451 > base: 36a21d51725af2ce0700c6ebcb6b9594aac658a6 > config: x86_64-randconfig-a003-20210813 (attached as .config) > compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 62df4df41c939205b2dc0a2a3bfb75b8c1ed74fa) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/0day-ci/linux/commit/99d8d888eb92ea46a5f4883773f3edaee5ccd28e > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review yanghui/mm-mempolicy-fix-a-race-between-offset_il_node-and-mpol_rebind_task/20210814-004451 > git checkout 99d8d888eb92ea46a5f4883773f3edaee5ccd28e > # save the attached .config to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=x86_64 SHELL=/bin/bash > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > >> ld.lld: error: undefined symbol: __compiletime_assert_467 > >>> referenced by mempolicy.c:1968 (mm/mempolicy.c:1968) > >>> mempolicy.o:(offset_il_node) in archive mm/built-in.a Grabbing Nick's patch [1] to support the error function attribute in clang and the kernel side patch [2] turns this into: mm/mempolicy.c:1968:24: error: call to '__compiletime_assert_467' declared with 'error' attribute: Unsupported access size for {READ,WRITE}_ONCE(). nodemask_t nodemask = READ_ONCE(pol->nodes); ^ ./include/asm-generic/rwonce.h:49:2: note: expanded from macro 'READ_ONCE' compiletime_assert_rwonce_type(x); \ ^ ./include/asm-generic/rwonce.h:36:2: note: expanded from macro 'compiletime_assert_rwonce_type' compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ ^ ./include/linux/compiler_types.h:322:2: note: expanded from macro 'compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^ ./include/linux/compiler_types.h:310:2: note: expanded from macro '_compiletime_assert' __compiletime_assert(condition, msg, prefix, suffix) ^ ./include/linux/compiler_types.h:303:4: note: expanded from macro '__compiletime_assert' prefix ## suffix(); \ ^ :246:1: note: expanded from here __compiletime_assert_467 ^ mm/mempolicy.c:214:2: error: call to '__compiletime_assert_448' declared with 'error' attribute: Unsupported access size for {READ,WRITE}_ONCE(). WRITE_ONCE(pol->nodes, *nodes); ^ ./include/asm-generic/rwonce.h:60:2: note: expanded from macro 'WRITE_ONCE' compiletime_assert_rwonce_type(x); \ ^ ./include/asm-generic/rwonce.h:36:2: note: expanded from macro 'compiletime_assert_rwonce_type' compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ ^ ./include/linux/compiler_types.h:322:2: note: expanded from macro 'compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^ ./include/linux/compiler_types.h:310:2: note: expanded from macro '_compiletime_assert' __compiletime_assert(condition, msg, prefix, suffix) ^ ./include/linux/compiler_types.h:303:4: note: expanded from macro '__compiletime_assert' prefix ## suffix(); \ ^ :16:1: note: expanded from here __compiletime_assert_448 ^ mm/mempolicy.c:337:2: error: call to '__compiletime_assert_452' declared with 'error' attribute: Unsupported access size for {READ,WRITE}_ONCE(). WRITE_ONCE(pol->nodes, tmp); ^ ./include/asm-generic/rwonce.h:60:2: note: expanded from macro 'WRITE_ONCE' compiletime_assert_rwonce_type(x); \ ^ ./include/asm-generic/rwonce.h:36:2: note: expanded from macro 'compiletime_assert_rwonce_type' compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ ^ ./include/linux/compiler_types.h:322:2: note: expanded from macro 'compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^ ./include/linux/compiler_types.h:310:2: note: expanded from macro '_compiletime_assert' __compiletime_assert(condition, msg, prefix, suffix) ^ ./include/linux/compiler_types.h:303:4: note: expanded from macro '__compiletime_assert' prefix ## suffix(); \ ^ :38:1: note: expanded from here __compiletime_assert_452 ^ mm/mempolicy.c:196:2: error: call to '__compiletime_assert_447' declared with 'error' attribute: Unsupported access size for {READ,WRITE}_ONCE(). WRITE_ONCE(pol->nodes, *nodes); ^ ./include/asm-generic/rwonce.h:60:2: note: expanded from macro 'WRITE_ONCE' compiletime_assert_rwonce_type(x); \ ^ ./include/asm-generic/rwonce.h:36:2: note: expanded from macro 'compiletime_assert_rwonce_type' compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ ^ ./include/linux/compiler_types.h:322:2: note: expanded from macro 'compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^ ./include/linux/compiler_types.h:310:2: note: expanded from macro '_compiletime_assert' __compiletime_assert(condition, msg, prefix, suffix) ^ ./include/linux/compiler_types.h:303:4: note: expanded from macro '__compiletime_assert' prefix ## suffix(); \ ^ :13:1: note: expanded from here __compiletime_assert_447 ^ 4 errors generated. Which appears to be what Matthew mentioned, as this config has CONFIG_NODES_SHIFT=10 so nodemask_t is 128 bytes large. [1]: https://reviews.llvm.org/D106030 [2]: https://lore.kernel.org/r/20210802202326.1817503-1-ndesaulniers@google.com/ Cheers, Nathan