From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6F31C4338F for ; Thu, 12 Aug 2021 11:16:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6D43B61059 for ; Thu, 12 Aug 2021 11:16:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6D43B61059 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A141F8D0007; Thu, 12 Aug 2021 07:16:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C4E18D0006; Thu, 12 Aug 2021 07:16:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B3338D0007; Thu, 12 Aug 2021 07:16:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0223.hostedemail.com [216.40.44.223]) by kanga.kvack.org (Postfix) with ESMTP id 6FF658D0006 for ; Thu, 12 Aug 2021 07:16:07 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1891421251 for ; Thu, 12 Aug 2021 11:16:07 +0000 (UTC) X-FDA: 78466174374.37.1D3FD3F Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf22.hostedemail.com (Postfix) with ESMTP id 8C30829DF for ; Thu, 12 Aug 2021 11:16:06 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10073"; a="202492233" X-IronPort-AV: E=Sophos;i="5.84,315,1620716400"; d="scan'208";a="202492233" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2021 04:16:04 -0700 X-IronPort-AV: E=Sophos;i="5.84,315,1620716400"; d="scan'208";a="469725505" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2021 04:16:01 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1mE8gk-008Z2D-MY; Thu, 12 Aug 2021 14:15:54 +0300 Date: Thu, 12 Aug 2021 14:15:54 +0300 From: Andy Shevchenko To: David Hildenbrand Cc: "linux-kernel@vger.kernel.org" , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , "Rafael J. Wysocki" , Andrew Morton , Dan Williams , Hanjun Guo , "virtualization@lists.linux-foundation.org" , "linux-mm@kvack.org" Subject: Re: [PATCH v1 3/3] kernel/resource: cleanup and optimize iomem_is_exclusive() Message-ID: References: <20210811203612.138506-1-david@redhat.com> <20210811203612.138506-4-david@redhat.com> <37179df3-13d7-9b98-4cd8-13bb7f735129@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Queue-Id: 8C30829DF Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (imf22.hostedemail.com: 134.134.136.126 is neither permitted nor denied by domain of andyshevchenko@gmail.com) smtp.mailfrom=andyshevchenko@gmail.com X-Rspamd-Server: rspam04 X-Stat-Signature: e3kjz9aqnuwcbun6ep33f74hqmmjkhec X-HE-Tag: 1628766966-802986 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 12, 2021 at 09:34:00AM +0200, David Hildenbrand wrote: > On 12.08.21 09:14, Andy Shevchenko wrote: > > On Thursday, August 12, 2021, David Hildenbrand > > wrote: > > On 11.08.21 22:47, Andy Shevchenko wrote: > > On Wednesday, August 11, 2021, David Hildenbrand > > > > >> wrote: > > Yes, it=E2=80=99s like micro optimization. If you want your way I sug= gest then > > to add a macro > >=20 > > #define for_each_iomem_resource_child() \ > > =C2=A0for (iomem_resource...) >=20 > I think the only thing that really makes sense would be something like = this on top (not compiled yet): Makes sense to me, thanks, go for it! --=20 With Best Regards, Andy Shevchenko