From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F70AC00143 for ; Wed, 11 Aug 2021 12:31:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 063AD6108C for ; Wed, 11 Aug 2021 12:31:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 063AD6108C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 7D42E8D0002; Wed, 11 Aug 2021 08:31:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75DA86B0072; Wed, 11 Aug 2021 08:31:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 626C68D0002; Wed, 11 Aug 2021 08:31:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id 498956B0071 for ; Wed, 11 Aug 2021 08:31:50 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id F40F48249980 for ; Wed, 11 Aug 2021 12:31:49 +0000 (UTC) X-FDA: 78462736380.28.73ED11D Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf26.hostedemail.com (Postfix) with ESMTP id 9C7A1200FC85 for ; Wed, 11 Aug 2021 12:31:49 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2F5C360FE6; Wed, 11 Aug 2021 12:31:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628685108; bh=tv9C3Cm5qQR3sXiWl3T9jk8eH5uFDMx7/ShOjjjSaDw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c+a18SdN5uY3z6WkcWr/H3kkXDwgXLnIKPqDeY6igowQRch+OLtbTdTpPFnF4q4lL JAW7PQwzFBCaQAGLSPbvCavaFHN404Jhn6OXDnC05WOiT7G/VvTK5t2Sh9qwEcdtGx cKKgvcJ9jUI0lBjjM5NY6aN183Hj1QGC5vDDHitskz3Omf+yF1k0XXqbMNcnmrxr+1 s8d11pHOnmt0m8evPNRz9qV9T4FeAHQHqdhI029WN4241n2DQVb/wT838AF4mTtBAZ s6d2q0QRle7HoZ1Lu8wLObCdmZHQvbQcwh8nyvQ/TAkEihwIt9cUM7xe3NqKz/LGrK xubSxdH4209pw== Date: Wed, 11 Aug 2021 15:31:43 +0300 From: Mike Rapoport To: Vineet Gupta Cc: linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Anshuman Khandual Subject: Re: [PATCH 09/18] ARC: mm: non-functional code cleanup ahead of 3 levels Message-ID: References: <20210811004258.138075-1-vgupta@kernel.org> <20210811004258.138075-10-vgupta@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210811004258.138075-10-vgupta@kernel.org> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9C7A1200FC85 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=c+a18SdN; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org X-Stat-Signature: uh6nzgg3pu3sj3fq1eyzn7u4pxp9nwhk X-HE-Tag: 1628685109-800389 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 10, 2021 at 05:42:49PM -0700, Vineet Gupta wrote: > Signed-off-by: Vineet Gupta > --- > arch/arc/include/asm/page.h | 30 ++++++++++++++++-------------- > arch/arc/include/asm/pgalloc.h | 7 ++++++- > 2 files changed, 22 insertions(+), 15 deletions(-) > > diff --git a/arch/arc/include/asm/page.h b/arch/arc/include/asm/page.h > index c4ac827379cd..313e6f543d2d 100644 > --- a/arch/arc/include/asm/page.h > +++ b/arch/arc/include/asm/page.h > @@ -34,6 +34,13 @@ void copy_user_highpage(struct page *to, struct page *from, > unsigned long u_vaddr, struct vm_area_struct *vma); > void clear_user_page(void *to, unsigned long u_vaddr, struct page *page); > > +typedef struct { > + unsigned long pgd; > +} pgd_t; > + > +#define pgd_val(x) ((x).pgd) > +#define __pgd(x) ((pgd_t) { (x) }) > + > typedef struct { > #ifdef CONFIG_ARC_HAS_PAE40 > unsigned long long pte; > @@ -41,22 +48,17 @@ typedef struct { > unsigned long pte; > #endif > } pte_t; > -typedef struct { > - unsigned long pgd; > -} pgd_t; > + > +#define pte_val(x) ((x).pte) > +#define __pte(x) ((pte_t) { (x) }) > + > typedef struct { > unsigned long pgprot; > } pgprot_t; > > -#define pte_val(x) ((x).pte) > -#define pgd_val(x) ((x).pgd) > -#define pgprot_val(x) ((x).pgprot) > - > -#define __pte(x) ((pte_t) { (x) }) > -#define __pgd(x) ((pgd_t) { (x) }) > -#define __pgprot(x) ((pgprot_t) { (x) }) > - > -#define pte_pgprot(x) __pgprot(pte_val(x)) > +#define pgprot_val(x) ((x).pgprot) > +#define __pgprot(x) ((pgprot_t) { (x) }) > +#define pte_pgprot(x) __pgprot(pte_val(x)) > > typedef pte_t * pgtable_t; > > @@ -96,8 +98,8 @@ extern int pfn_valid(unsigned long pfn); > * virt here means link-address/program-address as embedded in object code. > * And for ARC, link-addr = physical address > */ > -#define __pa(vaddr) ((unsigned long)(vaddr)) > -#define __va(paddr) ((void *)((unsigned long)(paddr))) > +#define __pa(vaddr) ((unsigned long)(vaddr)) > +#define __va(paddr) ((void *)((unsigned long)(paddr))) > > #define virt_to_page(kaddr) pfn_to_page(virt_to_pfn(kaddr)) > #define virt_addr_valid(kaddr) pfn_valid(virt_to_pfn(kaddr)) > diff --git a/arch/arc/include/asm/pgalloc.h b/arch/arc/include/asm/pgalloc.h > index 356237b9c537..0cf73431eb89 100644 > --- a/arch/arc/include/asm/pgalloc.h > +++ b/arch/arc/include/asm/pgalloc.h > @@ -29,6 +29,11 @@ > #ifndef _ASM_ARC_PGALLOC_H > #define _ASM_ARC_PGALLOC_H > > +/* > + * For ARC, pgtable_t is not struct page *, but pte_t * (to avoid > + * extraneous page_address() calculations) hence can't use > + * use asm-generic/pgalloc.h which assumes it being struct page * > + */ Another reason to leave ARC without asm-generic/pgalloc.h was __get_order_pte() that other arches don't have. So this and pgtable_t aliased to pte_t * seemed to me too much to bother then, but probably it's worth reconsidering with addition of 3rd and 4th levels. > #include > #include > > @@ -36,7 +41,7 @@ static inline void > pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmdp, pte_t *ptep) > { > /* > - * The cast to long below is OK even when pte is long long (PAE40) > + * The cast to long below is OK in 32-bit PAE40 regime with long long pte > * Despite "wider" pte, the pte table needs to be in non-PAE low memory > * as all higher levels can only hold long pointers. > * > -- > 2.25.1 > -- Sincerely yours, Mike.