[PATCH] selftests/damon/debugfs_attrs: Add missing execute permission

[PATCH] selftests/damon/debugfs_attrs: Add missing execute permission

[SeongJae Park]

From: SeongJae Park <sjpark@amazon.de>

Commit 04edafbc0c07 ("mm/damon: add user space selftests") of
linux-mm[1] gives no execute permission to 'debugfs_attrs.sh' file.
This results in a DAMON selftest failure as below:

    $ make -C tools/testing/selftests/damon run_tests
    make: Entering directory '/home/sjpark/linux/tools/testing/selftests/damon'
    TAP version 13
    1..1
    # selftests: damon: debugfs_attrs.sh
    # Warning: file debugfs_attrs.sh is not executable, correct this.
    not ok 1 selftests: damon: debugfs_attrs.sh
    make: Leaving directory '/home/sjpark/linux/tools/testing/selftests/damon'

To solve the problem, this commit adds the execute permission for
'debugfs_attrs.sh' file.

[1] https://github.com/hnaz/linux-mm/commit/04edafbc0c07

Signed-off-by: SeongJae Park <sjpark@amazon.de>
---
 tools/testing/selftests/damon/debugfs_attrs.sh | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_attrs.sh

diff --git a/tools/testing/selftests/damon/debugfs_attrs.sh b/tools/testing/selftests/damon/debugfs_attrs.sh
old mode 100644
new mode 100755
-- 
2.17.1

Re: [PATCH] selftests/damon/debugfs_attrs: Add missing execute permission

[Greg KH]

On Tue, Aug 10, 2021 at 11:20:50AM +0000, SeongJae Park wrote:
> From: SeongJae Park <sjpark@amazon.de>
> 
> Commit 04edafbc0c07 ("mm/damon: add user space selftests") of
> linux-mm[1] gives no execute permission to 'debugfs_attrs.sh' file.
> This results in a DAMON selftest failure as below:
> 
>     $ make -C tools/testing/selftests/damon run_tests
>     make: Entering directory '/home/sjpark/linux/tools/testing/selftests/damon'
>     TAP version 13
>     1..1
>     # selftests: damon: debugfs_attrs.sh
>     # Warning: file debugfs_attrs.sh is not executable, correct this.
>     not ok 1 selftests: damon: debugfs_attrs.sh
>     make: Leaving directory '/home/sjpark/linux/tools/testing/selftests/damon'
> 
> To solve the problem, this commit adds the execute permission for
> 'debugfs_attrs.sh' file.
> 
> [1] https://github.com/hnaz/linux-mm/commit/04edafbc0c07
> 
> Signed-off-by: SeongJae Park <sjpark@amazon.de>
> ---
>  tools/testing/selftests/damon/debugfs_attrs.sh | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_attrs.sh
> 
> diff --git a/tools/testing/selftests/damon/debugfs_attrs.sh b/tools/testing/selftests/damon/debugfs_attrs.sh
> old mode 100644
> new mode 100755
> -- 
> 2.17.1
> 

Why not fix the tools to execute the file properly as changing the mode
of a file does not work well with all tools that we use (i.e. patch
files.)

thanks,

greg k-h

Re: [PATCH] selftests/damon/debugfs_attrs: Add missing execute permission

[SeongJae Park]

From: SeongJae Park <sjpark@amazon.de>

On Tue, 10 Aug 2021 13:27:44 +0200 Greg KH <gregkh@linuxfoundation.org> wrote:

> On Tue, Aug 10, 2021 at 11:20:50AM +0000, SeongJae Park wrote:
> > From: SeongJae Park <sjpark@amazon.de>
> > 
> > Commit 04edafbc0c07 ("mm/damon: add user space selftests") of
> > linux-mm[1] gives no execute permission to 'debugfs_attrs.sh' file.
> > This results in a DAMON selftest failure as below:
> > 
> >     $ make -C tools/testing/selftests/damon run_tests
> >     make: Entering directory '/home/sjpark/linux/tools/testing/selftests/damon'
> >     TAP version 13
> >     1..1
> >     # selftests: damon: debugfs_attrs.sh
> >     # Warning: file debugfs_attrs.sh is not executable, correct this.
> >     not ok 1 selftests: damon: debugfs_attrs.sh
> >     make: Leaving directory '/home/sjpark/linux/tools/testing/selftests/damon'
> > 
> > To solve the problem, this commit adds the execute permission for
> > 'debugfs_attrs.sh' file.
> > 
> > [1] https://github.com/hnaz/linux-mm/commit/04edafbc0c07
> > 
> > Signed-off-by: SeongJae Park <sjpark@amazon.de>
> > ---
> >  tools/testing/selftests/damon/debugfs_attrs.sh | 0
> >  1 file changed, 0 insertions(+), 0 deletions(-)
> >  mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_attrs.sh
> > 
> > diff --git a/tools/testing/selftests/damon/debugfs_attrs.sh b/tools/testing/selftests/damon/debugfs_attrs.sh
> > old mode 100644
> > new mode 100755
> > -- 
> > 2.17.1
> > 
> 
> Why not fix the tools to execute the file properly as changing the mode
> of a file does not work well with all tools that we use (i.e. patch
> files.)

Ok, It sounds make some sense.  Hence, I posted this patch:
https://lore.kernel.org/linux-kselftest/20210810140459.23990-1-sj38.park@gmail.com/


Thanks,
SeongJae Park

[...]