From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3243FC4338F for ; Thu, 19 Aug 2021 18:08:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9148E6109F for ; Thu, 19 Aug 2021 18:08:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9148E6109F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 2DDCD6B006C; Thu, 19 Aug 2021 14:08:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 28E408D0001; Thu, 19 Aug 2021 14:08:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17D186B0072; Thu, 19 Aug 2021 14:08:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0171.hostedemail.com [216.40.44.171]) by kanga.kvack.org (Postfix) with ESMTP id F10BA6B006C for ; Thu, 19 Aug 2021 14:08:43 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9CA5626DF1 for ; Thu, 19 Aug 2021 18:08:43 +0000 (UTC) X-FDA: 78492615726.23.6827F01 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf30.hostedemail.com (Postfix) with ESMTP id 2D665E0016A1 for ; Thu, 19 Aug 2021 18:08:43 +0000 (UTC) Received: by mail-qt1-f179.google.com with SMTP id d2so5310601qto.6 for ; Thu, 19 Aug 2021 11:08:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bAIiTBPTb8Mkl8cV8Kxh3WxowxrFi5/bhPm5MGwzFe8=; b=Nd0h3PKHtULXQTcNfUrbUNLMY+Lcp2GUMrljVSXkJIdb3p4t+DHL7vroVO4gvZbMZZ rBhdbmghvCGXuZlQkPccfMDTAKB3hCWFhKMNGAx6A1jQ4o01QI+y0ysBu/HhHyMJ966P 4CrbtleOSmV5ypqZKqxeed4dpc+NZQtkAwxNIjrcix7c1hbWtJT+U6O7a1x7F9Nybc7K +ojOOuA1TcHaFaB8z+NO6rB06iUNFIPDB5XcUJLqC5Fex8vslhYV2LvpY6TNawZbcDRp utvOZBmjqDddnbWAuKQ7Eb0vL/7RTcgR59CEQcbzxZoAXzZmRpAAMJn7tXo9w+USd8J5 0Cag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bAIiTBPTb8Mkl8cV8Kxh3WxowxrFi5/bhPm5MGwzFe8=; b=o6k6PLv7Rwx0/G7XI/7CFjKzTHf/AF53TBZDUgmb5scIde4Wd67MMZATvt8WJWA8pR e/fwTmQ/7dnSkH0MwLsnRjlcPlouqSqXLazR+Exv6LHxbv8y14VlQEFT2gyyLdYjyxtE ipUYbYpLqf6PZGZwWZp1DwJGJvaK70mklHEb4fw4pcuqqo3Z8FE7D7SyXADzEzRlDY9l goHg5J/JlMFyZI/SD0QPPqk94mbX8ozcXwmnq+k2kl+1LahtlNG2AWG7BN7SITBG6PRA PjEDADL06Re3oEQ9RXVF+ULiAwUujKiYZJJJj/PGC1vuMR36RbLHy+ZaY6U0nHH0Md1q 7Rqw== X-Gm-Message-State: AOAM530pdafkH67Xmfxv7x69uDKU6wtqY44cKFYaHQWFGNMCNdS89SPk a4v1DbLK1StlQKrBRl/SYyiUMA== X-Google-Smtp-Source: ABdhPJzIlc7ODqmcQFX/Z4hb8tPxDoQi/zEYTAMjg2xfKZBDl8lNXkPrTFdLSbiiZt6hmB3h90y51w== X-Received: by 2002:ac8:7f89:: with SMTP id z9mr14174937qtj.240.1629396522044; Thu, 19 Aug 2021 11:08:42 -0700 (PDT) Received: from localhost (cpe-98-15-154-102.hvc.res.rr.com. [98.15.154.102]) by smtp.gmail.com with ESMTPSA id 141sm1966700qkn.10.2021.08.19.11.08.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Aug 2021 11:08:41 -0700 (PDT) Date: Thu, 19 Aug 2021 14:10:20 -0400 From: Johannes Weiner To: Muchun Song Cc: guro@fb.com, mhocko@kernel.org, akpm@linux-foundation.org, shakeelb@google.com, vdavydov.dev@gmail.com, willy@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2] mm: introduce PAGEFLAGS_MASK to replace ((1UL << NR_PAGEFLAGS) - 1) Message-ID: References: <20210819150712.59948-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210819150712.59948-1-songmuchun@bytedance.com> Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=Nd0h3PKH; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf30.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.179 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org X-Stat-Signature: zherpxiqjugqqns5dfbsqwktzi6hkdwr X-Rspamd-Queue-Id: 2D665E0016A1 X-Rspamd-Server: rspam05 X-HE-Tag: 1629396523-190470 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 19, 2021 at 11:07:12PM +0800, Muchun Song wrote: > Instead of hard-coding ((1UL << NR_PAGEFLAGS) - 1) everywhere, introducing > PAGEFLAGS_MASK to make the code clear to get the page flags. > > Signed-off-by: Muchun Song LGTM. Acked-by: Johannes Weiner