From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF4F7C4338F for ; Thu, 19 Aug 2021 11:16:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7AD7161157 for ; Thu, 19 Aug 2021 11:16:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7AD7161157 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C77CD6B006C; Thu, 19 Aug 2021 07:16:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C27CE6B0071; Thu, 19 Aug 2021 07:16:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B167B8D0001; Thu, 19 Aug 2021 07:16:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id 9432C6B006C for ; Thu, 19 Aug 2021 07:16:36 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 339E2181EFF4F for ; Thu, 19 Aug 2021 11:16:36 +0000 (UTC) X-FDA: 78491577192.20.D143447 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by imf19.hostedemail.com (Postfix) with ESMTP id B3E39B00D92B for ; Thu, 19 Aug 2021 11:16:35 +0000 (UTC) Received: by mail-qk1-f169.google.com with SMTP id o123so6642451qkf.12 for ; Thu, 19 Aug 2021 04:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GqNWvt3mRolDHwE66h5rouh0U1Qc+bL7CrWojzf5dRA=; b=tLtoShExnPg6ODUan9LMeKzDlSF8kv/VkmL1JrIS+2481uABbaYaWy4ybTkFLU2pPH PyoJD1Mnqerh1zR2mMA8MJ2AeC/9kb9VbvcwCxJOnoUamfVtcFFJheZKLxcoslrBFDVL 2pYdearUS57d4ZmNb5gO10tGWgaP4lihwPIkKEefo292Yc7Jcm+v+2NBulcYtlx6zrou hmCIuW/eM9riBzfiYMYG8btnqLJBPGr1iB9nVbvLnFWSIYlUfPZ1QPnKhPDPi/SIIlx9 9MrqvAev7abZzsHvvSQJ9RSHnMSzntM3L/cO0IB513ZOjo+Ghgo4xYntH9mexS3FKpuC WEog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GqNWvt3mRolDHwE66h5rouh0U1Qc+bL7CrWojzf5dRA=; b=uHlHJxHGxeeTTUSXJGyJpwoE0aCy6d1K/3Zn0ZXXwpaHgulVizHpy22VYghqmeCL9k g8dVVy9flM47wsBPzu1UwydBgNDIdyWhQk4ol7Hzbz1jTbEnnzsI95SUZCX3i8Daa/+L +1GZYNmEBaKjZo+UPnwubnXTR7wdesPABCnLmE0NOgH+kZzMMp41UTlnIRGTLfQIk/uC j50B+5tgtTdG4+kP2w6hA8VM/Sw7kj1PIYrU6st/BIhGWP5SHiYGIe/HvFWSCcuYbbnQ udtTnJbbEdaF5oYE5dCy/oCDCMHsOTXGWCiHNE+IkTD3MQT7oCmoF+YJImVnoJvEkm0I 4k1A== X-Gm-Message-State: AOAM530LXcnw/uXvCCKi06Eb2kwYMGPA9g7JyV/uOKP7Y4CLVT0A5ki/ XjlT1Kt7AF1UtUUDIGjtw+QedQ== X-Google-Smtp-Source: ABdhPJxT+LxE512ewKYe1PF2KOOZVj/m8nipQ7H1gmSjRwUHzetyf5sNABp1ltzWJrNUGazFBpHDHg== X-Received: by 2002:a05:620a:941:: with SMTP id w1mr2998230qkw.434.1629371795033; Thu, 19 Aug 2021 04:16:35 -0700 (PDT) Received: from localhost (cpe-98-15-154-102.hvc.res.rr.com. [98.15.154.102]) by smtp.gmail.com with ESMTPSA id g8sm1383337qkm.25.2021.08.19.04.16.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Aug 2021 04:16:34 -0700 (PDT) Date: Thu, 19 Aug 2021 07:18:13 -0400 From: Johannes Weiner To: Muchun Song Cc: Andrew Morton , Roman Gushchin , Michal Hocko , Shakeel Butt , Vladimir Davydov , Matthew Wilcox , LKML , Linux Memory Management List Subject: Re: [PATCH] mm: introduce PAGEFLAGS_MASK to replace ((1UL << NR_PAGEFLAGS) - 1) Message-ID: References: <20210817033032.76089-1-songmuchun@bytedance.com> <20210818003919.5bd008fec6cb0436af2443c4@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=tLtoShEx; spf=pass (imf19.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.169 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B3E39B00D92B X-Stat-Signature: 5rt8qfu7pm3dxjcz14xaybyb6463frsf X-HE-Tag: 1629371795-435733 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 19, 2021 at 02:33:37PM +0800, Muchun Song wrote: > On Wed, Aug 18, 2021 at 3:39 PM Andrew Morton wrote: > > > > On Tue, 17 Aug 2021 21:44:36 -0700 Roman Gushchin wrote: > > > > > On Wed, Aug 18, 2021 at 12:35:08PM +0800, Muchun Song wrote: > > > > On Wed, Aug 18, 2021 at 10:16 AM Roman Gushchin wrote: > > > > > > > > > > On Tue, Aug 17, 2021 at 11:30:32AM +0800, Muchun Song wrote: > > > > > > Instead of hard-coding ((1UL << NR_PAGEFLAGS) - 1) everywhere, introducing > > > > > > PAGEFLAGS_MASK to make the code clear to get the page flags. > > > > > > > > > > > > Signed-off-by: Muchun Song > > > > > > --- > > > > > > include/linux/page-flags.h | 4 +++- > > > > > > include/trace/events/page_ref.h | 4 ++-- > > > > > > lib/test_printf.c | 2 +- > > > > > > lib/vsprintf.c | 2 +- > > > > > > 4 files changed, 7 insertions(+), 5 deletions(-) > > > > > > > > > > > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > > > > > > index 54c4af35c628..1f951ac24a5e 100644 > > > > > > --- a/include/linux/page-flags.h > > > > > > +++ b/include/linux/page-flags.h > > > > > > @@ -180,6 +180,8 @@ enum pageflags { > > > > > > PG_reported = PG_uptodate, > > > > > > }; > > > > > > > > > > > > +#define PAGEFLAGS_MASK (~((1UL << NR_PAGEFLAGS) - 1)) > > > > > > > > > > Hm, isn't it better to invert it? Like > > > > > #define PAGEFLAGS_MASK ((1UL << NR_PAGEFLAGS) - 1) > > > > > > > > > > It feels more usual and will simplify the rest of the patch. > > > > > > > > Actually, I learned from PAGE_MASK. So I thought the macro > > > > like xxx_MASK should be the format of 0xff...ff00...00. I don't > > > > know if it is an unwritten rule. I can invert PAGEFLAGS_MASK > > > > if it's not a rule. > > > > > > There are many examples of both approached in the kernel tree, > > > however I'd say the more common is without "~" (out of my head). > > > > > > It's definitely OK to define it like > > > #define PAGEFLAGS_MASK ((1UL << NR_PAGEFLAGS) - 1) > > > > > > > PAGE_MASK has always seemed weird to me but I figured that emulating it > > would be the approach of least surprise. Might be wrong about that... > > IIUC, you seem to agree with the current approach. Right? We do use both schemes. PAGE_MASK, as you pointed out. PMD_MASK, PUD_MASK etc. also *hide* rather than extract the named bits. However, we already have a series of masks for page->flags in mm.h that follow the more common scheme of *extracting* the named bits: #define ZONES_MASK ((1UL << ZONES_WIDTH) - 1) #define NODES_MASK ((1UL << NODES_WIDTH) - 1) #define SECTIONS_MASK ((1UL << SECTIONS_WIDTH) - 1) #define LAST_CPUPID_MASK ((1UL << LAST_CPUPID_SHIFT) - 1) #define KASAN_TAG_MASK ((1UL << KASAN_TAG_WIDTH) - 1) #define ZONEID_MASK ((1UL << ZONEID_SHIFT) - 1) Because of that, I would agree with Roman here and say it probably makes sense to put the PAGEFLAGS_MASK definition next to those and follow the "mask everything but" semantics.