From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61D90C4338F for ; Fri, 30 Jul 2021 06:51:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 00B4D6101C for ; Fri, 30 Jul 2021 06:51:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 00B4D6101C Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 8D3746B0036; Fri, 30 Jul 2021 02:51:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 881728D0001; Fri, 30 Jul 2021 02:51:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 770016B006C; Fri, 30 Jul 2021 02:51:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id 5DB706B0036 for ; Fri, 30 Jul 2021 02:51:30 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0D1E1181BCDCB for ; Fri, 30 Jul 2021 06:51:30 +0000 (UTC) X-FDA: 78418333140.07.D2AF5FB Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf28.hostedemail.com (Postfix) with ESMTP id 91F289009F0B for ; Fri, 30 Jul 2021 06:51:29 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 6341022349; Fri, 30 Jul 2021 06:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1627627888; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JU3Y5J8NTdc7M6n9NoKsTCUbYMjkBBca/WKKJGoryDo=; b=GksVOKRfYmeR2RUP8XIfL2vg5hb5LIxjAS39cHhBHoJxg0KFftVR4wUpO4WzV5vGdycJ4z hG5JPhKddpFhD+SLE24qLZDzQU9riORLVGFrm71HqUSLeY3Dv21rQ4lq2lZXPefXht0JA9 nFpJIKLuppdSXu0VUNaji7ebeIY7DU0= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 2D163A3B87; Fri, 30 Jul 2021 06:51:28 +0000 (UTC) Date: Fri, 30 Jul 2021 08:51:27 +0200 From: Michal Hocko To: Miaohe Lin Cc: hannes@cmpxchg.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, shakeelb@google.com, guro@fb.com, willy@infradead.org, alexs@kernel.org, richard.weiyang@gmail.com, songmuchun@bytedance.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH 3/5] mm, memcg: save some atomic ops when flush is already true Message-ID: References: <20210729125755.16871-1-linmiaohe@huawei.com> <20210729125755.16871-4-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210729125755.16871-4-linmiaohe@huawei.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 91F289009F0B Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=GksVOKRf; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf28.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com X-Stat-Signature: hudo6wx4y7ao5ktt6psiwie1qkh4kffb X-HE-Tag: 1627627889-994262 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 29-07-21 20:57:53, Miaohe Lin wrote: > Add 'else' to save some atomic ops in obj_stock_flush_required() when > flush is already true. No functional change intended here. > > Signed-off-by: Miaohe Lin Acked-by: Michal Hocko > --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index a03e24e57cd9..5b4592d1e0f2 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2231,7 +2231,7 @@ static void drain_all_stock(struct mem_cgroup *root_memcg) > if (memcg && stock->nr_pages && > mem_cgroup_is_descendant(memcg, root_memcg)) > flush = true; > - if (obj_stock_flush_required(stock, root_memcg)) > + else if (obj_stock_flush_required(stock, root_memcg)) > flush = true; > rcu_read_unlock(); > > -- > 2.23.0 -- Michal Hocko SUSE Labs