From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECD6FC432BE for ; Fri, 30 Jul 2021 06:39:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 985EB60C51 for ; Fri, 30 Jul 2021 06:39:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 985EB60C51 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3B00B8D0001; Fri, 30 Jul 2021 02:39:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 338B76B005D; Fri, 30 Jul 2021 02:39:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FFCE8D0001; Fri, 30 Jul 2021 02:39:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0188.hostedemail.com [216.40.44.188]) by kanga.kvack.org (Postfix) with ESMTP id F3E1E6B0036 for ; Fri, 30 Jul 2021 02:39:16 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 865AB180240A7 for ; Fri, 30 Jul 2021 06:39:16 +0000 (UTC) X-FDA: 78418302312.31.84A7A7A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf06.hostedemail.com (Postfix) with ESMTP id 2531A801AF30 for ; Fri, 30 Jul 2021 06:39:16 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 21E291FDB1; Fri, 30 Jul 2021 06:39:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1627627155; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=agHfFzHW+xeGrdhw4hG5J5joqngPV2b0VMzApVyqQ8E=; b=PeRG1lTled8ApH7cHx8hsRdcE5UrL2oXTe256ZUWp/ZadsVhirozoTQeLdTqZoHnVZ0faD uzg08Gto5i2+eAUb8udHkBWFpdFHPw5lWAYyUYEwgW3/zu4yE0Jf5/+nDpOxtpNzrDQgRF NscVVZDtu9NtvzMgXo4UGqtbkegUass= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id E2190A3B87; Fri, 30 Jul 2021 06:39:14 +0000 (UTC) Date: Fri, 30 Jul 2021 08:39:13 +0200 From: Michal Hocko To: Baolin Wang Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memcontrol: Set the correct memcg swappiness restriction Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2531A801AF30 Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=PeRG1lTl; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf06.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com X-Stat-Signature: khyywmyjnow7d5qh6s5xfiknweeg5qu9 X-HE-Tag: 1627627156-898877 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 30-07-21 14:26:35, Baolin Wang wrote: > Since commit c843966c556d ("mm: allow swappiness that prefers reclaiming > anon over the file workingset") has expended the swappiness value to > make swap to be preferred in some systems. We should also change the > memcg swappiness restriction to allow memcg swap-preferred. > > Signed-off-by: Baolin Wang Yes, this looks like an omission. It doesn't really make sense to have two different constrains on the value. Acked-by: Michal Hocko Thanks! > --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 6580c23..988fc94 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -4046,7 +4046,7 @@ static int mem_cgroup_swappiness_write(struct cgroup_subsys_state *css, > { > struct mem_cgroup *memcg = mem_cgroup_from_css(css); > > - if (val > 100) > + if (val > 200) > return -EINVAL; > > if (!mem_cgroup_is_root(memcg)) > -- > 1.8.3.1 -- Michal Hocko SUSE Labs