From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61473C4338F for ; Thu, 29 Jul 2021 16:21:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C509F60E9B for ; Thu, 29 Jul 2021 16:21:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C509F60E9B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 0487E8D0001; Thu, 29 Jul 2021 12:21:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3B4C6B005D; Thu, 29 Jul 2021 12:21:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E29CF8D0001; Thu, 29 Jul 2021 12:21:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id C62526B0036 for ; Thu, 29 Jul 2021 12:21:22 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4C18F248B8 for ; Thu, 29 Jul 2021 16:21:22 +0000 (UTC) X-FDA: 78416140404.34.F4117A9 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf16.hostedemail.com (Postfix) with ESMTP id B9B48F0000A6 for ; Thu, 29 Jul 2021 16:21:21 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id A78D020061; Thu, 29 Jul 2021 16:21:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1627575680; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t012uWsF/p/ncJgBtbiwHbjc70VAkY0WVH/DmM2Q0+s=; b=kqtPRwrkKn2TTZ3ZTf9Pj9xxtWP3TKJ9spCqGVbMHulRak1717Abfu7cV58JE4mZ9xZSsO Swz+AwGVgaYNUFMdaeqL83bUGo9baxa9nm+o/8IrkEn7SJraDNs8N8Y+2j1el+tyB4CeTw wQGsH/UH9ORO6TSGkO+kUECLPZnWf/A= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 5368DA3B85; Thu, 29 Jul 2021 16:21:15 +0000 (UTC) Date: Thu, 29 Jul 2021 18:21:19 +0200 From: Michal Hocko To: Feng Tang Cc: linux-mm@kvack.org, Andrew Morton , David Rientjes , Dave Hansen , Ben Widawsky , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Andrea Arcangeli , Mel Gorman , Mike Kravetz , Randy Dunlap , Vlastimil Babka , Andi Kleen , Dan Williams , ying.huang@intel.com, Dave Hansen Subject: Re: [PATCH v6 1/6] mm/mempolicy: Add MPOL_PREFERRED_MANY for multiple preferred nodes Message-ID: References: <1626077374-81682-1-git-send-email-feng.tang@intel.com> <1626077374-81682-2-git-send-email-feng.tang@intel.com> <20210728141156.GC43486@shbuild999.sh.intel.com> <20210729070918.GA96680@shbuild999.sh.intel.com> <20210729151242.GA42865@shbuild999.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210729151242.GA42865@shbuild999.sh.intel.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B9B48F0000A6 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=kqtPRwrk; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf16.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com X-Stat-Signature: jhmjdqq9whp7crbrhzohfygryyh3kep9 X-HE-Tag: 1627575681-350035 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 29-07-21 23:12:42, Feng Tang wrote: > On Thu, Jul 29, 2021 at 03:38:44PM +0200, Michal Hocko wrote: [...] > > Also the > > semantic to give nodes some ordering based on their numbers sounds > > rather weird to me. > > I agree, and as I admitted in the first reply, this need to be fixed. OK. I was not really clear that we are on the same page here. > > The semantic I am proposing is to allocate from prefered nodes in > > distance order starting from the local node. > > So the plan is: > * if the local node is set in 'prefer-many's nodemask, then chose > * otherwise chose the node with the shortest distance to local node > ? Yes and what I am trying to say is that you will achieve that simply by doing the following in policy_node: if (policy->mode == MPOL_PREFERRED_MANY) return nd; -- Michal Hocko SUSE Labs