From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59A77C432BE for ; Fri, 6 Aug 2021 13:27:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DB09061104 for ; Fri, 6 Aug 2021 13:27:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DB09061104 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 189FA8D0001; Fri, 6 Aug 2021 09:27:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1395C6B0071; Fri, 6 Aug 2021 09:27:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 026F38D0001; Fri, 6 Aug 2021 09:27:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0152.hostedemail.com [216.40.44.152]) by kanga.kvack.org (Postfix) with ESMTP id DA34D6B006C for ; Fri, 6 Aug 2021 09:27:53 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7CE2618043658 for ; Fri, 6 Aug 2021 13:27:53 +0000 (UTC) X-FDA: 78444733626.13.C9EB03C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf20.hostedemail.com (Postfix) with ESMTP id DE04AD008C48 for ; Fri, 6 Aug 2021 13:27:52 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id C13E41FE58; Fri, 6 Aug 2021 13:27:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1628256471; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BIrIr2JHOUXujG0/ZIq8z/HG/qc7xRJ1Ya7B7C+n03I=; b=USmH0WXxJg+bdsSvc9rx3Xu+1NafJrMq94VVFau0PZTrTbFs42u15zI8bJxhrESWdXP7h6 KzmL4+FzJVVULB5ZZzw9Uw9WXVAJ3QceVKLC8cjsoYEYnwIqp0+hV20ycZdp1iDQrdU3lR D0cdmCOacZTWMpYGi/Y4fVQDq0guNq0= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 8C85FA3B8B; Fri, 6 Aug 2021 13:27:51 +0000 (UTC) Date: Fri, 6 Aug 2021 15:27:48 +0200 From: Michal Hocko To: Feng Tang Cc: linux-mm@kvack.org, Andrew Morton , David Rientjes , Dave Hansen , Ben Widawsky , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Andrea Arcangeli , Mel Gorman , Mike Kravetz , Randy Dunlap , Vlastimil Babka , Andi Kleen , Dan Williams , ying.huang@intel.com, Dave Hansen Subject: Re: [PATCH v7 1/5] mm/mempolicy: Add MPOL_PREFERRED_MANY for multiple preferred nodes Message-ID: References: <1627970362-61305-1-git-send-email-feng.tang@intel.com> <1627970362-61305-2-git-send-email-feng.tang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1627970362-61305-2-git-send-email-feng.tang@intel.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DE04AD008C48 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=USmH0WXx; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf20.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com X-Stat-Signature: rwnxfszype5aikus7ty75itxs3nwug8b X-HE-Tag: 1628256472-414154 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 03-08-21 13:59:18, Feng Tang wrote: [...] > @@ -1936,7 +1969,9 @@ unsigned int mempolicy_slab_node(void) > case MPOL_INTERLEAVE: > return interleave_nodes(policy); > > - case MPOL_BIND: { > + case MPOL_BIND: > + case MPOL_PREFERRED_MANY: > + { > struct zoneref *z; I guess this is ok for now but it would be great if slab maintainers could have a look here. I suspect this will need some more changes. E.g. I find it highly suspicious how fallback_alloc uses mempolicy_slab_node. Let's say that the local node is not a part of the nodemask. mempolicy_slab_node will switch to the first node in the order list which is ok but fallback_alloc then iterates over the whole zonelist without any policy node mask constrains. get_any_partial looks very similar. -- Michal Hocko SUSE Labs