From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAF9BC4338F for ; Sat, 24 Jul 2021 01:44:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1B57F60EBA for ; Sat, 24 Jul 2021 01:44:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1B57F60EBA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 123C36B0033; Fri, 23 Jul 2021 21:44:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D4716B005D; Fri, 23 Jul 2021 21:44:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F049F6B006C; Fri, 23 Jul 2021 21:44:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0163.hostedemail.com [216.40.44.163]) by kanga.kvack.org (Postfix) with ESMTP id D31796B0033 for ; Fri, 23 Jul 2021 21:44:05 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 57D5A8249980 for ; Sat, 24 Jul 2021 01:44:05 +0000 (UTC) X-FDA: 78395785650.16.063BAFE Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [142.44.231.140]) by imf20.hostedemail.com (Postfix) with ESMTP id D9653D0019A6 for ; Sat, 24 Jul 2021 01:44:04 +0000 (UTC) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m76fo-003Lco-9E; Sat, 24 Jul 2021 01:41:52 +0000 Date: Sat, 24 Jul 2021 01:41:52 +0000 From: Al Viro To: Andrew Morton Cc: bugs+kernel.org@dtnr.ch, dhowells@redhat.com, linux-mm@kvack.org, mike.kravetz@oracle.com, mm-commits@vger.kernel.org, stable@vger.kernel.org, torvalds@linux-foundation.org, willy@infradead.org Subject: Re: [patch 15/15] hugetlbfs: fix mount mode command line processing Message-ID: References: <20210723154926.c6cda0f262b1990b950a5886@linux-foundation.org> <20210723225044.DpiHGbzxj%akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210723225044.DpiHGbzxj%akpm@linux-foundation.org> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D9653D0019A6 Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=none; spf=none (imf20.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 142.44.231.140) smtp.mailfrom=viro@ftp.linux.org.uk X-Stat-Signature: yk5hwg373y4476u934obacudadyfxnxk X-HE-Tag: 1627091044-617691 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 23, 2021 at 03:50:44PM -0700, Andrew Morton wrote: > From: Mike Kravetz > Subject: hugetlbfs: fix mount mode command line processing > > In commit 32021982a324 ("hugetlbfs: Convert to fs_context") processing of > the mount mode string was changed from match_octal() to fsparam_u32. This > changed existing behavior as match_octal does not require octal values to > have a '0' prefix, but fsparam_u32 does. > > Use fsparam_u32oct which provides the same behavior as match_octal. Looks sane... Which tree do you want it to go through?