From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 065DFC6377D for ; Thu, 22 Jul 2021 11:01:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A0D5A60FED for ; Thu, 22 Jul 2021 11:01:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0D5A60FED Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 342D96B0036; Thu, 22 Jul 2021 07:01:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F2C86B005D; Thu, 22 Jul 2021 07:01:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BB446B006C; Thu, 22 Jul 2021 07:01:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0019.hostedemail.com [216.40.44.19]) by kanga.kvack.org (Postfix) with ESMTP id 024226B0036 for ; Thu, 22 Jul 2021 07:01:07 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A29522203D for ; Thu, 22 Jul 2021 11:01:07 +0000 (UTC) X-FDA: 78389931774.26.42AD5EB Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf01.hostedemail.com (Postfix) with ESMTP id 377E8501D1E4 for ; Thu, 22 Jul 2021 11:01:07 +0000 (UTC) Received: by mail-wr1-f51.google.com with SMTP id i94so5462507wri.4 for ; Thu, 22 Jul 2021 04:01:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yw+1MR2KgBc9luUx0cAPZIkqUAmN57bRrzE4rXs4RXE=; b=YrvoAqcZ3pjMit8K5uQ4lV8aD+UMAEVxI3bIcq7wcK9y8r35qoGTVmstJBHJ/vxZbs updxXU7rJi3zDrcY13xc56g7QZHX9wAWhbnG1KRap7i+MTL41YVBKaBrWryi0PYS5sPE hAuYUeFYuGJdwBB24WWKytx98ts3a8kZWEFTkm6sV3XGQZxqagWUrawvKuuRKJzqDojg SQyuXzqLVp5fSbIRsvhmsED5D7/Ob4DP0gWTcerwadDyiItBj42QelSlm2bIRZcGfuLV mkXsREeOs11h3Lkh2OB0hyp6UCd/58iBubIC6ZSwvl6TKYxlJOs8U5x0XYkm27DF4JXz zLmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yw+1MR2KgBc9luUx0cAPZIkqUAmN57bRrzE4rXs4RXE=; b=e1EvPr1nqDLXdn9MdASpqHS1/qXBg9Vs7MdoxPCg/1EMy1ZzgX5K4H7jwgYL1QrzI8 z2ifmxVax0ac5Du7ZecIwAx7Mmzi0WdoDTg3zIY7whUA7r7V819B56CrwVldEGeaftXv shEbPI1SVuLRrS1UtnxUgtxg7CmoumQyP126PSNVlTWQj+ItlWnTTRqQOOkoz85cYDUb aThAh+49UWnBEUmX9D72E46tMcejVNopkfSbggNKMwahoWetk1dGsnB5ZKeff3lqbkQy 115VMq9YZeBY+6NDoYX/jCsPYQjxI4iWaeZs1cK0RBIgpBBnnVY2GS+jF8UphmP+Uz/f Pqiw== X-Gm-Message-State: AOAM531EypEW71BsSDozjWb9lBzLDgIB0Cjiyg5EmowUEYJR4L4v8WEb y06+u8VCihkiOErwR3cIHwItIg== X-Google-Smtp-Source: ABdhPJxoe+m7SpT35NQc2fTiiRalGqem0yhndVZ3OAcEmw8Um36eLeMOFTpgLyePBa7OHXZwgmNSBw== X-Received: by 2002:adf:ffd1:: with SMTP id x17mr26958377wrs.411.1626951665168; Thu, 22 Jul 2021 04:01:05 -0700 (PDT) Received: from elver.google.com ([2a00:79e0:15:13:f1d2:f5fd:de90:c735]) by smtp.gmail.com with ESMTPSA id a8sm29702579wrt.61.2021.07.22.04.01.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jul 2021 04:01:04 -0700 (PDT) Date: Thu, 22 Jul 2021 13:00:58 +0200 From: Marco Elver To: Kefeng Wang Cc: Catalin Marinas , Will Deacon , Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org Subject: Re: [PATCH v2 3/3] kasan: arm64: Fix pcpu_page_first_chunk crash with KASAN_VMALLOC Message-ID: References: <20210720025105.103680-1-wangkefeng.wang@huawei.com> <20210720025105.103680-4-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210720025105.103680-4-wangkefeng.wang@huawei.com> User-Agent: Mutt/2.0.5 (2021-01-21) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=YrvoAqcZ; spf=pass (imf01.hostedemail.com: domain of elver@google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: 6yjh9c53qewwasfa6pa8bag8un6gnn1h X-Rspamd-Queue-Id: 377E8501D1E4 X-Rspamd-Server: rspam01 X-HE-Tag: 1626951667-479867 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 20, 2021 at 10:51AM +0800, Kefeng Wang wrote: > With KASAN_VMALLOC and NEED_PER_CPU_PAGE_FIRST_CHUNK, it crashs, > > Unable to handle kernel paging request at virtual address ffff7000028f2000 > ... > swapper pgtable: 64k pages, 48-bit VAs, pgdp=0000000042440000 > [ffff7000028f2000] pgd=000000063e7c0003, p4d=000000063e7c0003, pud=000000063e7c0003, pmd=000000063e7b0003, pte=0000000000000000 > Internal error: Oops: 96000007 [#1] PREEMPT SMP > Modules linked in: > CPU: 0 PID: 0 Comm: swapper Not tainted 5.13.0-rc4-00003-gc6e6e28f3f30-dirty #62 > Hardware name: linux,dummy-virt (DT) > pstate: 200000c5 (nzCv daIF -PAN -UAO -TCO BTYPE=--) > pc : kasan_check_range+0x90/0x1a0 > lr : memcpy+0x88/0xf4 > sp : ffff80001378fe20 > ... > Call trace: > kasan_check_range+0x90/0x1a0 > pcpu_page_first_chunk+0x3f0/0x568 > setup_per_cpu_areas+0xb8/0x184 > start_kernel+0x8c/0x328 > > The vm area used in vm_area_register_early() has no kasan shadow memory, > Let's add a new kasan_populate_early_vm_area_shadow() function to populate > the vm area shadow memory to fix the issue. > > Signed-off-by: Kefeng Wang Acked-by: Marco Elver for the kasan bits. > --- > arch/arm64/mm/kasan_init.c | 17 +++++++++++++++++ > include/linux/kasan.h | 6 ++++++ > mm/kasan/init.c | 5 +++++ > mm/vmalloc.c | 1 + > 4 files changed, 29 insertions(+) > > diff --git a/arch/arm64/mm/kasan_init.c b/arch/arm64/mm/kasan_init.c > index 61b52a92b8b6..46c1b3722901 100644 > --- a/arch/arm64/mm/kasan_init.c > +++ b/arch/arm64/mm/kasan_init.c > @@ -287,6 +287,23 @@ static void __init kasan_init_depth(void) > init_task.kasan_depth = 0; > } > > +#ifdef CONFIG_KASAN_VMALLOC > +void __init kasan_populate_early_vm_area_shadow(void *start, unsigned long size) > +{ > + unsigned long shadow_start, shadow_end; > + > + if (!is_vmalloc_or_module_addr(start)) > + return; > + > + shadow_start = (unsigned long)kasan_mem_to_shadow(start); > + shadow_start = ALIGN_DOWN(shadow_start, PAGE_SIZE); > + shadow_end = (unsigned long)kasan_mem_to_shadow(start + size); > + shadow_end = ALIGN(shadow_end, PAGE_SIZE); > + kasan_map_populate(shadow_start, shadow_end, > + early_pfn_to_nid(virt_to_pfn(start))); > +} > +#endif > + > void __init kasan_init(void) > { > kasan_init_shadow(); > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > index dd874a1ee862..3f8c26d9ef82 100644 > --- a/include/linux/kasan.h > +++ b/include/linux/kasan.h > @@ -133,6 +133,8 @@ struct kasan_cache { > bool is_kmalloc; > }; > > +void kasan_populate_early_vm_area_shadow(void *start, unsigned long size); > + > slab_flags_t __kasan_never_merge(void); > static __always_inline slab_flags_t kasan_never_merge(void) > { > @@ -303,6 +305,10 @@ void kasan_restore_multi_shot(bool enabled); > > #else /* CONFIG_KASAN */ > > +static inline void kasan_populate_early_vm_area_shadow(void *start, > + unsigned long size) > +{ } > + > static inline slab_flags_t kasan_never_merge(void) > { > return 0; > diff --git a/mm/kasan/init.c b/mm/kasan/init.c > index cc64ed6858c6..d39577d088a1 100644 > --- a/mm/kasan/init.c > +++ b/mm/kasan/init.c > @@ -279,6 +279,11 @@ int __ref kasan_populate_early_shadow(const void *shadow_start, > return 0; > } > > +void __init __weak kasan_populate_early_vm_area_shadow(void *start, > + unsigned long size) > +{ > +} > + > static void kasan_free_pte(pte_t *pte_start, pmd_t *pmd) > { > pte_t *pte; > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index a98cf97f032f..f19e07314ee5 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2249,6 +2249,7 @@ void __init vm_area_register_early(struct vm_struct *vm, size_t align) > vm->addr = (void *)addr; > > vm_area_add_early(vm); > + kasan_populate_early_vm_area_shadow(vm->addr, vm->size); > } > > static void vmap_init_free_space(void) > -- > 2.26.2