From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BDD0C6377A for ; Wed, 21 Jul 2021 21:50:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AD94C60725 for ; Wed, 21 Jul 2021 21:50:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD94C60725 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 471EE6B0074; Wed, 21 Jul 2021 17:50:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4220A6B0075; Wed, 21 Jul 2021 17:50:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 310146B0078; Wed, 21 Jul 2021 17:50:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id 160406B0074 for ; Wed, 21 Jul 2021 17:50:19 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B3004824805A for ; Wed, 21 Jul 2021 21:50:18 +0000 (UTC) X-FDA: 78387938916.15.D7ACF2C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 48C908029B7D for ; Wed, 21 Jul 2021 21:50:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626904217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mPmN8sJkfymkPUXPwPH3Wq9PCWu/VANbjmJ5RH7HOTE=; b=YJgSCIEhNwQO4bkNrb5wtN5y8thg+1u2cTIJ4uZpq3ev3v3JDS5TKj93f7OBqmKOp3iasH FugwHu5g0JXB4yDu+TtE5r6w9SgGZFgBfAyJ5e+MGdl/OwRFZ7Djfqlv6Mgf2cCu9eiDKm dPigbFUhUbYa7NWiZ/3AV2xbVBzBu9A= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-324-LCleVIilPRiDKT3g1gPiJQ-1; Wed, 21 Jul 2021 17:50:14 -0400 X-MC-Unique: LCleVIilPRiDKT3g1gPiJQ-1 Received: by mail-qt1-f200.google.com with SMTP id b6-20020a05622a0206b029025eb726dd9bso2310673qtx.8 for ; Wed, 21 Jul 2021 14:50:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mPmN8sJkfymkPUXPwPH3Wq9PCWu/VANbjmJ5RH7HOTE=; b=gg7SKPdQNqMB5MWyoglSJsLIHFeOHHiCCjbzgvqpuAH+h7FgeOnNeR9qQAi4vWtQ+B 0Wmv/0yCqtD7FO5MhnWoiaGwxdOZAR5RAgkfcYhIM6q/jbX/hFfo8ZlqHhZ/Iq5mLEWb eZPyE2hvZ7XbZarKfWP0bn6H6zsvYl87B9owl3YbFK26xKJKbCJYh1Yp6Jqr+cQkw7hm 4hI9bPkLd5bi+NMYOP3888j6Lwh+A0R+iGUjvYE2OOY3vldGQJ5JnPJsv/3YLA/yOxJ0 3M+EOqMbYWbD0LWL2JHGm+rUP6K6RISgeWtRg6V3f72OtinL1yEiavo0b5l6eMiEl5Bb 7h3Q== X-Gm-Message-State: AOAM530+A+knt9iD5mPv8rqTEc1s/083jJqLjuftcrx+mPM6U3rcPs4y xVhVIaumBrKP6UNgNhz3PcP3ghtWyPkr/GH8gOL9fMI4vXIxE8bAG9dse20vhkeBBwsi1q47nTU uFlGssjAukUk= X-Received: by 2002:a05:620a:e14:: with SMTP id y20mr36949609qkm.335.1626904213903; Wed, 21 Jul 2021 14:50:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyUWTbLjNWzwmzZVRpOjvzJV5EqTVFguc6bo+55jLpqedNVEMhn0/g6qiiobE/wzCSbEmMD5g== X-Received: by 2002:a05:620a:e14:: with SMTP id y20mr36949586qkm.335.1626904213646; Wed, 21 Jul 2021 14:50:13 -0700 (PDT) Received: from t490s (bras-base-toroon474qw-grc-65-184-144-111-238.dsl.bell.ca. [184.144.111.238]) by smtp.gmail.com with ESMTPSA id c16sm9607474qtv.32.2021.07.21.14.50.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jul 2021 14:50:12 -0700 (PDT) Date: Wed, 21 Jul 2021 17:50:11 -0400 From: Peter Xu To: kernel test robot Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, clang-built-linux@googlegroups.com, kbuild-all@lists.01.org, Axel Rasmussen , Nadav Amit , Jerome Glisse , "Kirill A . Shutemov" , Jason Gunthorpe , Alistair Popple , Andrew Morton Subject: Re: [PATCH v5 17/26] hugetlb/userfaultfd: Hook page faults for uffd write protection Message-ID: References: <20210715201622.211762-1-peterx@redhat.com> <202107202342.QQMFPRAI-lkp@intel.com> MIME-Version: 1.0 In-Reply-To: <202107202342.QQMFPRAI-lkp@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 48C908029B7D X-Stat-Signature: ejx8bbrtapnjcq7wnjit7y1ghbqf4o9c Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YJgSCIEh; spf=none (imf06.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1626904218-996596 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 20, 2021 at 11:37:36PM +0800, kernel test robot wrote: > config: s390-randconfig-r023-20210716 (attached as .config) [...] > >> mm/hugetlb.c:5063:29: error: implicit declaration of function 'huge_pte_uffd_wp' [-Werror,-Wimplicit-function-declaration] > if (userfaultfd_wp(vma) && huge_pte_uffd_wp(huge_ptep_get(ptep)) && > ^ > 12 warnings and 1 error generated. I remember I raised this question once on why s390 redefines a lot of huge pte operations on its own even if they're defined the same in generic hugetlb.h.. I think there was a plan to rework that but definitely not landed yet. Will sqaush below into the patch "mm/hugetlb: Introduce huge pte version of uffd-wp helpers": ---8<--- diff --git a/arch/s390/include/asm/hugetlb.h b/arch/s390/include/asm/hugetlb.h index 60f9241e5e4a..19c4b4431d27 100644 --- a/arch/s390/include/asm/hugetlb.h +++ b/arch/s390/include/asm/hugetlb.h @@ -115,6 +115,21 @@ static inline pte_t huge_pte_modify(pte_t pte, pgprot_t newprot) return pte_modify(pte, newprot); } +static inline pte_t huge_pte_mkuffd_wp(pte_t pte) +{ + return pte; +} + +static inline pte_t huge_pte_clear_uffd_wp(pte_t pte) +{ + return pte; +} + +static inline int huge_pte_uffd_wp(pte_t pte) +{ + return 0; +} + static inline bool gigantic_page_runtime_supported(void) { return true; ---8<--- Thanks, -- Peter Xu