From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCEBBC12002 for ; Wed, 21 Jul 2021 13:19:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7866E6120D for ; Wed, 21 Jul 2021 13:19:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7866E6120D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 06EB56B0033; Wed, 21 Jul 2021 09:19:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 01F9C6B006C; Wed, 21 Jul 2021 09:19:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D700D6B0071; Wed, 21 Jul 2021 09:19:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0088.hostedemail.com [216.40.44.88]) by kanga.kvack.org (Postfix) with ESMTP id B70336B0033 for ; Wed, 21 Jul 2021 09:19:55 -0400 (EDT) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve04.hostedemail.com (Postfix) with ESMTP id F0E462288E for ; Wed, 21 Jul 2021 09:44:37 +0000 (UTC) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9518918524E49 for ; Wed, 21 Jul 2021 09:44:37 +0000 (UTC) X-FDA: 78386110194.38.FC2F9EB Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf03.hostedemail.com (Postfix) with ESMTP id 53D5B30002FE for ; Wed, 21 Jul 2021 09:44:37 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id C6C5760BD3; Wed, 21 Jul 2021 09:44:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626860676; bh=5i/qmH4alWxdVkgDs3KPdq+gTt6IvLSVBOVfIwtm4gk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uAe1e8+kTwckG36+6Jis6ef/X+PQSooe63JLr55JIdETVNpOBpMbajyKdqt+JrIbt Y8WtR3oFxZeIiY9X3QewX/BTAzyqqWAxXjcjkBEsx8d2a7fwgmqt87sO52LlXsTfqW 03x8r1EHfR1AZh33SdEd3wBWiVjH2U9K8S8e7wY6fvGmZXKt+zLovWvKLtaFD7gKEo bWtRRC4N1Aciu3Cw48BULTU2qHnkOiuTeUxyGHg/fmjSrtLMd3JrSLwZIwtXhX15HU nAxle0NVtQ5izaPSILmkhqy+0CjRZVq+c6Xzvd9IGECf/X2vbVNsAO98vGUa8hqlQV 9HqiUnPXy7Ccg== Date: Wed, 21 Jul 2021 12:44:29 +0300 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Vlastimil Babka , William Kucharski , Christoph Hellwig , "Kirill A . Shutemov" Subject: Re: [PATCH v14 031/138] fs/netfs: Add folio fscache functions Message-ID: References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-32-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210715033704.692967-32-willy@infradead.org> Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uAe1e8+k; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam05 X-Stat-Signature: oqatt131oyixx47k8e5s88h331q466iz X-Rspamd-Queue-Id: 53D5B30002FE X-HE-Tag: 1626860677-252766 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 15, 2021 at 04:35:17AM +0100, Matthew Wilcox (Oracle) wrote: > Match the page writeback functions by adding > folio_start_fscache(), folio_end_fscache(), folio_wait_fscache() and > folio_wait_fscache_killable(). Remove set_page_private_2(). Also rewrite > the kernel-doc to describe when to use the function rather than what the > function does, and include the kernel-doc in the appropriate rst file. > Saves 31 bytes of text in netfs_rreq_unlock() due to set_page_fscache() > calling page_folio() once instead of three times. > > Signed-off-by: Matthew Wilcox (Oracle) > Acked-by: Vlastimil Babka > Reviewed-by: William Kucharski > Reviewed-by: Christoph Hellwig > Acked-by: Kirill A. Shutemov > --- > Documentation/filesystems/netfs_library.rst | 2 + > include/linux/netfs.h | 75 +++++++++++++-------- > include/linux/pagemap.h | 16 ----- > 3 files changed, 50 insertions(+), 43 deletions(-) Acked-by: Mike Rapoport