From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41A0DC07E9B for ; Tue, 20 Jul 2021 10:42:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E3F6961186 for ; Tue, 20 Jul 2021 10:42:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3F6961186 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 93D4B6B00CA; Tue, 20 Jul 2021 06:42:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89E6D6B00CB; Tue, 20 Jul 2021 06:42:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73FF46B00CC; Tue, 20 Jul 2021 06:42:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0083.hostedemail.com [216.40.44.83]) by kanga.kvack.org (Postfix) with ESMTP id 5151B6B00CA for ; Tue, 20 Jul 2021 06:42:42 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DBC43185044C3 for ; Tue, 20 Jul 2021 10:42:40 +0000 (UTC) X-FDA: 78382627680.10.58DA9A6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf11.hostedemail.com (Postfix) with ESMTP id 93BBBF000211 for ; Tue, 20 Jul 2021 10:42:40 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id E4BA361165; Tue, 20 Jul 2021 10:42:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626777759; bh=YQE7P7lLZR07h6/dfoxegMJc7T4H7tBElA2h22TtAZY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LVJSPLXfpMKKlvvUdM4PhX0CswRtMmdEoVcUrZ+AsHkuNuEYeIZ1A6kXx4f5AWyr6 5eG+3xt2Bm7qrjY0HZZVQ2naR/XkUnKuRAsPCkNleW5G91V/nh9zts2TTEzBoEawFB MwJIbzahzr7AQKpqlibg487dKNgpKmsG0IyarQ0OBGf4u57VTvIxv1aLbnUWQXhpJL R2+OllOStYHimMW5a+NjypHW/tjnYHUK8uIl4aTROzzfTpoA88Vwwrirb5WvkimfRF Qwszl19dveDmIm0GtJ2FTydzr2gnoGy75GpubZIPOhIz8wSne0xFqDOmA/02KjVGXs 2nDaV35hcOfUw== Date: Tue, 20 Jul 2021 13:42:32 +0300 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , Jeff Layton , "Kirill A . Shutemov" , William Kucharski , David Howells Subject: Re: [PATCH v14 017/138] mm/filemap: Add folio_unlock() Message-ID: References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-18-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210715033704.692967-18-willy@infradead.org> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 93BBBF000211 X-Stat-Signature: xk7sipmjcu3hi8k5q59uqnbou6bitbxy Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LVJSPLXf; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org X-HE-Tag: 1626777760-780869 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 15, 2021 at 04:35:03AM +0100, Matthew Wilcox (Oracle) wrote: > Convert unlock_page() to call folio_unlock(). By using a folio we > avoid a call to compound_head(). This shortens the function from 39 > bytes to 25 and removes 4 instructions on x86-64. Because we still > have unlock_page(), it's a net increase of 16 bytes of text for the > kernel as a whole, but any path that uses folio_unlock() will execute > 4 fewer instructions. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > Acked-by: Jeff Layton > Acked-by: Kirill A. Shutemov > Reviewed-by: William Kucharski > Reviewed-by: David Howells > --- > include/linux/pagemap.h | 3 ++- > mm/filemap.c | 29 ++++++++++++----------------- > mm/folio-compat.c | 6 ++++++ > 3 files changed, 20 insertions(+), 18 deletions(-) Acked-by: Mike Rapoport