From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 832FFC07E9B for ; Mon, 19 Jul 2021 20:12:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 11396610FB for ; Mon, 19 Jul 2021 20:12:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11396610FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 769198D00F4; Mon, 19 Jul 2021 16:12:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 719D78D00EC; Mon, 19 Jul 2021 16:12:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56BD68D00F4; Mon, 19 Jul 2021 16:12:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id 2E1E08D00EC for ; Mon, 19 Jul 2021 16:12:53 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C1084184DB44B for ; Mon, 19 Jul 2021 20:12:51 +0000 (UTC) X-FDA: 78380435742.05.16B6D53 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 5F85D400208D for ; Mon, 19 Jul 2021 20:12:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626725570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FI9WwX0wcExs79cKeg3MMrdW0EBSFQQcNQYgqECOIAA=; b=AP9hDPpTpnJD1CdLKr9WC5DwoqqWI21K9VJGSxxVfE4tDsNlBETIk8mV3R8OsJs98Gmd0L u6DLlLcT1AjSLoNf8IEbU7eI4KZYsdxbj75BS7zkTR4h6vnwoepOG5WuQvKqytsygHJmuL UBdWNjuilsw/ecKfQ7EhiWgm+NpHMAw= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-195-ZTOIOFX-N76A8H-Kel7GZQ-1; Mon, 19 Jul 2021 16:12:47 -0400 X-MC-Unique: ZTOIOFX-N76A8H-Kel7GZQ-1 Received: by mail-qv1-f70.google.com with SMTP id c22-20020a0ca9d60000b02902e60d75210eso16336253qvb.19 for ; Mon, 19 Jul 2021 13:12:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FI9WwX0wcExs79cKeg3MMrdW0EBSFQQcNQYgqECOIAA=; b=XNZNA8VRHfjSDgYoIvbB6nQ+e8aUxB9gr4Zl2Vi12P0f7Ei1h2d4igv5wdbOnjzkpd LLE2dLndH2jPNKjFLmn9UMqMvXAgrxU5sfDt9aQPgkVcKkKTdl/mP2gXT3s22eNFdg2p Rwdm2I0MYsdRNniH2pe/OhwAiNG2LJR0N3MpSOWxCFFWF/SHPRqn6XD8eLhpoF/a2yvd Mf/xA6hvynXG5lXiD2ZMdOk3zD3dSUIxvi3BA21VnBd6dBoIvF8QYjWzcm7INfto1b/W NEbpyGkDaFZ2zq0gfpNppb0BPTeUupcoo9PQYnb4x4SepexaUkzdOgBixu+dz98fSq3e LTZQ== X-Gm-Message-State: AOAM5329BXVuFQJdZQSlki3JLau2pPBD8i0Jvag27ZuuotgcJkp7oBB+ IzYFdYPmn8JKIwj0xc3M2bnQj17uqGQ13lzrLx1k9Dp3PaVQrgySOCmgX/z5vQ/vkat+HT5xUUG MLL09+UuV7hA= X-Received: by 2002:ad4:4690:: with SMTP id bq16mr26378807qvb.23.1626725566851; Mon, 19 Jul 2021 13:12:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+rYmSDiBVy4tlVU0gkJtGNs9l7kA/aHowBz43PA8lQIe3UKnJmsJfnMmZ0zqAUsH2mFReoA== X-Received: by 2002:ad4:4690:: with SMTP id bq16mr26378779qvb.23.1626725566623; Mon, 19 Jul 2021 13:12:46 -0700 (PDT) Received: from t490s (bras-base-toroon474qw-grc-65-184-144-111-238.dsl.bell.ca. [184.144.111.238]) by smtp.gmail.com with ESMTPSA id j2sm6335256qtn.46.2021.07.19.13.12.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jul 2021 13:12:46 -0700 (PDT) Date: Mon, 19 Jul 2021 16:12:44 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jason Gunthorpe , Mike Kravetz , Alistair Popple , Matthew Wilcox , "Kirill A . Shutemov" , Hugh Dickins , Tiberiu Georgescu , Andrea Arcangeli , Axel Rasmussen , Nadav Amit , Mike Rapoport , Jerome Glisse , Andrew Morton , Miaohe Lin Subject: Re: [PATCH v5 00/26] userfaultfd-wp: Support shmem and hugetlbfs Message-ID: References: <20210715201422.211004-1-peterx@redhat.com> <251ed5e3-d898-efdc-ca5c-7b047dc80cb4@redhat.com> MIME-Version: 1.0 In-Reply-To: <251ed5e3-d898-efdc-ca5c-7b047dc80cb4@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AP9hDPpT; spf=none (imf18.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam02 X-Stat-Signature: 34f8djidtgooneyjpyorx3awk7e1e4tz X-Rspamd-Queue-Id: 5F85D400208D X-HE-Tag: 1626725571-99944 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 19, 2021 at 09:21:18PM +0200, David Hildenbrand wrote: > Hi Peter, Hi, David, > > I just stumbled over copy_page_range() optimization > > /* > * Don't copy ptes where a page fault will fill them correctly. > * Fork becomes much lighter when there are big shared or private > * readonly mappings. The tradeoff is that copy_page_range is more > * efficient than faulting. > */ > if (!(src_vma->vm_flags & (VM_HUGETLB | VM_PFNMAP | VM_MIXEDMAP)) && > !src_vma->anon_vma) > return 0; > > IIUC, that means you'll not copy the WP bits for shmem and, > therefore, lose them during fork. Good point. I think the fix shouldn't be hard - we can also skip this if dst_vma->vm_flags has VM_UFFD_WP set (that means UFFD_FEATURE_EVENT_FORK is enabled too). But I'll check a bit into page copy later to make sure it works (maybe I'll add a small test case too). Thanks! -- Peter Xu