From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11AC1C07E9D for ; Mon, 19 Jul 2021 12:57:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A654C610A5 for ; Mon, 19 Jul 2021 12:57:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A654C610A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4DA8F6B0252; Mon, 19 Jul 2021 08:57:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B1DE6B0253; Mon, 19 Jul 2021 08:57:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37B116B0254; Mon, 19 Jul 2021 08:57:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id 169E86B0252 for ; Mon, 19 Jul 2021 08:57:16 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id AC71524388 for ; Mon, 19 Jul 2021 12:57:14 +0000 (UTC) X-FDA: 78379337988.03.A2DF580 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf15.hostedemail.com (Postfix) with ESMTP id 972F7D00009C for ; Mon, 19 Jul 2021 12:57:13 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10049"; a="207933119" X-IronPort-AV: E=Sophos;i="5.84,252,1620716400"; d="scan'208";a="207933119" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2021 05:57:11 -0700 X-IronPort-AV: E=Sophos;i="5.84,252,1620716400"; d="scan'208";a="656832866" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2021 05:57:10 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1m5SpT-00FWIJ-VE; Mon, 19 Jul 2021 15:57:03 +0300 Date: Mon, 19 Jul 2021 15:57:03 +0300 From: Andy Shevchenko To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH v1 1/1] mm/util: Rephrase documentation for kmemdup_nul() to clarify input Message-ID: References: <20210719122002.41334-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Authentication-Results: imf15.hostedemail.com; dkim=none; spf=none (imf15.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none) X-Stat-Signature: 4r1o7ez3pyoqc6wi3w7x9cbh4mghbd7q X-Rspamd-Queue-Id: 972F7D00009C X-Rspamd-Server: rspam01 X-HE-Tag: 1626699433-322556 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 19, 2021 at 01:44:22PM +0100, Matthew Wilcox wrote: > On Mon, Jul 19, 2021 at 03:20:02PM +0300, Andy Shevchenko wrote: > > kmemdup_nul() strictly speaking is not related to the string API, > > while being quite useful for it. Rephrase documentation to make it > > clear that input data can be anything (any data, which may contain > > any bytes, including 0x00). > > That's not a useful thing to do, though. This rephrasing you've > done is more confusing than the original. Okay, then drop it. Sorry for the noise. -- With Best Regards, Andy Shevchenko