From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A41A6C636CD for ; Fri, 16 Jul 2021 20:23:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 37B3E61400 for ; Fri, 16 Jul 2021 20:23:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37B3E61400 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9FEE58D00F4; Fri, 16 Jul 2021 16:23:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AF018D00EC; Fri, 16 Jul 2021 16:23:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 828748D00F4; Fri, 16 Jul 2021 16:23:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id 588D58D00EC for ; Fri, 16 Jul 2021 16:23:06 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0BAEC2A026 for ; Fri, 16 Jul 2021 20:23:05 +0000 (UTC) X-FDA: 78369575130.25.A9D698E Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf15.hostedemail.com (Postfix) with ESMTP id BC939D0000B1 for ; Fri, 16 Jul 2021 20:23:04 +0000 (UTC) Received: by mail-pg1-f180.google.com with SMTP id k20so11058604pgg.7 for ; Fri, 16 Jul 2021 13:23:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=x85rFiYKbp37maDQJOeVsTrROe6NzpgrCb0rCmLZT5M=; b=A3iaz5afAQGHEMb5dAx2xN1+E/Jkl1exglVeIMNRgB04QPj2THSJNWjFHH4urOC4dj azzuyrfh/0lup7t52U45wwGHGx8zncavC+7HwrEL3oJwy/PeRI46jUEK0qujvYADefKM ArovxtIPS/UAgoxpNVVFKG1HXyvqmh/SOMk3r2oZmO0lj0BNXSOSYxiq86oLWGpzEqzx KFUbSDnqnzAODG1aEbYMh+kDC3D+M6SXrMy0/MM0ejw2dka6jMwj5/ZiAjC+QAPQ0dBB tZ2XeFnfbp2L4X1kFk+q9un5p8BAkl8dwzio2EB2PCFjXW8QMJqBrsIbUOddU2P4I+C3 O5Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=x85rFiYKbp37maDQJOeVsTrROe6NzpgrCb0rCmLZT5M=; b=UnOgbZe5AxIGMbV9TwT42P+PzxR0A/eiZvmz3ApRESQ0o0a1DL6AdEiuOTc7ZAWbeG hZA/6mMq27Jk1aBG1qat0HjhiKKps9DWMDGtD4YD8U79koxSL8MwE2fMVW0F0BIJ1RDt EFez8mcovZovU27dn/MXtdX5etIEQbrS7s5OUBFETJT2VGUwn8xV+oU/btY1fmnzOmNM +My9uydpILMjpTfN3lE1enwdcJeTiBIToRlfRwVX9zemP9WUBH/bfCaq++PskyMAhZ5q ZJDG+pAcu/3XE3m/iH252WeDYWa76Z8/lpPy3MaydE63zEhlpzcOXeOSHgrGt3EhidsB EBmg== X-Gm-Message-State: AOAM533ve6Yk0oeJwFlhiq3yqmempUs1sMFsNbkOam+lnsDllAPr6dqB 5aifbUka2gjdCAJh+2Jj9X/GdA== X-Google-Smtp-Source: ABdhPJxWNEVP2UwoOT65EqEX3Q4hJT3FKuvSXbD5nsfxrItaCDkJFf10AIQZc6tNG7uEGWx3oLscpg== X-Received: by 2002:a63:1e59:: with SMTP id p25mr11432905pgm.110.1626466983659; Fri, 16 Jul 2021 13:23:03 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id o134sm11534516pfg.62.2021.07.16.13.23.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jul 2021 13:23:03 -0700 (PDT) Date: Fri, 16 Jul 2021 20:22:59 +0000 From: Sean Christopherson To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Borislav Petkov , Michael Roth , Vlastimil Babka , tony.luck@intel.com, npmccallum@redhat.com, brijesh.ksingh@gmail.com Subject: Re: [PATCH Part2 RFC v4 30/40] KVM: X86: Define new RMP check related #NPF error bits Message-ID: References: <20210707183616.5620-1-brijesh.singh@amd.com> <20210707183616.5620-31-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210707183616.5620-31-brijesh.singh@amd.com> Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=A3iaz5af; spf=pass (imf15.hostedemail.com: domain of seanjc@google.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=seanjc@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: BC939D0000B1 X-Stat-Signature: 9bbsksx67o56bixbqdr5ffcj4h7bfdmu X-HE-Tag: 1626466984-312780 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Nit, please use "KVM: x86:" for the shortlogs. And ubernit, the "new" part is redundant and/or misleading, e.g. implies that more error code bits are being added to existing SNP/RMP checks. E.g. KVM: x86: Define RMP page fault error code bits for #NPT On Wed, Jul 07, 2021, Brijesh Singh wrote: > When SEV-SNP is enabled globally, the hardware places restrictions on all > memory accesses based on the RMP entry, whether the hyperviso or a VM, Another typo. > performs the accesses. When hardware encounters an RMP access violation > during a guest access, it will cause a #VMEXIT(NPF).