From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 022DAC636CD for ; Fri, 16 Jul 2021 19:33:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AFF07613FB for ; Fri, 16 Jul 2021 19:33:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFF07613FB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 205DF8D00F4; Fri, 16 Jul 2021 15:33:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18D168D00EC; Fri, 16 Jul 2021 15:33:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 006B58D00F4; Fri, 16 Jul 2021 15:33:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id D16838D00EC for ; Fri, 16 Jul 2021 15:33:38 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 13E742B37C for ; Fri, 16 Jul 2021 19:33:37 +0000 (UTC) X-FDA: 78369450474.22.DD38AEC Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf02.hostedemail.com (Postfix) with ESMTP id C2B257001A08 for ; Fri, 16 Jul 2021 19:33:36 +0000 (UTC) Received: by mail-pf1-f178.google.com with SMTP id j9so9756895pfc.5 for ; Fri, 16 Jul 2021 12:33:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bTfimW7x83FCVFcfi2WAn0Cbjb2ZgRjY254vPotYxPM=; b=gLImRTTcl99pctFwFn9UCqCov03WvN5lkMsW6nWwr384I/+cmwj+1ZHSGlrrZdl7d5 TLN+/m5Nfv5qKcE2GQunEOLzJB7L3PP6ZDyVbn6JNFdvHjmFxu78glmP3iIRHsw9wr+a H824qnog8pZlEDCRCTJ6HOP2L3o2UP8efLhLfBaXUcKxAoDb5znXSQWleWyBbWLEJj9B jvBCxQWNgzkeVM92UjyzQFGU1mQBnWXpAZcxh7SQ0MCcRlHittiWeZLW69P6RW1mT8FQ u3D6YbSXZKiUPT2FPaQRh65zBcahuVR55fkNhWuKOqwKOyjpx+kmRB+UTrj4/4D9JKvI s10w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bTfimW7x83FCVFcfi2WAn0Cbjb2ZgRjY254vPotYxPM=; b=ZrtfTDjA3ljlkYXbR7zG7noYaX+3bI66OImuh+3A3Qf/KY47tDKmw9q29wauUjD4TD JEzjoxgBywYcYoxttUJz1CMsV+dkDbsIVoID2WdRdklvosniVmDKLBRz7SFLfwKUYCYz kRLIP3X7bDJUGsDq1VxAdTEMTzvNeAapoKijLFPP032thuWfcSUFYTsc4+8pxz29iYfE rscKEesoUFq/WLV8yNE6wEDguaboBvpPbtEPaJHPZgFudjPBpM63h18d8UITSJLg7zo1 kCUeF0+b1wfgZZKcKf34LsRoVQvNd2V74SrE2YhH39JkqxEcit+tewPLhMtlwWj3N3tN OBSQ== X-Gm-Message-State: AOAM531wdPSvMILbjdIAEAvHJ8QBgR5yF4DIL4hy1cKk4YRRAiZELlZ/ S8gwqdESDCFv2DioFLfgBhHamA== X-Google-Smtp-Source: ABdhPJzOniqffULuzP8aWisOtiLK+NTXPgX8ACLtySTB0tER8yPBpCPFaT3MWTs6mE953cLz2x0NBQ== X-Received: by 2002:a63:f901:: with SMTP id h1mr11601639pgi.69.1626464015722; Fri, 16 Jul 2021 12:33:35 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id c10sm10695587pfo.129.2021.07.16.12.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jul 2021 12:33:35 -0700 (PDT) Date: Fri, 16 Jul 2021 19:33:31 +0000 From: Sean Christopherson To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Borislav Petkov , Michael Roth , Vlastimil Babka , tony.luck@intel.com, npmccallum@redhat.com, brijesh.ksingh@gmail.com Subject: Re: [PATCH Part2 RFC v4 22/40] KVM: SVM: Add KVM_SNP_INIT command Message-ID: References: <20210707183616.5620-1-brijesh.singh@amd.com> <20210707183616.5620-23-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210707183616.5620-23-brijesh.singh@amd.com> Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=gLImRTTc; spf=pass (imf02.hostedemail.com: domain of seanjc@google.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=seanjc@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C2B257001A08 X-Stat-Signature: u6mo1j33ok9z89apdsd4jjemzfpjdqs5 X-HE-Tag: 1626464016-339365 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 07, 2021, Brijesh Singh wrote: > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index 3fd9a7e9d90c..989a64aa1ae5 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -1678,6 +1678,9 @@ enum sev_cmd_id { > /* Guest Migration Extension */ > KVM_SEV_SEND_CANCEL, > > + /* SNP specific commands */ > + KVM_SEV_SNP_INIT = 256, Is there any meaning behind '256'? If not, why skip a big chunk? I wouldn't be concerned if it weren't for KVM_SEV_NR_MAX, whose existence arguably implies that 0-KVM_SEV_NR_MAX-1 are all valid SEV commands. > + > KVM_SEV_NR_MAX, > };