From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A459FC636CB for ; Thu, 15 Jul 2021 18:53:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 465F9613CC for ; Thu, 15 Jul 2021 18:53:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 465F9613CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9AD4E8D00F4; Thu, 15 Jul 2021 14:53:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95D258D00EC; Thu, 15 Jul 2021 14:53:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D68E8D00F4; Thu, 15 Jul 2021 14:53:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0146.hostedemail.com [216.40.44.146]) by kanga.kvack.org (Postfix) with ESMTP id 5B2778D00EC for ; Thu, 15 Jul 2021 14:53:10 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 379BD25F30 for ; Thu, 15 Jul 2021 18:53:09 +0000 (UTC) X-FDA: 78365719698.04.C1256D9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id D4A1D192C for ; Thu, 15 Jul 2021 18:53:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626375188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Yg+McKtY+ffqfI/EBeh9njvAeqTf7g8vxO6g9PiL1aI=; b=LMYjCpP1VvV+HFCUEurW9AAOLcrzBmPhtN2vbZfbQeHS99G+NkbvhYIDMc06tzfeTU/CSq 8o2UCq8vArhWxlWjZlSgb0WmcXPT7LeCgRrqrTSZSafWFaduq12Xw9BhWVgeLG0onvlg2Q 9wm12w6O4cKlAuzXLRqK/X187piwJb0= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-eNVzGe6gO_CxRtp-bwO4WA-1; Thu, 15 Jul 2021 14:53:07 -0400 X-MC-Unique: eNVzGe6gO_CxRtp-bwO4WA-1 Received: by mail-qk1-f198.google.com with SMTP id b6-20020a05620a1186b02903b429a7ee4bso4533405qkk.4 for ; Thu, 15 Jul 2021 11:53:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Yg+McKtY+ffqfI/EBeh9njvAeqTf7g8vxO6g9PiL1aI=; b=sLQ8XODQLCwAJSDHO+2hsTfHqbNbvZXDeXiAMGWJcp7j6ZTm+yK/tc9nPGeR5ZD3CZ 2Y44+UUYZ0nqAwGof4tCke16Iahfkm9pHSuxHpFcaNq1X+ruhY914+LLvdwgrTQb3ySB F5flSw8sDINZGdj3rS+70jNNKIb5SS7RvTEfJ49CmiCfB6fVA+RYTWJWfEosinynL8mP i8YOWiI7PIHkbM17HZM/OtWAg3Nlv/mn8hvtVGncQhPnw4dJQtkhii+J412q0hQEZ7Us oGWHhqSCBdeN0UfNiA5KXO9TayuI6m5adcfcS79RuywFcUh8gwEh3qtlKIZJ+0UcViHS qJDw== X-Gm-Message-State: AOAM531wy5hXIu95R/Gc5ML9OKzxx0rJ+SXN/Q+HihhpgjAPMucSgPPn ZkfaPk3JeZub2xSOid6qRu7XHHiiCre3r4xO9OE3nsfUq8lYrpyy8ZxVxpObpmtEt66iJiIMaMd 0N64BUbSMILU= X-Received: by 2002:a37:d52:: with SMTP id 79mr5514258qkn.227.1626375186745; Thu, 15 Jul 2021 11:53:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFn/kyYeNabdBvl7tuz6UF6JuSS6vuXIR6kxmTX6+CQPqQIBUCrdxm4EVuDL2y71/qvenx1g== X-Received: by 2002:a37:d52:: with SMTP id 79mr5514242qkn.227.1626375186571; Thu, 15 Jul 2021 11:53:06 -0700 (PDT) Received: from t490s (bras-base-toroon474qw-grc-65-184-144-111-238.dsl.bell.ca. [184.144.111.238]) by smtp.gmail.com with ESMTPSA id d11sm2312768qtx.37.2021.07.15.11.53.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jul 2021 11:53:06 -0700 (PDT) Date: Thu, 15 Jul 2021 14:53:04 -0400 From: Peter Xu To: kernel test robot Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kbuild-all@lists.01.org, Andrew Morton , Mike Kravetz , Axel Rasmussen , Miaohe Lin , "Kirill A . Shutemov" , Hugh Dickins , Jason Gunthorpe Subject: Re: [RFC PATCH] mm/hugetlb: __unmap_hugepage_range() can be static Message-ID: References: <20210714222450.48840-1-peterx@redhat.com> <20210715170524.GA48547@78ef4ef0cd6c> MIME-Version: 1.0 In-Reply-To: <20210715170524.GA48547@78ef4ef0cd6c> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LMYjCpP1; spf=none (imf22.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam05 X-Stat-Signature: k4gpn77x7ae9xke8kqkpnrhw9izkii6p X-Rspamd-Queue-Id: D4A1D192C X-HE-Tag: 1626375188-927080 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 16, 2021 at 01:05:24AM +0800, kernel test robot wrote: > mm/hugetlb.c:4334:6: warning: symbol '__unmap_hugepage_range' was not declared. Should it be static? > > Reported-by: kernel test robot > Signed-off-by: kernel test robot > --- > hugetlb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 924553aa8f789ad..4bdd637b0c29a95 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -4331,9 +4331,9 @@ int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src, > return ret; > } > > -void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma, > - unsigned long start, unsigned long end, > - struct page *ref_page) > +static void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma, > + unsigned long start, unsigned long end, > + struct page *ref_page) > { > struct mm_struct *mm = vma->vm_mm; > unsigned long address; Will squash this change into the patch. Thanks. -- Peter Xu