From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FDEDC636C8 for ; Thu, 15 Jul 2021 18:50:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2EA24613F0 for ; Thu, 15 Jul 2021 18:50:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EA24613F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 766BE8D00F4; Thu, 15 Jul 2021 14:50:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7180D8D00EC; Thu, 15 Jul 2021 14:50:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 590838D00F4; Thu, 15 Jul 2021 14:50:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id 3565B8D00EC for ; Thu, 15 Jul 2021 14:50:51 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id F3A661F05C for ; Thu, 15 Jul 2021 18:50:49 +0000 (UTC) X-FDA: 78365713860.14.A3990D5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 8337F700009D for ; Thu, 15 Jul 2021 18:50:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626375048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ajo5pEoABKRkdq+bnCfkdDE2HRwtDgm2wvZbZ9VLVZ8=; b=ZDv9WzbjKNhiGSys6NmSXl7YdYP8YRZ7xR86DuC9SRjuN/vdmuA6uGBJQNlpEyaTERdLi/ +PorvubT7fLjo+2VfeG0zoYUyGyjfPxhiXyeoFyoHFKYXMHGy9bvLKVrHJ8suBqXL0KqQ+ EKLZmda5ikcjwlehqqaIUmDNIASLbpY= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-161-EUJUZQpbNpWeCGs3JkBVhA-1; Thu, 15 Jul 2021 14:50:35 -0400 X-MC-Unique: EUJUZQpbNpWeCGs3JkBVhA-1 Received: by mail-qk1-f197.google.com with SMTP id b6-20020a05620a1186b02903b429a7ee4bso4528939qkk.4 for ; Thu, 15 Jul 2021 11:50:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ajo5pEoABKRkdq+bnCfkdDE2HRwtDgm2wvZbZ9VLVZ8=; b=oRuGCEkFN6++UjYS//1eoLRK6PEiObm9uzmOCg4djlQ297o2eqeQrqifHi3h3bDXTz WQcXLm5t0Of8VABRoSc8MQaiw6MooA3C5VGXYVsS6Km7tiNHkx+wYhxW56/2eYSS8T0P kMhPxvDvDo6ZboCLd0OPU9bzl9ShyFPlUdG0ngHLUxegk84xG9BjSGORBwd4zcqbxMtY J4SxIFmX9bMALcW/uWMks5K5tLtiaNwKTqfpzv3KW3UKzk5BjwqiufocFQ9NQaDv45D2 kD9y2riJ3bXplLTDmGQvefg5xqsudg88f+om+4TqKv/lElcYSVGdZrpdiQA7MzIEQzSm Gf6Q== X-Gm-Message-State: AOAM5307kfg3Z0O5CgqloFtavM9PlsfHeAvtYvI5FGtyMJuJ+2TO8xzn XJBQqdIwq0derQPEgfpCEC0LccGDBEGHBq1sI2PYz2YihMh+AdO1KERp/I0znF6Uptndm4dNDnl pmrdlFf0B6ps= X-Received: by 2002:a37:6516:: with SMTP id z22mr5535725qkb.203.1626375035101; Thu, 15 Jul 2021 11:50:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzaJBbwU0SqGt6eHeIVQYvxpX46Wf+EuOQUC/AtpPiJpD1RZFiUPvltMICDKtggPapZlPUikQ== X-Received: by 2002:a37:6516:: with SMTP id z22mr5535708qkb.203.1626375034888; Thu, 15 Jul 2021 11:50:34 -0700 (PDT) Received: from t490s (bras-base-toroon474qw-grc-65-184-144-111-238.dsl.bell.ca. [184.144.111.238]) by smtp.gmail.com with ESMTPSA id o10sm2281394qtv.62.2021.07.15.11.50.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jul 2021 11:50:34 -0700 (PDT) Date: Thu, 15 Jul 2021 14:50:33 -0400 From: Peter Xu To: kernel test robot Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, clang-built-linux@googlegroups.com, kbuild-all@lists.01.org, Jason Gunthorpe , Matthew Wilcox , Andrew Morton , Axel Rasmussen , Nadav Amit , Jerome Glisse Subject: Re: [PATCH v4 06/26] shmem/userfaultfd: Handle uffd-wp special pte in page fault handler Message-ID: References: <20210714222117.47648-7-peterx@redhat.com> <202107151452.ClaDCF2a-lkp@intel.com> MIME-Version: 1.0 In-Reply-To: <202107151452.ClaDCF2a-lkp@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZDv9Wzbj; spf=none (imf27.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: ee4st4t5sd44ee8aepbheu668iz7wcir X-Rspamd-Queue-Id: 8337F700009D X-Rspamd-Server: rspam01 X-HE-Tag: 1626375049-215336 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 15, 2021 at 02:20:21PM +0800, kernel test robot wrote: > Hi Peter, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v5.14-rc1 next-20210714] > [cannot apply to hnaz-linux-mm/master asm-generic/master linux/master] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Peter-Xu/userfaultfd-wp-Support-shmem-and-hugetlbfs/20210715-062718 > base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 8096acd7442e613fad0354fc8dfdb2003cceea0b > config: x86_64-randconfig-r021-20210714 (attached as .config) > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 0e49c54a8cbd3e779e5526a5888c683c01cc3c50) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install x86_64 cross compiling tool for clang build > # apt-get install binutils-x86-64-linux-gnu > # https://github.com/0day-ci/linux/commit/8b3e70f40b8333a803e642ed5c8cce738985881c > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Peter-Xu/userfaultfd-wp-Support-shmem-and-hugetlbfs/20210715-062718 > git checkout 8b3e70f40b8333a803e642ed5c8cce738985881c > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > >> mm/memory.c:4167:6: error: implicit declaration of function 'uffd_disable_fault_around' [-Werror,-Wimplicit-function-declaration] > if (uffd_disable_fault_around(vmf->vma)) > ^ > 1 error generated. > > > vim +/uffd_disable_fault_around +4167 mm/memory.c > > 4159 > 4160 /* Return true if we should do read fault-around, false otherwise */ > 4161 static inline bool should_fault_around(struct vm_fault *vmf) > 4162 { > 4163 /* No ->map_pages? No way to fault around... */ > 4164 if (!vmf->vma->vm_ops->map_pages) > 4165 return false; > 4166 > > 4167 if (uffd_disable_fault_around(vmf->vma)) > 4168 return false; > 4169 > 4170 return fault_around_bytes >> PAGE_SHIFT > 1; > 4171 } > 4172 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Will squash this into the patch: ---8<--- diff --git a/include/linux/userfaultfd_k.h b/include/linux/userfaultfd_k.h index c4228acd1d80..4382240de7c3 100644 --- a/include/linux/userfaultfd_k.h +++ b/include/linux/userfaultfd_k.h @@ -283,6 +283,11 @@ static inline bool pte_swp_uffd_wp_special(pte_t pte) return false; } +static inline bool uffd_disable_fault_around(struct vm_area_struct *vma) +{ + return false; +} + #endif /* CONFIG_USERFAULTFD */ #endif /* _LINUX_USERFAULTFD_K_H */ ---8<--- Thanks, -- Peter Xu