From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D949C636CA for ; Thu, 15 Jul 2021 18:18:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2A7A9613D2 for ; Thu, 15 Jul 2021 18:18:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A7A9613D2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3729A8D00F4; Thu, 15 Jul 2021 14:18:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FBEE8D00EC; Thu, 15 Jul 2021 14:18:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1760B8D00F4; Thu, 15 Jul 2021 14:18:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0168.hostedemail.com [216.40.44.168]) by kanga.kvack.org (Postfix) with ESMTP id E3C748D00EC for ; Thu, 15 Jul 2021 14:18:16 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C49AC824556B for ; Thu, 15 Jul 2021 18:18:15 +0000 (UTC) X-FDA: 78365631750.20.35FD611 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id 1108C30000B8 for ; Thu, 15 Jul 2021 18:18:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TGVdwq/5bAU2MHG7qmOxbHi3C9igc19rOJuXMsOJcdg=; b=ZOXi3u00QNMyZFzIOik4S8eyrr hey+iuVVOQ3TY5AJojjy8eAASosdliZN0vD8Dxo2+KJjDf8BB8uf8+XJjW48NIko8Ghi3vuQPoWC1 ZDP0GmBmmcTdLxM0hGJj2x+6g7JIdmKlYZGdH2v0pgAXXrJcwIiUsXjxaMZ9q6q6mBeIW4lddwqEo MCx190oCzVzlNPSEkHPWJxxW3Mgw1yLxzBp1ucX0HHSzuZbp0nC32NivSCWSO5kzXIGYWERFETtaG 0yp/iir1czmatqe7xRKGR3HmQs33Ya9oJeyJSMYFSflCApj+/aZy+MSxg1Fjvr7nM9aW1P7sVy6jN XqM/vt/g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m45vA-003cG7-3y; Thu, 15 Jul 2021 18:17:22 +0000 Date: Thu, 15 Jul 2021 19:17:16 +0100 From: Matthew Wilcox To: Zhansaya Bagdauletkyzy Cc: akpm@linux-foundation.org, tyhicks@linux.microsoft.com, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm: KSM: fix ksm_run data type Message-ID: References: <343394260f599d940cacc37f1dcc0309239ae220.1626371112.git.zhansayabagdaulet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <343394260f599d940cacc37f1dcc0309239ae220.1626371112.git.zhansayabagdaulet@gmail.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1108C30000B8 X-Stat-Signature: pufh7thiiw491pgauxfy3pkcco5jyqz6 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZOXi3u00; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1626373094-316613 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 16, 2021 at 12:01:01AM +0600, Zhansaya Bagdauletkyzy wrote: > +++ b/mm/ksm.c > @@ -289,7 +289,7 @@ static int ksm_nr_node_ids = 1; > #define KSM_RUN_MERGE 1 > #define KSM_RUN_UNMERGE 2 > #define KSM_RUN_OFFLINE 4 > -static unsigned long ksm_run = KSM_RUN_STOP; > +static unsigned int ksm_run = KSM_RUN_STOP; Should this be an enum instead?