From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FSL_HELO_FAKE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5F3FC4338F for ; Mon, 26 Jul 2021 17:53:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5641560F6B for ; Mon, 26 Jul 2021 17:53:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5641560F6B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 4352D8D0002; Mon, 26 Jul 2021 13:53:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E6688D0001; Mon, 26 Jul 2021 13:53:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D4578D0002; Mon, 26 Jul 2021 13:53:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0112.hostedemail.com [216.40.44.112]) by kanga.kvack.org (Postfix) with ESMTP id 13CCC8D0001 for ; Mon, 26 Jul 2021 13:53:57 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B4C7E22C00 for ; Mon, 26 Jul 2021 17:53:56 +0000 (UTC) X-FDA: 78405487272.05.B17C16B Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf20.hostedemail.com (Postfix) with ESMTP id 62DD4D001393 for ; Mon, 26 Jul 2021 17:53:56 +0000 (UTC) Received: by mail-pl1-f179.google.com with SMTP id c11so12531185plg.11 for ; Mon, 26 Jul 2021 10:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=h551Z0GDw+QKnY0IISUO3Eg8hP3kvvDKHptPjd9LN9I=; b=fWhWiXsyr1VpmQTI5/0t3NGN3Wqziwotm+OJGybva+1IJlvdAORtRhAS8U9i1y7R2e zFc1fXA40hh2jlNTEEDVz1yPvPFLqzQ8fTRy9XUj2m5n5q0NrmReeN0EvwQupif6gDV/ tfVQxz6+AOKHHjtfKiAnVNHaSdBM41ZbC4p69u92ocBTXO8FJUdLpMKKRTib0iwmyOyT RHuPdRMLDEymk4n+KRwraTUlz3r1+N9FZlGLqh/gSs3Pa0s+nLi6hUddoExNoS6/qqKU hOygVU4rO1b+2l9sD1EvGhD6As4JIZOJXJ0HVg5PWJqQdRZC0D8/o3h6o99dFdh211W9 mhnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=h551Z0GDw+QKnY0IISUO3Eg8hP3kvvDKHptPjd9LN9I=; b=QdkzUrI5Qi12fqsgqvE42TJH3nUImaW6pGa8ozQPpEwI4amwm+wgFGKSH9pEbNry3d /q4WxrzulvuuWedaZmIyiPyLcWPHRStHbCrx8X3kVno+K3A6DNqzlMLGZdgs5u0x0PoD ozCe4yGwFw3xX7BNgue+rJyIjgpCMOdv56l7hVpdFm1k6/PY8jqRB+nqbI+9i2JywUAP nOlcGqzLO+zoOfoo+A6/SD25BsJgpB+QB/MT1iokTwuIuRw0XrNSwgJWvyOHyiw/UbK/ ecR8Z8+BOEeKU/9ORre4v+cVAi0YP7O8Lq+WBc9EaMOLARS35xJvcXFc5ZLXvBKd/1IS vhFQ== X-Gm-Message-State: AOAM531ZP6KOKMbPYKm9OTZfjoep90Nmrr/ek7lhg4+xIjRMLqePH9GA pJu8ck8h5Mo8uMUWL4lzMUI= X-Google-Smtp-Source: ABdhPJxdxAcP5SZ0Ov7TOLPHf8HHaLlrWJrUaiOjGjeXkIKgvSAwVUPHFPsXj+6s1wAQPQs29gpMKQ== X-Received: by 2002:a17:90a:5d8a:: with SMTP id t10mr206536pji.6.1627322035352; Mon, 26 Jul 2021 10:53:55 -0700 (PDT) Received: from google.com ([2620:15c:211:201:7dec:c98b:4b9:d5b9]) by smtp.gmail.com with ESMTPSA id gg10sm142884pjb.20.2021.07.26.10.53.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 10:53:54 -0700 (PDT) Date: Mon, 26 Jul 2021 10:53:52 -0700 From: Minchan Kim To: Sergey Senozhatsky Cc: Huangzhaoyang , Zhaoyang Huang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Nitin Gupta Subject: Re: [PATCH] driver: zram: fix wrong counting on pages_store Message-ID: References: <1626763658-27748-1-git-send-email-huangzhaoyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=fWhWiXsy; spf=pass (imf20.hostedemail.com: domain of minchankim@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=minchankim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 62DD4D001393 X-Stat-Signature: 7gr4w494kf7awyonb74j9k5qg5uqpj96 X-HE-Tag: 1627322036-910277 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 26, 2021 at 10:27:40AM +0900, Sergey Senozhatsky wrote: > On (21/07/20 14:47), Huangzhaoyang wrote: > > It makes the statistic confused when counting pages_store in during writeback. > > pages_store should just reflect the swapped pages on ZRAM, while bd_writes be > > responsible for writeback things. > > > > Signed-off-by: Zhaoyang Huang > > --- > > drivers/block/zram/zram_drv.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > > index cf8deec..6bdaa9d 100644 > > --- a/drivers/block/zram/zram_drv.c > > +++ b/drivers/block/zram/zram_drv.c > > @@ -765,7 +765,6 @@ static ssize_t writeback_store(struct device *dev, > > zram_set_flag(zram, index, ZRAM_WB); > > zram_set_element(zram, index, blk_idx); > > blk_idx = 0; > > - atomic64_inc(&zram->stats.pages_stored); > > Yeah, I think we don't need it here. > > Minchan, what do you think? What pages_stored currently represents is orig_data_size from mm_stat ================ ============================================================= orig_data_size uncompressed size of data stored in this disk. Unit: bytes Thus, if we don't increase it after zram_free_page, it loses what's the original data size which would be important to calculate compression ratio along with compr_data_size.