From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38598C4338F for ; Mon, 26 Jul 2021 01:27:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8FA1060249 for ; Mon, 26 Jul 2021 01:27:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8FA1060249 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 110736B0033; Sun, 25 Jul 2021 21:27:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09A576B005D; Sun, 25 Jul 2021 21:27:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA3E68D0001; Sun, 25 Jul 2021 21:27:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id CC5236B0033 for ; Sun, 25 Jul 2021 21:27:47 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 834B620BFD for ; Mon, 26 Jul 2021 01:27:47 +0000 (UTC) X-FDA: 78403002174.13.BBE0BB6 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf27.hostedemail.com (Postfix) with ESMTP id 39DC870468E4 for ; Mon, 26 Jul 2021 01:27:47 +0000 (UTC) Received: by mail-pj1-f53.google.com with SMTP id mt6so10778193pjb.1 for ; Sun, 25 Jul 2021 18:27:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4nvyo5pUPccLHA9vRdzeaMvZAx6+cAUa7rg3pe0FbOM=; b=KWKbbQRoPzAW2Yb+wO0MXH1a6k6com/5pz3aFoxYvZorMVuI2GU1qg1Ha/HeLo5fdY Dwsg7ehyW0zHR/Nuob8V6XRpksVN6e4DSPGQa3UPUwEzOpW5MspHCGnj5MAz+0ivPV3G qKu/VjQAy8Xb1J9ULkQ4/8j0x6KIDi5PDwRnY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4nvyo5pUPccLHA9vRdzeaMvZAx6+cAUa7rg3pe0FbOM=; b=c7wtnbI7d86T0c9oD1sG1vLS2tCYQ8FHkJK2bQph/QNaLj2Bey8DlkgWi+iUupmSnj vCJo4GFvdLPiXoiRhHpDqYYvU7sT+Yohl9ZCmvU6wB1vDz3DKarjrKs0ULIVEYyZI3fg N01JWFnCiGfUt8tcurQA74U3Q7I1wRLZEM35vbbUjw0/5yh359NS5AZ5sepsj9zZ8uSD MWt8nMgY0AKGCRtSA4Jz26RK6d7SKunmtWTeahi1yNDc3cpSKRzpDXw//p6qp6Me0U5e AuFXKli5Maf2gimXU1Z2RwNlJ7FyjQIoqP/7R+k2lcDFTopRDyEUQGWB8zOWbXsc+r4p VfvA== X-Gm-Message-State: AOAM532KFdCvUVnxtmSQXpjyWo6z5AoAwIiazs3u6MJcO6rK4Z8JcnLZ R0vlyOAeWY5OUIhK7N8pLvHKKg== X-Google-Smtp-Source: ABdhPJxhomRbBRYLCoMmhBURponq8oqvv1C8uhTdHQ+vmUzKU/LwgEFLC2xeA62o5/t4s0IhMqZRuA== X-Received: by 2002:a65:4289:: with SMTP id j9mr15956235pgp.256.1627262865981; Sun, 25 Jul 2021 18:27:45 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:967a:60e8:38b7:1227]) by smtp.gmail.com with ESMTPSA id h19sm38890719pfo.161.2021.07.25.18.27.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jul 2021 18:27:45 -0700 (PDT) Date: Mon, 26 Jul 2021 10:27:40 +0900 From: Sergey Senozhatsky To: Minchan Kim , Huangzhaoyang Cc: Zhaoyang Huang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Nitin Gupta , Sergey Senozhatsky Subject: Re: [PATCH] driver: zram: fix wrong counting on pages_store Message-ID: References: <1626763658-27748-1-git-send-email-huangzhaoyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1626763658-27748-1-git-send-email-huangzhaoyang@gmail.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 39DC870468E4 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=KWKbbQRo; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf27.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.53 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org X-Stat-Signature: mszgdhcub7mrpe8e81zzk9t5fkajpud6 X-HE-Tag: 1627262867-422098 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (21/07/20 14:47), Huangzhaoyang wrote: > It makes the statistic confused when counting pages_store in during writeback. > pages_store should just reflect the swapped pages on ZRAM, while bd_writes be > responsible for writeback things. > > Signed-off-by: Zhaoyang Huang > --- > drivers/block/zram/zram_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > index cf8deec..6bdaa9d 100644 > --- a/drivers/block/zram/zram_drv.c > +++ b/drivers/block/zram/zram_drv.c > @@ -765,7 +765,6 @@ static ssize_t writeback_store(struct device *dev, > zram_set_flag(zram, index, ZRAM_WB); > zram_set_element(zram, index, blk_idx); > blk_idx = 0; > - atomic64_inc(&zram->stats.pages_stored); Yeah, I think we don't need it here. Minchan, what do you think?