From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63172C4338F for ; Tue, 27 Jul 2021 11:48:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 230B661A0D for ; Tue, 27 Jul 2021 11:48:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 230B661A0D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 39BD86B0036; Tue, 27 Jul 2021 07:48:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 34C528D0001; Tue, 27 Jul 2021 07:48:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 261406B006C; Tue, 27 Jul 2021 07:48:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0109.hostedemail.com [216.40.44.109]) by kanga.kvack.org (Postfix) with ESMTP id 0FE966B0036 for ; Tue, 27 Jul 2021 07:48:19 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9E6911EA18 for ; Tue, 27 Jul 2021 11:48:18 +0000 (UTC) X-FDA: 78408194676.07.6737FA6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 69F4F6015859 for ; Tue, 27 Jul 2021 11:48:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=amNN9ICmSy0CIVY3BfkjSZ+Y52dJCXLET8MjYMJxcRY=; b=IxH8llkwulKXXSh6OvycrTVgSK QZCBD45U22q3e4ZQBfB5GqMco8wIRURRoyN0H5TXp/+2ndJUUOpqwGHxTYM8mW6jcg3hee0KgRyHZ 59GXle0LFmt24/kM5MZriLCjau7tDrcHfb4HfC+9BdLUR27DCvd9C7Dy2rR8s3A5Ygp89RoxsYB15 gdGCuBLp1Gx/qKh61/rgDanAPZzb7sSSrakS+OaR9cvj9t4vlM4z06AbrKu+DDJDji8olnPwtPiYO 3M91tb2xFPoay8x5JxcM9vSFDaH6VLXxRPp9EUbK1QnB50S/4qdJKTt4dDYrIhAsp4gUfE87LRjgJ jy/vA5Cg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8LXf-00EyC9-6Q; Tue, 27 Jul 2021 11:46:50 +0000 Date: Tue, 27 Jul 2021 12:46:35 +0100 From: Matthew Wilcox To: Wang Qing Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: folio: use copy_highpage() instead of folio_migrate_copy() when copy once Message-ID: References: <1627356775-28742-1-git-send-email-wangqing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1627356775-28742-1-git-send-email-wangqing@vivo.com> Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=IxH8llkw; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam02 X-Stat-Signature: 6qpuz9mnmob6ypie1o7y7hyd94goziqy X-Rspamd-Queue-Id: 69F4F6015859 X-HE-Tag: 1627386496-390230 X-Bogosity: Ham, tests=bogofilter, spamicity=0.010055, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 27, 2021 at 11:32:54AM +0800, Wang Qing wrote: > folio_migrate_copy() will call cond_resched(), even if it only needs to be > copied once, restore the previous implementation before there is a better > solution: use copy_highpage() when copy once. no. i already fixed this on july 22. https://lore.kernel.org/linux-mm/YPmB60EwQPpEvdb%2F@casper.infradead.org/