From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C918C07E99 for ; Fri, 9 Jul 2021 14:49:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1F5B46135F for ; Fri, 9 Jul 2021 14:49:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F5B46135F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 182426B0074; Fri, 9 Jul 2021 10:49:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1324C6B0075; Fri, 9 Jul 2021 10:49:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEEDB8D0001; Fri, 9 Jul 2021 10:49:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0220.hostedemail.com [216.40.44.220]) by kanga.kvack.org (Postfix) with ESMTP id BB4456B0074 for ; Fri, 9 Jul 2021 10:49:48 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id ED12127767 for ; Fri, 9 Jul 2021 14:49:47 +0000 (UTC) X-FDA: 78343333614.33.EA89FFC Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) by imf29.hostedemail.com (Postfix) with ESMTP id 5F6D59000255 for ; Fri, 9 Jul 2021 14:49:47 +0000 (UTC) Received: by mail-qk1-f171.google.com with SMTP id s6so6668225qkc.8 for ; Fri, 09 Jul 2021 07:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=sl7zNgfOy4Ks0Fk6pkfy9FhpGYHd/QTs7j+H3rSlVoM=; b=QA6tQE9mCvmjOaTfcc2lhfJ7BmUP0CTjYUCkE42z/dXIUmI+XlkPMDOIo3wA9Ewd8i TJcT0Rjq4p0GKVFYWW4j9Z1BcCOpXN4vxlhh0bU60qcdL/HIkNQKC8c3XQYi+hCe6xVR 7LkNosRmU6md/syD7lrW9ODys7pLAhmCYjFS3RlKMHmbyHNwnwns2S+NrAp/9socbAT1 UV55cIljPhKM/izeG48aY0Wy97a79OseJ1N8UaBbkZTZ1fslg1hFWwkdoblX5UjI3Lc6 uzOf7aOyTsRBNkJWX+cX40JVq0JY0KnTTyyXoH1lR6JySxF1VylzyMoTh1CsWjQnkLg+ 1TJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sl7zNgfOy4Ks0Fk6pkfy9FhpGYHd/QTs7j+H3rSlVoM=; b=HiGl0jOXu4Xjxixdcslw5b6PCSjl8mkBNm+X5KdnGyBpskkQwTpESZoSX9O/QOqxWf kBOstGh5tyA/vR1vYrMTnJHyVaW4PJsSXz4+9snqTz1UdeHiInTKi3w6timinAHcqmL6 FTull/CWV5IWRE3K6UXZf0xsrdcZ35EkYhRcxDefoW/bJ0VY+g8Nwb3b41QSesjfK8hm RRnsfM3hYEf/Pftpz4/xZ+Ky8KoJt/JYpnkSQEN6BG1vZMYXDLdTVEifmyMMz5c8Jq1B sYihfKVj45SEOQU5+fOvn/KPmp4RIIoRsW7pA4cWbKVs9wImb2HqZIEghpIhDrOEPGBL 62Ag== X-Gm-Message-State: AOAM5301htsTlXCm7FiDyjbWqsutXgzrub7h+luer4uWM0ur7jGipJsN wvA6WMcLCSe1hA/Xx9Pf4G+oYg== X-Google-Smtp-Source: ABdhPJxVjlU9+Tbsjk5O64L0DrdYKOqi50sg11zdiPNqvEJpCOIPUhs2uVvO7S1pUh3kMex5WXyFrw== X-Received: by 2002:ae9:f44c:: with SMTP id z12mr15623147qkl.265.1625842186810; Fri, 09 Jul 2021 07:49:46 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:8649]) by smtp.gmail.com with ESMTPSA id x9sm2329117qtf.76.2021.07.09.07.49.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jul 2021 07:49:46 -0700 (PDT) Date: Fri, 9 Jul 2021 10:49:45 -0400 From: Johannes Weiner To: Suren Baghdasaryan Cc: tj@kernel.org, mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, shakeelb@google.com, guro@fb.com, songmuchun@bytedance.com, shy828301@gmail.com, alexs@kernel.org, alexander.h.duyck@linux.intel.com, richard.weiyang@gmail.com, vbabka@suse.cz, axboe@kernel.dk, iamjoonsoo.kim@lge.com, david@redhat.com, willy@infradead.org, apopple@nvidia.com, minchan@kernel.org, linmiaohe@huawei.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, kernel-team@android.com Subject: Re: [PATCH 3/3] mm, memcg: inline swap-related functions to improve disabled memcg config Message-ID: References: <20210709000509.2618345-1-surenb@google.com> <20210709000509.2618345-4-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210709000509.2618345-4-surenb@google.com> Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=QA6tQE9m; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf29.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.171 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5F6D59000255 X-Stat-Signature: pefgdnzcq31fm6s9mrp6h53icnykutio X-HE-Tag: 1625842187-816290 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 08, 2021 at 05:05:09PM -0700, Suren Baghdasaryan wrote: > Inline mem_cgroup_try_charge_swap, mem_cgroup_uncharge_swap and > cgroup_throttle_swaprate functions to perform mem_cgroup_disabled static > key check inline before calling the main body of the function. This > minimizes the memcg overhead in the pagefault and exit_mmap paths when > memcgs are disabled using cgroup_disable=memory command-line option. > This change results in ~1% overhead reduction when running PFT test > comparing {CONFIG_MEMCG=n} against {CONFIG_MEMCG=y, cgroup_disable=memory} > configuration on an 8-core ARM64 Android device. > > Signed-off-by: Suren Baghdasaryan Looks reasonable to me as well. Acked-by: Johannes Weiner