From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49BB4C07E96 for ; Thu, 8 Jul 2021 23:31:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D175D61445 for ; Thu, 8 Jul 2021 23:31:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D175D61445 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B5FC36B006C; Thu, 8 Jul 2021 19:31:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B10036B0070; Thu, 8 Jul 2021 19:31:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D7426B0071; Thu, 8 Jul 2021 19:31:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0095.hostedemail.com [216.40.44.95]) by kanga.kvack.org (Postfix) with ESMTP id 715AE6B006C for ; Thu, 8 Jul 2021 19:31:16 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id AA4F3253CE for ; Thu, 8 Jul 2021 23:31:15 +0000 (UTC) X-FDA: 78341018910.23.EDCD8A1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id E9CAF20019DD for ; Thu, 8 Jul 2021 23:31:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jra6eVCUb4QOC04fq6nucXKQ0jZAs8nzjUB1r1PZFhA=; b=QswHst436Z1sDOR32UFIIiumRx 7DhL+HW0K11GdlWrHerWGHPwqRGIGLrynZGbN7nmDLcUcDhueKvxitmI1u1NLdkgh4O+ItnFpJ2zZ q8sOq7r4chvz+TCb1+cvgCB732YbCMYHeMYzoRBcWk5VM+X5UGT6cJNBcvDsYwz3B1/U26tJEGvbe WIcZcfBjlqg8bKs2XR5JisH73eyFIQCB+VEonxLI9crtz9kevDHUcLR7xFNKieW3n3V/ccKwMQ2x1 sO97ejdSXZ+//XFeXEUdjb51317N1WrscvFUlZgKY3xIa5lvUkYEedcXwZejOtACbhFR+puMtGAso Ge6yaP1g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1dTu-00Dw5R-Kl; Thu, 08 Jul 2021 23:31:00 +0000 Date: Fri, 9 Jul 2021 00:30:58 +0100 From: Matthew Wilcox To: Chuck Lever Cc: linux-nfs@vger.kernel.org, linux-mm@kvack.org, neilb@suse.de Subject: Re: [PATCH v3 2/3] SUNRPC: Add svc_rqst_replace_page() API Message-ID: References: <162575623717.2532.8517369487503961860.stgit@klimt.1015granger.net> <162575798916.2532.6898942885852856593.stgit@klimt.1015granger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162575798916.2532.6898942885852856593.stgit@klimt.1015granger.net> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E9CAF20019DD Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QswHst43; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Stat-Signature: nngb591zqyca8sh164hwsaizy7nf3t6m X-HE-Tag: 1625787074-728017 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 08, 2021 at 11:26:29AM -0400, Chuck Lever wrote: > @@ -256,6 +256,9 @@ struct svc_rqst { > struct page * *rq_next_page; /* next reply page to use */ > struct page * *rq_page_end; /* one past the last page */ > > + struct page *rq_relpages[16]; > + int rq_numrelpages; This is only one struct page away from being a pagevec ... ? > @@ -838,6 +839,33 @@ svc_set_num_threads_sync(struct svc_serv *serv, struct svc_pool *pool, int nrser > } > EXPORT_SYMBOL_GPL(svc_set_num_threads_sync); > > +static void svc_rqst_release_replaced_pages(struct svc_rqst *rqstp) > +{ > + release_pages(rqstp->rq_relpages, rqstp->rq_numrelpages); > + rqstp->rq_numrelpages = 0; This would be pagevec_release()