From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B431DC07E95 for ; Wed, 7 Jul 2021 17:09:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 37E3961C7F for ; Wed, 7 Jul 2021 17:09:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37E3961C7F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D16FA6B0011; Wed, 7 Jul 2021 13:09:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC6EF6B005D; Wed, 7 Jul 2021 13:09:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B67576B006C; Wed, 7 Jul 2021 13:09:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id 8FBE86B0011 for ; Wed, 7 Jul 2021 13:09:01 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D6AD1267D1 for ; Wed, 7 Jul 2021 17:09:00 +0000 (UTC) X-FDA: 78336426840.15.339750F Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by imf29.hostedemail.com (Postfix) with ESMTP id 034F3900026A for ; Wed, 7 Jul 2021 17:08:53 +0000 (UTC) Received: by mail-qk1-f173.google.com with SMTP id 14so2734501qkh.0 for ; Wed, 07 Jul 2021 10:08:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zKFzxaicRuEWN6JDVuwxf/5fHNRnvOJNXCo8RqlfnUo=; b=K07Xb99QcriEOisR00l22wLQPQEOIpOXNJAf9NhgVco/oZ9jwUnQ0BR4m/V9l2aVu3 7Ue85P+ZxUFOf7SP+RuJxDYfEyBUPkLCBoJ2Tbjlh0beKAnJ/INjxQ6Fkx+jJqhYaVGT RjMT0XF4LKj/9H7bu0nqsgCsRncfO3IsCb6RKkdDyvHJKow5YHLgaVkGWPoyOig8rF7q u37fNGzarIMgfy9mJlnW7SqjOVYt3o9RJ+FxXglVlM5PGmawY/NT4yBDQxiPBNUMYhNM 7eUk/7LFiyrGoo6WBmJpGhK+MbzOdBSwOgaZRXJY+665Xnpq9Ws4ZIiUBCaYBAKXhqZ0 Bv+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zKFzxaicRuEWN6JDVuwxf/5fHNRnvOJNXCo8RqlfnUo=; b=gbPs1sKxQnkS2lL+w9sIx0IbM2FVeFjynUUk5n2j3i1ONwY3xVPF/UkZhABKlXc0sf ifn8/GZq4nlxzuu0iliVxDADNaH4IUL4M5l8QjmA+8Vks80XTWlYxhjYIflpxJNzSBsx I+Oyh9cOLS/rVQh8GqJ9i9i50lTpJ8uOj3rDfJmnUKglkNC4PLISxTcUp+WxHSPEhesF XLMNBIoYHW6wsqsoRTJrgw8NrFIWRTKeoXcxy3E0kDleDLbV2dfmJ69EJg1vZd4KnUS9 xoN4bbFd9kZwht1SC9deEbSvd9glQCTx0oHmWmKVmsO71DGqyUSpt4eLFSqZRYHdd6kY lZtA== X-Gm-Message-State: AOAM532avweOvHjatm0NQw542FeIt2PpYBLD+ep0CI1hzQGBV4YbjD9c LEZknRlrsRN9iiSSvDQj3zS1bA== X-Google-Smtp-Source: ABdhPJyvpaXGsh/M091lO5PbRxD+WGM/34+NjN7awp7C4IyKjHFJo9WpZyAbacwM83XKvBQQYw8UWA== X-Received: by 2002:ae9:e8cd:: with SMTP id a196mr23914727qkg.225.1625677733331; Wed, 07 Jul 2021 10:08:53 -0700 (PDT) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id g1sm8474122qkm.58.2021.07.07.10.08.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jul 2021 10:08:52 -0700 (PDT) Date: Wed, 7 Jul 2021 13:08:51 -0400 From: Johannes Weiner To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, Michal Hocko , Vladimir Davydov Subject: Re: [PATCH v3 13/18] mm/memcg: Add folio_memcg_lock() and folio_memcg_unlock() Message-ID: References: <20210630040034.1155892-1-willy@infradead.org> <20210630040034.1155892-14-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210630040034.1155892-14-willy@infradead.org> X-Rspam-User: nil Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=K07Xb99Q; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf29.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.173 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 034F3900026A X-Stat-Signature: z4cg7dqc66h6i5nycperbtn6son4b93q X-HE-Tag: 1625677733-487110 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 30, 2021 at 05:00:29AM +0100, Matthew Wilcox (Oracle) wrote: > -static void __unlock_page_memcg(struct mem_cgroup *memcg) > +static void __memcg_unlock(struct mem_cgroup *memcg) This is too generic a name. There are several locks in the memcg, and this one only locks the page->memcg bindings in the group.