From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6844C07E9B for ; Wed, 7 Jul 2021 12:38:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 47F4061CBA for ; Wed, 7 Jul 2021 12:38:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47F4061CBA Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ED3AA6B0036; Wed, 7 Jul 2021 08:38:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E836A6B005D; Wed, 7 Jul 2021 08:38:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFDAA6B006C; Wed, 7 Jul 2021 08:38:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0109.hostedemail.com [216.40.44.109]) by kanga.kvack.org (Postfix) with ESMTP id A529E6B0036 for ; Wed, 7 Jul 2021 08:38:44 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EE1478249980 for ; Wed, 7 Jul 2021 12:38:43 +0000 (UTC) X-FDA: 78335745726.18.EE52030 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf27.hostedemail.com (Postfix) with ESMTP id 73797700009D for ; Wed, 7 Jul 2021 12:38:43 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 240DA22420; Wed, 7 Jul 2021 12:38:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1625661522; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wtj4oqJE3RiN5VpO28h+0U6s0vV8LrwsND4LhinfUSo=; b=AGrjPda2dkldufEtWLLsXeP5nO0ItjRm+3IxvNNgLrIvm4nmzr8qB7Rs1jBYQAQmbtB2eB cNNHS8Ec+oK6JaWxToEy+d3SO1eChhxXobVV5PVdF0ZqT91UnOwuIs3Ejh11tiE0laYf/j Uh6xJXRuUCZVfC0fZKQIPwtjb00Ya0c= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 7E6BDA3C27; Wed, 7 Jul 2021 12:38:41 +0000 (UTC) Date: Wed, 7 Jul 2021 14:38:40 +0200 From: Michal Hocko To: David Hildenbrand Cc: Christian Brauner , Suren Baghdasaryan , Andy Lutomirski , Johannes Weiner , Andrew Morton , David Rientjes , Matthew Wilcox , Roman Gushchin , Rik van Riel , Minchan Kim , Christian Brauner , Christoph Hellwig , Oleg Nesterov , Jann Horn , Shakeel Butt , Tim Murray , Linux API , Linux-MM , LKML , Android Kernel Team Subject: Re: [PATCH 1/1] mm: introduce process_reap system call Message-ID: References: <20210623192822.3072029-1-surenb@google.com> <20210702152724.7fv5tnik4qlap6do@wittgenstein> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 73797700009D X-Stat-Signature: 4zxsi3czhn69aziui5okd53kr3hf5kac Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=AGrjPda2; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf27.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com X-HE-Tag: 1625661523-809659 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 05-07-21 09:41:54, David Hildenbrand wrote: > On 02.07.21 17:27, Christian Brauner wrote: [...] > > That one was my favorite from the list I gave too but maybe we can > > satisfy Andy too if we use one of: > > - process_mfree() > > - process_mrelease() > > > > FWIW, I tend to like process_mrelease(), due to the implied "release" ("free > the memory if there are no other references") semantics. Agreed. > Further, a new > syscall feels cleaner than some magic sysfs/procfs toggle. Just my 2 cents. Yeah, proc based interface is both tricky to use and kinda ugly now that pidfd can solve all at in once. My original preference was a more generic kill syscall to allow flags but a dedicated syscall doesn't look really bad either. -- Michal Hocko SUSE Labs