From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 357ACC07E9C for ; Wed, 7 Jul 2021 14:32:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B41E761CC1 for ; Wed, 7 Jul 2021 14:32:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B41E761CC1 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 69A976B0036; Wed, 7 Jul 2021 10:32:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 671EC6B005D; Wed, 7 Jul 2021 10:32:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 513A66B006C; Wed, 7 Jul 2021 10:32:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0079.hostedemail.com [216.40.44.79]) by kanga.kvack.org (Postfix) with ESMTP id 302646B0036 for ; Wed, 7 Jul 2021 10:32:09 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 798C51801BB8B for ; Wed, 7 Jul 2021 14:32:08 +0000 (UTC) X-FDA: 78336031536.06.0A5EAAD Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf20.hostedemail.com (Postfix) with ESMTP id E08D5D0000A0 for ; Wed, 7 Jul 2021 14:32:07 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 646362009B; Wed, 7 Jul 2021 14:32:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1625668326; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kuS5bmizMP3/HWTyoAHfOXtGA9iGXpLookw1mW0+L+g=; b=p4izdV5DJ23yq+Ht46GKB5gi+T+R/XCFqLaZqPr2G6yEOaeJBlk7tgfa+voRydbpM+Gczl 8cEzPNtL/k0fMydjvhD6rEoWVBn65HvLK8iv74nTuo7k8zU83KSeO+4kfDZO/aOlWk0uf0 CaSjbPvQs9WyhR0Vuwd67vCrFP2JcT4= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 2F1A0A3D78; Wed, 7 Jul 2021 14:32:05 +0000 (UTC) Date: Wed, 7 Jul 2021 16:32:05 +0200 From: Michal Hocko To: Ohhoon Kwon Cc: david@redhat.com, akpm@linux-foundation.org, bhe@redhat.com, rppt@linux.ibm.com, ohkwon1043@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: ***UNCHECKED*** [PATCH v3 1/1] mm: sparse: pass section_nr to section_mark_present Message-ID: References: <20210707131443.6242-1-ohoono.kwon@samsung.com> <20210707131443.6242-2-ohoono.kwon@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210707131443.6242-2-ohoono.kwon@samsung.com> Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=p4izdV5D; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf20.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com X-Stat-Signature: bqedzejqrkj49urpn4m99wwo5wenth49 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E08D5D0000A0 X-HE-Tag: 1625668327-447054 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 07-07-21 22:14:43, Ohhoon Kwon wrote: > With CONFIG_SPARSEMEM_EXTREME enabled, __section_nr() which converts > mem_section to section_nr could be costly since it iterates all > section roots to check if the given mem_section is in its range. > > Since both callers of section_mark_present already know section_nr, > let's also pass section_nr as well as mem_section in order to reduce > costly translation. > > Signed-off-by: Ohhoon Kwon > Acked-by: Mike Rapoport > Reviewed-by: David Hildenbrand I would simply fold that into the first patch but a separate patch is also OK. Acked-by: Michal Hocko Thanks > --- > mm/sparse.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/mm/sparse.c b/mm/sparse.c > index 6326cdf36c4f..8018ee7fcda5 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -187,10 +187,9 @@ void __meminit mminit_validate_memmodel_limits(unsigned long *start_pfn, > * those loops early. > */ > unsigned long __highest_present_section_nr; > -static void section_mark_present(struct mem_section *ms) > +static void __section_mark_present(struct mem_section *ms, > + unsigned long section_nr) > { > - unsigned long section_nr = __section_nr(ms); > - > if (section_nr > __highest_present_section_nr) > __highest_present_section_nr = section_nr; > > @@ -280,7 +279,7 @@ static void __init memory_present(int nid, unsigned long start, unsigned long en > if (!ms->section_mem_map) { > ms->section_mem_map = sparse_encode_early_nid(nid) | > SECTION_IS_ONLINE; > - section_mark_present(ms); > + __section_mark_present(ms, section); > } > } > } > @@ -934,7 +933,7 @@ int __meminit sparse_add_section(int nid, unsigned long start_pfn, > > ms = __nr_to_section(section_nr); > set_section_nid(section_nr, nid); > - section_mark_present(ms); > + __section_mark_present(ms, section_nr); > > /* Align memmap to section boundary in the subsection case */ > if (section_nr_to_pfn(section_nr) != start_pfn) > -- > 2.17.1 -- Michal Hocko SUSE Labs