From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 546A4C07E9C for ; Wed, 7 Jul 2021 08:51:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EFB3361CC0 for ; Wed, 7 Jul 2021 08:51:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFB3361CC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BBE046B005D; Wed, 7 Jul 2021 04:51:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B94606B006C; Wed, 7 Jul 2021 04:51:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5D176B0070; Wed, 7 Jul 2021 04:51:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0224.hostedemail.com [216.40.44.224]) by kanga.kvack.org (Postfix) with ESMTP id 83D986B005D for ; Wed, 7 Jul 2021 04:51:25 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D85308249980 for ; Wed, 7 Jul 2021 08:51:24 +0000 (UTC) X-FDA: 78335172888.25.0D136AC Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf13.hostedemail.com (Postfix) with ESMTP id 6E0661002B04 for ; Wed, 7 Jul 2021 08:51:24 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 749EC225C9; Wed, 7 Jul 2021 08:51:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1625647883; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Na5evhOsPxdyk72/iMdkQgvxgJL+H66b/attKNc3EDA=; b=MgtFim01IVbQXdnFPyFxUGGjIy5X8tThXCwGmxd/3aH5jzoQCkgj9zlFPa5l1xQD0rIba2 /R3+FBCiv5ZlQpNzbPM2TdtlJnuGxxYnkrYs5gddR7bdB6JUIq1bAy1go1tkryf1+bP7fy oborxHQ6IgFSKtyAN/6ZneEuKFxFhHo= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 3765BA3B9C; Wed, 7 Jul 2021 08:51:23 +0000 (UTC) Date: Wed, 7 Jul 2021 10:51:22 +0200 From: Michal Hocko To: "Uladzislau Rezki (Sony)" Cc: Andrew Morton , linux-mm@kvack.org, LKML , Mel Gorman , Christoph Hellwig , Matthew Wilcox , Nicholas Piggin , Hillf Danton , Oleksiy Avramchenko , Steven Rostedt Subject: Re: [PATCH v2 2/2] mm/vmalloc: Remove gfpflags_allow_blocking() check Message-ID: References: <20210705170537.43060-1-urezki@gmail.com> <20210705170537.43060-2-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210705170537.43060-2-urezki@gmail.com> Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=MgtFim01; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6E0661002B04 X-Stat-Signature: na6o9mdbwbt9qaw6xad5r9emr8wkbqiy X-HE-Tag: 1625647884-793226 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 05-07-21 19:05:37, Uladzislau Rezki (Sony) wrote: > Get rid of gfpflags_allow_blocking() check from the vmalloc() path > as it is supposed to be sleepable anyway. Thus remove it from the > alloc_vmap_area() as well as from the vm_area_alloc_pages(). > > Signed-off-by: Uladzislau Rezki (Sony) Acked-by: Michal Hocko > --- > mm/vmalloc.c | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 5297958ac7c5..93a9cbdba905 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1479,6 +1479,7 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, > int node, gfp_t gfp_mask) > { > struct vmap_area *va; > + unsigned long freed; > unsigned long addr; > int purged = 0; > int ret; > @@ -1542,13 +1543,12 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, > goto retry; > } > > - if (gfpflags_allow_blocking(gfp_mask)) { > - unsigned long freed = 0; > - blocking_notifier_call_chain(&vmap_notify_list, 0, &freed); > - if (freed > 0) { > - purged = 0; > - goto retry; > - } > + freed = 0; > + blocking_notifier_call_chain(&vmap_notify_list, 0, &freed); > + > + if (freed > 0) { > + purged = 0; > + goto retry; > } > > if (!(gfp_mask & __GFP_NOWARN) && printk_ratelimit()) > @@ -2834,9 +2834,7 @@ vm_area_alloc_pages(gfp_t gfp, int nid, > for (i = 0; i < (1U << order); i++) > pages[nr_allocated + i] = page + i; > > - if (gfpflags_allow_blocking(gfp)) > - cond_resched(); > - > + cond_resched(); > nr_allocated += 1U << order; > } > > -- > 2.20.1 -- Michal Hocko SUSE Labs