From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FE9EC07E9C for ; Mon, 5 Jul 2021 11:44:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B64906128D for ; Mon, 5 Jul 2021 11:44:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B64906128D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1017F6B0036; Mon, 5 Jul 2021 07:44:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B1CA6B005D; Mon, 5 Jul 2021 07:44:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E941D6B006C; Mon, 5 Jul 2021 07:44:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id C72DA6B0036 for ; Mon, 5 Jul 2021 07:44:52 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 53C96183DC7AC for ; Mon, 5 Jul 2021 11:44:52 +0000 (UTC) X-FDA: 78328352424.07.0DDF5B6 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by imf21.hostedemail.com (Postfix) with ESMTP id 1DF97D003083 for ; Mon, 5 Jul 2021 11:44:51 +0000 (UTC) Received: by mail-wm1-f43.google.com with SMTP id j39-20020a05600c1c27b029020028e48b8fso5546504wms.0 for ; Mon, 05 Jul 2021 04:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JP655Kr0pQo2WIEbmEE6zI777FgwwqQfTWCo3Yd5U5Y=; b=uVl/FVYJR66p3A+kTDkqnN7VGlSQH2HYny3y9odL82wmHYTn9aH1WGEmu+h0FeYauC XwnS6zy3SaCJ5XCHrHqep5UyIi/Wh0uzT5Y+/+hCbwiCW1j0KO1o1ZzggGbPVvM3rbm8 aRD4zSyImawZGVKdM8xHreAQBpF5mJ+/YA8+ZeyFTjBWC3xx6a9yBGyjOzzgyr5fsrrH KcwGX4zga1PXdrqed0GRvruAL7oWpaaGtmB5zPknc2F/r6F/O1YEhNCBP0fbDvePqyA/ LhEohLJTnAZPxf1ck9Kp+6WvXiQBYaYszNeweTXKjsztlc3qEmqV/tBr19WeIEtJFawi 4D5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JP655Kr0pQo2WIEbmEE6zI777FgwwqQfTWCo3Yd5U5Y=; b=OZr8RbHc9j7A6btF4J9HHKanINr6dMA1+vAVtjARi1CC+hwpfJTTKxw8+Oc6MDS93k jpEYHBn2Ub0MSsM4jyQr87o5tgQzADbZRJ7PDOly22P6dYVpSxZQuPa8uLTvxaK7C2n6 c2EhH0jucBHsPVYvbOBu6m4mrmKgPy2WNY1oIAgqgMEP4ioBeMHTNhegCJ5rvoV7huY6 UmAnXY39EzwfvCuSK03PZf4ocLBp/J4hmT+OmPRuy80VTit9l1IQH5rE3UBE2zsSIVfV RyNNunlYlR7hjvLetG9f/uTXu9HQxKc0opkY5iTb9tF+V0edJRFuVNnkSkEPrGypyxUk 6zlg== X-Gm-Message-State: AOAM530F6jVStETfBlIsoBPMMPyg1t1cX5Hoqmg0E5cXUo/x+UHIlO+4 U5T1rpYWCYnrFL0M0ZmRm0obug== X-Google-Smtp-Source: ABdhPJzljqGqiLe7uyr/rqQf0Ml0k1xid251PBNTF5gFjcEUlXtmY57iuHxc55ce9q/6TbKn4gwJ0Q== X-Received: by 2002:a1c:25c6:: with SMTP id l189mr15148080wml.49.1625485490745; Mon, 05 Jul 2021 04:44:50 -0700 (PDT) Received: from elver.google.com ([2a00:79e0:15:13:dddd:647c:7745:e5f7]) by smtp.gmail.com with ESMTPSA id r16sm15313150wrx.63.2021.07.05.04.44.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jul 2021 04:44:50 -0700 (PDT) Date: Mon, 5 Jul 2021 13:44:44 +0200 From: Marco Elver To: Mel Gorman Cc: akpm@linux-foundation.org, glider@google.com, dvyukov@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kasan-dev@googlegroups.com, Andrii Nakryiko , Daniel Borkmann , Vlastimil Babka , Yang Shi , bpf@vger.kernel.org, Alexei Starovoitov Subject: Re: [PATCH] Revert "mm/page_alloc: make should_fail_alloc_page() static" Message-ID: References: <20210705103806.2339467-1-elver@google.com> <20210705113723.GN3840@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210705113723.GN3840@techsingularity.net> User-Agent: Mutt/2.0.5 (2021-01-21) X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1DF97D003083 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b="uVl/FVYJ"; spf=pass (imf21.hostedemail.com: domain of elver@google.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: yq8p4ypjyue4hynrz6745atcq5jjhn1j X-HE-Tag: 1625485491-21038 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 05, 2021 at 12:37PM +0100, Mel Gorman wrote: > On Mon, Jul 05, 2021 at 12:38:06PM +0200, Marco Elver wrote: > > This reverts commit f7173090033c70886d925995e9dfdfb76dbb2441. > > > > Commit 76cd61739fd1 ("mm/error_inject: Fix allow_error_inject function > > signatures") explicitly made should_fail_alloc_page() non-static, due to > > worries of remaining compiler optimizations in the absence of function > > side-effects while being noinline. > > > > Furthermore, kernel/bpf/verifier.c pushes should_fail_alloc_page onto > > the btf_non_sleepable_error_inject BTF IDs set, which when enabling > > CONFIG_DEBUG_INFO_BTF results in an error at the BTFIDS stage: > > > > FAILED unresolved symbol should_fail_alloc_page > > > > To avoid the W=1 warning, add a function declaration right above the > > function itself, with a comment it is required in a BTF IDs set. > > > > Fixes: f7173090033c ("mm/page_alloc: make should_fail_alloc_page() static") > > Cc: Mel Gorman > > Cc: Alexei Starovoitov > > Signed-off-by: Marco Elver > > Acked-by: Mel Gorman > > Out of curiousity though, why does block/blk-core.c not require > something similar for should_fail_bio? It seems kernel/bpf/verifier.c doesn't refer to it in an BTF IDs set. Looks like should_fail_alloc_page is special for BPF purposes. I'm not a BPF maintainer, so hopefully someone can explain why should_fail_alloc_page is special for BPF. Thanks, -- Marco