From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sasha Levin <sashal@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>, Hugh Dickins <hughd@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
Miaohe Lin <linmiaohe@huawei.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
stable@vger.kernel.org
Subject: Re: 5.13.2-rc and others have many not for stable
Date: Wed, 14 Jul 2021 13:21:59 -0400 [thread overview]
Message-ID: <YO8dN9U7J2bi1gkf@mit.edu> (raw)
In-Reply-To: <YO8Gzl2zmg8+R8Uu@kroah.com>
On Wed, Jul 14, 2021 at 05:46:22PM +0200, Greg Kroah-Hartman wrote:
>
> The number of valid cases where someone puts a "Fixes:" tag, and that
> patch should NOT be backported is really really slim. Why would you put
> that tag and not want to have known-broken kernels fixed?
>
> If it really is not an issue, just do not put the "Fixes:" tag?
I think it really boils down to what the tags are supposed to mean and
what do they imply.
The argument from the other side is if the Stable maintainers are
interpreting the Fixes: tag as an implicit "CC: stable", why should we
have the "Cc: stable" tag at all in that case?
We could also have the policy that in the case where you have a fix
for a bug, but it's super subtle, and shouldn't be automatically
backported, that the this should be explained in the commit, e.g.,
This commit fixes a bug in "1adeadbeef33: lorem ipsum dolor sit
amet" but it is touching code which subtle and quick to anger, the
bug isn't all that serious. So please don't backport it
automatically; someone should manually do the backport and run the
fooblat test before sumitting it to the stable maintainers.
Andrew seems to be of the opinion that these sorts of cases are very
common. I don't have enough data to have a strong opinion either way.
But if you are right that it is a rare case, then sure, simply
omitting the Fixes: tag and using text in the commit description would
work. We just need to agree that this is the convention that we all
shoulf be using.
I still wonder though what's the point of having the "Cc: stable" tag
if it's implicitly assumed to be there if there is a Fixes: tagle.
Cheers,
- Ted
next prev parent reply other threads:[~2021-07-14 17:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 5:55 Hugh Dickins
2021-07-13 6:31 ` Greg Kroah-Hartman
2021-07-13 7:20 ` Greg Kroah-Hartman
2021-07-14 1:28 ` Andrew Morton
2021-07-14 7:24 ` Jiri Slaby
2021-07-14 7:52 ` Michal Hocko
2021-07-14 15:30 ` Sasha Levin
2021-07-15 7:07 ` Michal Hocko
2021-07-15 15:57 ` Justin Forbes
2021-07-14 9:18 ` Greg Kroah-Hartman
2021-07-14 13:23 ` Greg Kroah-Hartman
2021-07-14 21:09 ` Andrew Morton
2021-07-15 10:39 ` Mel Gorman
2021-07-14 13:52 ` Sasha Levin
2021-07-14 15:35 ` Theodore Y. Ts'o
2021-07-14 15:43 ` Greg Kroah-Hartman
2021-07-14 15:46 ` Greg Kroah-Hartman
2021-07-14 17:21 ` Theodore Y. Ts'o [this message]
2021-07-14 17:34 ` Greg Kroah-Hartman
2021-07-15 9:01 ` Geert Uytterhoeven
2021-07-15 14:47 ` Theodore Y. Ts'o
2021-07-15 15:03 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YO8dN9U7J2bi1gkf@mit.edu \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=hughd@google.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox