From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19A56C07E95 for ; Tue, 13 Jul 2021 13:03:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CF90960FF0 for ; Tue, 13 Jul 2021 13:03:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF90960FF0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 04FDD6B008C; Tue, 13 Jul 2021 09:03:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 026B36B0095; Tue, 13 Jul 2021 09:03:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E30CA6B0096; Tue, 13 Jul 2021 09:03:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0247.hostedemail.com [216.40.44.247]) by kanga.kvack.org (Postfix) with ESMTP id BC4C16B008C for ; Tue, 13 Jul 2021 09:03:07 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id BDACE1808F559 for ; Tue, 13 Jul 2021 13:03:06 +0000 (UTC) X-FDA: 78357579972.34.8092B22 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 2AB196002F8F for ; Tue, 13 Jul 2021 13:02:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QTFWZ70fPTxxGEfvpW72iHrISZ3ROumWvX7+BCwkJ0E=; b=WpZY2MwAsMub0Dpyaxn+R4FRAo WgnNZJlWVxz5235Wc62HNNBkKgC0R28TaOahiPk8q/dWIx3h1KiplTIONREJFaRDQdKs+aGRZyoNu OU9h3YiS2XtS0Cv3S2EGJBjoM3MeKEpXZ9D+NpUz/h0VN/80t1ai8S3AspZs2LXny6NITrT97g+T6 SSsoraYw1DjXzAZ1fCNugbAbMVv7HTIU1NNDptus1BhndrabfeUR6OxcjAbyTDxK+nAqvmleK+Q+2 TZdxfMhdz5W0KEQFS2WWI1Yb6EIHkMo1pt81H0JCYZBr3EaKfFf5fTqlWWBQS3i5OUfVhz9CCFwPC PHSeeC4Q==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3I32-0017Jd-Rs; Tue, 13 Jul 2021 13:02:10 +0000 Date: Tue, 13 Jul 2021 14:02:04 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH v13 15/18] mm/memcg: Add folio_lruvec() Message-ID: References: <20210712194551.91920-1-willy@infradead.org> <20210712194551.91920-16-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210712194551.91920-16-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=WpZY2MwA; spf=none (imf14.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam05 X-Stat-Signature: era3zmbreqcdb8mm5kbiwnyerc1eg4ug X-Rspamd-Queue-Id: 2AB196002F8F X-HE-Tag: 1626181362-636935 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 12, 2021 at 08:45:48PM +0100, Matthew Wilcox (Oracle) wrote: > This replaces mem_cgroup_page_lruvec(). All callers converted. Looks good, especially as it doesn't have much to do with cgroups except as an implementation detail. Shouldn't this function also move out of memcontrol.h eventually? Reviewed-by: Christoph Hellwig