From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71980C07E96 for ; Thu, 15 Jul 2021 06:36:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8730261260 for ; Thu, 15 Jul 2021 06:36:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8730261260 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AB98A8D009B; Thu, 15 Jul 2021 02:36:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A424D8D0065; Thu, 15 Jul 2021 02:36:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BC358D009B; Thu, 15 Jul 2021 02:36:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0031.hostedemail.com [216.40.44.31]) by kanga.kvack.org (Postfix) with ESMTP id 611A88D0065 for ; Thu, 15 Jul 2021 02:36:08 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4B97C184823DD for ; Thu, 15 Jul 2021 06:36:07 +0000 (UTC) X-FDA: 78363862374.38.EB5C77F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id 83C849000163 for ; Thu, 15 Jul 2021 06:36:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CBl2VbaTdlKaH4VdQOVbFJXpYe5+X4n0PYeP3gGFhmw=; b=HVx5UynZUPZuFSLz1peXEzSiui fHGlitA5xB/4BNt7w4RTcKEKAgwaLusWMwKEzR5DcPnKgA042rT0ykbOH2gd5iyb0lak+N2DeEKbX /Cp8E78iwPXeic83+AOir9G5hKZr/NpKW/xPtL6+NR68k1TA32s8th1Yc1ZI8CoeFKFw362DKfIKv xN1ESk5G3ObdxLzTD4f+boNFRjZC+GI0XelAWbo+tG/27DAVoJKHjB5q8IF/8ix40WjRUPp5guFJQ an62NYznW4UVydbRgLN0jNhebePBI3caQ4TPRo8FSDjPc5dtA7xY50PkhozSqarP4C6J2GXxQKr1F v5I4p7fg==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3uxR-0033qb-UF; Thu, 15 Jul 2021 06:35:00 +0000 Date: Thu, 15 Jul 2021 07:34:53 +0100 From: Christoph Hellwig To: Mel Gorman Cc: Andrew Morton , Desmond Cheong Zhi Xi , Zhang Qiang , Yanfei Xu , Chuck Lever , Jesper Dangaard Brouer , Matteo Croce , Linux-MM , LKML Subject: Re: [PATCH 4/4] Revert "mm/page_alloc: make should_fail_alloc_page() static" Message-ID: References: <20210713135625.7615-1-mgorman@techsingularity.net> <20210713135625.7615-5-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210713135625.7615-5-mgorman@techsingularity.net> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 83C849000163 X-Stat-Signature: qnucropbqqzp4mgg8bcasfksu99coaem Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=HVx5UynZ; spf=none (imf29.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-HE-Tag: 1626330962-285309 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 13, 2021 at 02:56:25PM +0100, Mel Gorman wrote: > From: Matteo Croce > > This reverts commit f7173090033c70886d925995e9dfdfb76dbb2441. > > Fix an unresolved symbol error when CONFIG_DEBUG_INFO_BTF=y: I still fundamentally disagreed with this "fix". Whatever code requires a function to be non-static without a prototype and reference is completely fucked up beyond rescue and needs to be disabled util it can be fixed instead of worked around like this.