From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EC8CC11F68 for ; Wed, 30 Jun 2021 12:22:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 082C4613ED for ; Wed, 30 Jun 2021 12:22:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 082C4613ED Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3A5CA8D01A4; Wed, 30 Jun 2021 08:22:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37C158D01A2; Wed, 30 Jun 2021 08:22:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21DB38D01A4; Wed, 30 Jun 2021 08:22:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id F26E28D01A2 for ; Wed, 30 Jun 2021 08:22:09 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D1A3E23E7A for ; Wed, 30 Jun 2021 12:22:09 +0000 (UTC) X-FDA: 78310302378.31.E3874E9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf11.hostedemail.com (Postfix) with ESMTP id 70727F0000A3 for ; Wed, 30 Jun 2021 12:22:09 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 89462226F9; Wed, 30 Jun 2021 12:22:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1625055728; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Jy9BUnnL9F4MU2WhkG8c4GL66SNmDqJ6jDqN3uAgDRg=; b=Wvb5ZzhZYyujUgG5/ndOGyrXHa6nuv/37LimXf4fJjhnFF1SLhtKTP3v1Zp01GJzK5BJ2R G8YmkcX2a9fEuckIv4jYOZvUCsCH6bSnITCJiHwJ+gymd2RTQVnkPnpJy24U5ben1NVDi4 qP7FxhuqHkGHj1ceUp9W5Wb3lPtIXaI= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 4FF10A3B8E; Wed, 30 Jun 2021 12:22:08 +0000 (UTC) Date: Wed, 30 Jun 2021 14:22:07 +0200 From: Michal Hocko To: Hui Su Cc: hannes@cmpxchg.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/vmpressure: replace vmpressure_to_css() with vmpressure_to_memcg() Message-ID: References: <20210630112146.455103-1-suhui@zeku.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210630112146.455103-1-suhui@zeku.com> Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Wvb5ZzhZ; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Stat-Signature: a9rekxydxo81ygs8femprr8zhyyqabgj X-Rspamd-Queue-Id: 70727F0000A3 X-Rspamd-Server: rspam06 X-HE-Tag: 1625055729-35925 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 30-06-21 19:21:46, Hui Su wrote: > We can get memcg directly form vmpr instead of vmpr->memcg->css->memcg, > so add a new func helper vmpressure_to_memcg(). > And no code will use vmpressure_to_css(), so delete it. Nice cleanup. > Signed-off-by: Hui Su Acked-by: Michal Hocko Thanks! > --- > include/linux/vmpressure.h | 2 +- > mm/memcontrol.c | 4 ++-- > mm/vmpressure.c | 3 +-- > 3 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/include/linux/vmpressure.h b/include/linux/vmpressure.h > index 6d28bc433c1c..6a2f51ebbfd3 100644 > --- a/include/linux/vmpressure.h > +++ b/include/linux/vmpressure.h > @@ -37,7 +37,7 @@ extern void vmpressure_prio(gfp_t gfp, struct mem_cgroup *memcg, int prio); > extern void vmpressure_init(struct vmpressure *vmpr); > extern void vmpressure_cleanup(struct vmpressure *vmpr); > extern struct vmpressure *memcg_to_vmpressure(struct mem_cgroup *memcg); > -extern struct cgroup_subsys_state *vmpressure_to_css(struct vmpressure *vmpr); > +extern struct mem_cgroup *vmpressure_to_memcg(struct vmpressure *vmpr); > extern int vmpressure_register_event(struct mem_cgroup *memcg, > struct eventfd_ctx *eventfd, > const char *args); > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 64ada9e650a5..62163a9cee63 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -247,9 +247,9 @@ struct vmpressure *memcg_to_vmpressure(struct mem_cgroup *memcg) > return &memcg->vmpressure; > } > > -struct cgroup_subsys_state *vmpressure_to_css(struct vmpressure *vmpr) > +struct mem_cgroup *vmpressure_to_memcg(struct vmpressure *vmpr) > { > - return &container_of(vmpr, struct mem_cgroup, vmpressure)->css; > + return container_of(vmpr, struct mem_cgroup, vmpressure); > } > > #ifdef CONFIG_MEMCG_KMEM > diff --git a/mm/vmpressure.c b/mm/vmpressure.c > index d69019fc3789..04e81ac6d5d8 100644 > --- a/mm/vmpressure.c > +++ b/mm/vmpressure.c > @@ -74,8 +74,7 @@ static struct vmpressure *work_to_vmpressure(struct work_struct *work) > > static struct vmpressure *vmpressure_parent(struct vmpressure *vmpr) > { > - struct cgroup_subsys_state *css = vmpressure_to_css(vmpr); > - struct mem_cgroup *memcg = mem_cgroup_from_css(css); > + struct mem_cgroup *memcg = vmpressure_to_memcg(vmpr); > > memcg = parent_mem_cgroup(memcg); > if (!memcg) > -- > 2.25.1 -- Michal Hocko SUSE Labs