From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3BD7C11F68 for ; Wed, 30 Jun 2021 06:59:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5CF39610FA for ; Wed, 30 Jun 2021 06:59:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CF39610FA Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C46948D0183; Wed, 30 Jun 2021 02:59:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C1DCA8D017A; Wed, 30 Jun 2021 02:59:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE5F08D0183; Wed, 30 Jun 2021 02:59:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id 83FAC8D017A for ; Wed, 30 Jun 2021 02:59:22 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5B21D1809554D for ; Wed, 30 Jun 2021 06:59:22 +0000 (UTC) X-FDA: 78309488964.34.6BA0FF0 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf24.hostedemail.com (Postfix) with ESMTP id 04ED1B000096 for ; Wed, 30 Jun 2021 06:59:21 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 1C8E81FE3A; Wed, 30 Jun 2021 06:59:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1625036361; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CBX5W0P8DL2x/XCJkVNccKGv5Jq305wfaEnKjkBFQbU=; b=tQDnM997hmtRMIDHmNoz8iYve7UjLjIA9Xnyf1hZOU7z059jrks20PJMzWuIZ6sseJT5r0 kZXRR5Ot0CdSeaOBAGXmyTCvnH0LuoP/CiuIrso4go+5g8N9ZBirBRb2aQSJOjj4nGmuwd cwOOLPE1ENmq3zIH0sLfD9BV68EIjLU= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id DE318A3B88; Wed, 30 Jun 2021 06:59:20 +0000 (UTC) Date: Wed, 30 Jun 2021 08:59:20 +0200 From: Michal Hocko To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, Johannes Weiner , Vladimir Davydov Subject: Re: [PATCH v3 05/18] mm/memcg: Convert memcg_check_events to take a node ID Message-ID: References: <20210630040034.1155892-1-willy@infradead.org> <20210630040034.1155892-6-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 04ED1B000096 X-Stat-Signature: ad3onjyadxrp1qyk73w516snynffctwa Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=tQDnM997; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf24.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com X-HE-Tag: 1625036361-450058 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 30-06-21 08:58:20, Michal Hocko wrote: > On Wed 30-06-21 05:00:21, Matthew Wilcox wrote: > > memcg_check_events only uses the page's nid, so call page_to_nid in the > > callers to make the folio conversion easier. > > It will also make the interface slightly easier to follow as there > shouldn't be any real reason to take the page for these events. > So this is a good cleanup in general. > > > Signed-off-by: Matthew Wilcox (Oracle) > > Acked-by: Michal Hocko Btw. patches 2-5 seem good enough to go to Andrew even without the rest so that you do not have to carry them along with the rest which is quite large I can imagine. -- Michal Hocko SUSE Labs