From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C4B6C11F6A for ; Tue, 29 Jun 2021 14:12:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ACE1661DE5 for ; Tue, 29 Jun 2021 14:12:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACE1661DE5 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CE6B38D014F; Tue, 29 Jun 2021 10:12:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C96EC8D00F0; Tue, 29 Jun 2021 10:12:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B374F8D014F; Tue, 29 Jun 2021 10:12:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0072.hostedemail.com [216.40.44.72]) by kanga.kvack.org (Postfix) with ESMTP id 8AFF58D00F0 for ; Tue, 29 Jun 2021 10:12:03 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3AC9222892 for ; Tue, 29 Jun 2021 14:12:03 +0000 (UTC) X-FDA: 78306950526.34.C742B9E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf18.hostedemail.com (Postfix) with ESMTP id 874084002093 for ; Tue, 29 Jun 2021 14:12:02 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 03B72226AB; Tue, 29 Jun 2021 14:12:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1624975921; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DlisRa0Lh5ZDcC0aA7CRmD4wVeWJekk5S8eo2LllnQc=; b=fMk0ecluwK7phJjKD9C3ZylkpTsyXs8oYN5zeMO/FPdQAPqjA7vhETF42T/F1zjHVJbPl9 NuG+i0qntP33K2L/zVXmoz1Qk1zPJUmvcNce1m+gpZd3eMffJvVExv5o9Q+9jBlcCSaCJ5 39DzkZtx4ptmQv2P2f1W0TaA83Cc9+U= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id C75B2A3C42; Tue, 29 Jun 2021 14:12:00 +0000 (UTC) Date: Tue, 29 Jun 2021 16:11:59 +0200 From: Michal Hocko To: Uladzislau Rezki Cc: Mel Gorman , Andrew Morton , Matthew Wilcox , Rafael Aquini , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: vmalloc: add cond_resched() in __vunmap() Message-ID: References: <20210622225030.478384-1-aquini@redhat.com> <20210624142339.GA2267@pc638.lan> <20210625160011.GA50201@pc638.lan> <20210628164002.GA11817@pc638.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210628164002.GA11817@pc638.lan> Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=fMk0eclu; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf18.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com X-Rspamd-Server: rspam02 X-Stat-Signature: c5q39xn5cgzp3tuhwtdkdzm5miy7ieza X-Rspamd-Queue-Id: 874084002093 X-HE-Tag: 1624975922-667499 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 28-06-21 18:40:02, Uladzislau Rezki wrote: > Also another option can be: > > if a pcp list is fully consumed, so a refilling is required to proceed with array > populating, leave atomic section(enable irq), do a breath by invoking cond_resched()? I do not know. I would rather not medle with the pcp batches. It is a hot path and caller can decide the fallback mechanism. -- Michal Hocko SUSE Labs