From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6743C2B9F4 for ; Mon, 28 Jun 2021 06:19:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 78F4B61474 for ; Mon, 28 Jun 2021 06:19:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78F4B61474 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BD7BE8D0023; Mon, 28 Jun 2021 02:19:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BAE778D0022; Mon, 28 Jun 2021 02:19:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9F1E8D0023; Mon, 28 Jun 2021 02:19:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id 79F358D0022 for ; Mon, 28 Jun 2021 02:19:46 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 671E58249980 for ; Mon, 28 Jun 2021 06:19:46 +0000 (UTC) X-FDA: 78302131572.30.9C9AC70 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id AFBBAA001A63 for ; Mon, 28 Jun 2021 06:19:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xMH8quXQ1KpWPHQ/uSY3qrmdHTNL0PryLpfY1lJx2As=; b=iWmFPkkIzsRjeKkXUXSj1vkwO3 Opc9hXPZSxrq59VAAIL4MKfAvvLICTMq7YzIdJfPyoLMiicmO9d6mLrbmRtUxQ9gvR78JX8LRpZ5d 2YW/N99ZjFSL4HWkTuCqa5fTgpbFWhlQQgtbZU9ZYidjkCoFJDT/zR+CujqyWCfvzANW1izB7AcRm c/D0742mwQsHmcl7juN3pVd2PsNkQDIkRcmPnMa0+B19cqqB1NbojPjOzsW+ql6Lvo109Sz+V1ph+ zXB35fnSX4wO2LXWPh+pkqj9WzrNUupNSDr/ptvFj9BrqAWapjEcMZdVBOg5QzH6GvSEe3DmsvklF A9R904fw==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxkaw-002eLV-Ka; Mon, 28 Jun 2021 06:18:18 +0000 Date: Mon, 28 Jun 2021 07:18:10 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/46] mm: Add folio_to_pfn() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=iWmFPkkI; spf=none (imf24.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: AFBBAA001A63 X-Stat-Signature: kyz6d83ubqjyf7yo3gyspnrsm3dt8hbn X-HE-Tag: 1624861185-197242 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 24, 2021 at 04:12:05PM +0100, Matthew Wilcox wrote: > On Wed, Jun 23, 2021 at 08:49:55AM +0100, Christoph Hellwig wrote: > > On Tue, Jun 22, 2021 at 01:15:06PM +0100, Matthew Wilcox (Oracle) wrote: > > > The pfn of a folio is the pfn of its head page. > > > > > > Signed-off-by: Matthew Wilcox (Oracle) > > > > Maybe add a kerneldoc comment stating that? > > /** > * folio_to_pfn - Return the Page Frame Number of a folio. > * @folio: The folio. > * > * A folio may contain multiple pages. The pages have consecutive > * Page Frame Numbers. > * > * Return: The Page Frame Number of the first page in the folio. > */ Looks fine.