From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0617FC2B9F4 for ; Fri, 25 Jun 2021 17:02:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AD89361949 for ; Fri, 25 Jun 2021 17:02:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD89361949 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AD48D6B0036; Fri, 25 Jun 2021 13:02:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A847D6B005D; Fri, 25 Jun 2021 13:02:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D77B6B006C; Fri, 25 Jun 2021 13:02:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0227.hostedemail.com [216.40.44.227]) by kanga.kvack.org (Postfix) with ESMTP id 5CAE86B0036 for ; Fri, 25 Jun 2021 13:02:06 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7406B16953 for ; Fri, 25 Jun 2021 17:02:06 +0000 (UTC) X-FDA: 78292863852.06.4FB499D Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf12.hostedemail.com (Postfix) with ESMTP id 227E5983 for ; Fri, 25 Jun 2021 17:01:58 +0000 (UTC) Received: from zn.tnic (p200300ec2f0dae00689ae3531874a6f6.dip0.t-ipconnect.de [IPv6:2003:ec:2f0d:ae00:689a:e353:1874:a6f6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 4E9001EC059E; Fri, 25 Jun 2021 19:01:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1624640515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=pu13lrRI0VXpD1HEqkvclBljYf9ytk96hnSQt+aGmXw=; b=H1Yh4uzkPMKaMMOc+J9XbxrYO+z86o2WWlQVVxl82WbgjTqaiX3mkttyZllUnBddq7N0N5 Ukg5SxlpmjgUH+BM5DHkGprnwGt82c60n9RwtC8HblbAy8IVmFIKukkbfNCcCN5GRRyjPm wkzuNTYqCqf0MUdFLijx97OgboDYlW8= Date: Fri, 25 Jun 2021 19:01:54 +0200 From: Borislav Petkov To: Brijesh Singh Cc: Michael Roth , "Kuppuswamy, Sathyanarayanan" , Dave Hansen , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Andy Lutomirski , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , tony.luck@intel.com, npmccallum@redhat.com Subject: Re: [PATCH Part1 RFC v3 20/22] x86/boot: Add Confidential Computing address to setup_header Message-ID: References: <162442264313.98837.16983159316116149849@amd.com> <20210624031911.eznpkbgjt4e445xj@amd.com> <20210624123447.zbfkohbtdusey66w@amd.com> <20210624141111.pzvb6gk5lzfelx26@amd.com> <8faad91a-f229-dee3-0e1f-0b613596db17@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8faad91a-f229-dee3-0e1f-0b613596db17@amd.com> Authentication-Results: imf12.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b=H1Yh4uzk; dmarc=temperror reason="query timed out" header.from=alien8.de (policy=temperror); spf=temperror (imf12.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de X-Rspamd-Server: rspam02 X-Stat-Signature: kxesqp8zdznogi8fdoqbf6abexmh83z9 X-Rspamd-Queue-Id: 227E5983 X-HE-Tag: 1624640518-135745 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 25, 2021 at 10:24:01AM -0500, Brijesh Singh wrote: > In the case of EFI, the CC blob structure is dynamically allocated > and passed through the EFI configuration table. The grub will not > know what value to pass in the cmdline unless we improve it to read > the EFI configuration table and rebuild the cmdline. Or simply parse the EFI table. To repeat my question: why do you need the CC blob in the boot kernel? Then, how does it work then in the !EFI case? The script glue that starts the lightweight container goes and "prepares" that blob and passes it to guest kernel? In which case setup_data should do the job, methinks. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette