From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09E01C2B9F4 for ; Fri, 25 Jun 2021 03:54:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AF599613F7 for ; Fri, 25 Jun 2021 03:54:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF599613F7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AFD716B006C; Thu, 24 Jun 2021 23:54:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A86876B0071; Thu, 24 Jun 2021 23:54:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 900256B0070; Thu, 24 Jun 2021 23:54:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0088.hostedemail.com [216.40.44.88]) by kanga.kvack.org (Postfix) with ESMTP id 5CDFF6B005D for ; Thu, 24 Jun 2021 23:54:22 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DF26A248B1 for ; Fri, 25 Jun 2021 03:54:20 +0000 (UTC) X-FDA: 78290878680.14.9F8D1E1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 3B3D79001460 for ; Fri, 25 Jun 2021 03:54:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xFO4N6E60UVpWuHg8zReKw2PcZ4PO8kIPmHEGAImtWo=; b=COW866MbeTbLRzrFm2FIRz903n 9zoOeOuh9QurapHW+rP3H9pizslgs4wp8S9lL4OTGCD2/UbjvZI0Ub47n5PE1i1nIShnTq4zKl5zg C5LgZ29esYqmd50TpQjiWlxUAlXHmOUbecsDDRzkEbIKIDvNg8204/WceFxSTIjgZ1nPYFc8jD8p8 a//TZTrIJ5fO2pU1pwkYMl5yfLlQRvG1GaW+Pp4QZ88bH11eFfqu8ABsLXju3bezuxmNN90WUPO3x ofqNbVr2OS50dqbOwR2RNSB/1OCIAfPS8/rA7P88R8rhyAdzN9al3sqrUwhty836upbjm2qYOepNt lUW89wnw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwcux-00HHKC-2a; Fri, 25 Jun 2021 03:54:13 +0000 Date: Fri, 25 Jun 2021 04:54:11 +0100 From: Matthew Wilcox To: Dave Chinner Cc: linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/3] mm: Add kvrealloc() Message-ID: References: <20210625023029.1472466-1-david@fromorbit.com> <20210625023029.1472466-2-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210625023029.1472466-2-david@fromorbit.com> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3B3D79001460 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=COW866Mb; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Stat-Signature: t95h4yychzpcz8cnp6sice5s6gfajh34 X-HE-Tag: 1624593260-829603 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 25, 2021 at 12:30:27PM +1000, Dave Chinner wrote: > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 8ae31622deef..34d88ff00f31 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -830,6 +830,20 @@ static inline void *kvcalloc(size_t n, size_t size, gfp_t flags) > extern void kvfree(const void *addr); > extern void kvfree_sensitive(const void *addr, size_t len); > > +static inline void *kvrealloc(void *p, size_t oldsize, size_t newsize, > + gfp_t flags) > +{ > + void *newp; > + > + if (oldsize >= newsize) > + return p; > + newp = kvmalloc(newsize, flags); > + memcpy(newp, p, oldsize); > + kvfree(p); > + return newp; > +} Why make this an inline function instead of putting it in mm/util.c?