From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 126AEC49EA5 for ; Thu, 24 Jun 2021 16:43:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B5E56613C2 for ; Thu, 24 Jun 2021 16:43:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5E56613C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 96DC16B006C; Thu, 24 Jun 2021 12:43:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91E0C6B0070; Thu, 24 Jun 2021 12:43:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BE686B0071; Thu, 24 Jun 2021 12:43:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id 497856B006C for ; Thu, 24 Jun 2021 12:43:49 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 78B2922003 for ; Thu, 24 Jun 2021 16:43:49 +0000 (UTC) X-FDA: 78289188978.15.C8FA435 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id C24692001060 for ; Thu, 24 Jun 2021 16:43:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3OGGZZCSfU1UZW7S8nvXVWevH6pEWWYEGVTlrHA4x9I=; b=N+1PYxjdBAAKCu81TZyucVa43H kTeXGRDZbd2aAC1eH8LVu7E1TdN0Lp9QyyhAi03rH3d8cAkqwyiA3BKd88zgSKnwJrZOM086o6cGf I9vLjUOtYRpWofxXD1+x7kjS3utZCOHjyyHAj2AMSHwOdJKMwNihHl5kojkplp5D13UG6dMApssXm Nv1ymtk7tQLevZDEIvw4GvHdc0CFILfTPyvWAqySd6Oy9FE6VobhgWzgKsZNC7ahDAg1VW4sHctUT ODwjQIW3XAoYBdL78jjmgpxx9YKZpzEEUp38h1pl/7pfXF0SaHdyby6u3KduoykL244QF/cy6bfRj einwniJg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwSRO-00GmhX-Fk; Thu, 24 Jun 2021 16:43:05 +0000 Date: Thu, 24 Jun 2021 17:42:58 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 14/46] mm/memcg: Add folio_charge_cgroup() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-15-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=N+1PYxjd; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Stat-Signature: 6ae69o955n7ks497gn7wzius9udwy9y4 X-Rspamd-Queue-Id: C24692001060 X-Rspamd-Server: rspam06 X-HE-Tag: 1624553028-707839 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 23, 2021 at 10:15:20AM +0200, Christoph Hellwig wrote: > On Tue, Jun 22, 2021 at 01:15:19PM +0100, Matthew Wilcox (Oracle) wrote: > > mem_cgroup_charge() already assumed it was being passed a non-tail > > page (and looking at the callers, that's true; it's called for freshly > > allocated pages). The only real change here is that folio_nr_pages() > > doesn't compile away like thp_nr_pages() does as folio support > > is not conditional on transparent hugepage support. Reimplement > > mem_cgroup_charge() as a wrapper around folio_charge_cgroup(). > > Maybe rename __mem_cgroup_charge to __folio_charge_cgroup as well? Oh, yeah, should have done that. Thanks.