Re: [linux-next:master 12154/12271] tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception'

[Ricardo Koller <ricarkol@google.com>]

On Wed, Jun 23, 2021 at 08:59:59AM +0100, Marc Zyngier wrote:
> + Paolo, Vitaly, Ricardo,
> 
> On Tue, 22 Jun 2021 23:54:17 +0100,
> kernel test robot <lkp@intel.com> wrote:
> > 
> > Hi Stephen,
> > 
> > First bad commit (maybe != root cause):
> > 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head:   4238b1710eadd18dd16de0288a2bc5bb84614b4e
> > commit: 954e285eafdd4ac36b114a7f6abce3f792591ea8 [12154/12271] Merge remote-tracking branch 'kvm-arm/next'
> > config: x86_64-rhel-8.3-kselftests (attached as .config)
> > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> > reproduce (this is a W=1 build):
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=954e285eafdd4ac36b114a7f6abce3f792591ea8
> >         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> >         git fetch --no-tags linux-next master
> >         git checkout 954e285eafdd4ac36b114a7f6abce3f792591ea8
> >         # save the attached .config to linux build tree
> >         make W=1 ARCH=x86_64 
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > All error/warnings (new ones prefixed by >>):
> > 
> >    x86_64/hyperv_features.c: In function 'main':
> > >> x86_64/hyperv_features.c:618:2: warning: implicit declaration of function 'vm_handle_exception' [-Wimplicit-function-declaration]
> >      618 |  vm_handle_exception(vm, GP_VECTOR, guest_gp_handler);
> >          |  ^~~~~~~~~~~~~~~~~~~
> >    /usr/bin/ld: /tmp/ccIBsVo3.o: in function `main':
> > >> tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception'
> >    collect2: error: ld returned 1 exit status
> > --
> >    x86_64/hyperv_features.c: In function 'main':
> > >> x86_64/hyperv_features.c:618:2: warning: implicit declaration of function 'vm_handle_exception' [-Wimplicit-function-declaration]
> >      618 |  vm_handle_exception(vm, GP_VECTOR, guest_gp_handler);
> >          |  ^~~~~~~~~~~~~~~~~~~
> >    /usr/bin/ld: /tmp/cc7zqGvp.o: in function `main':
> > >> tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception'
> >    collect2: error: ld returned 1 exit status
> >
> 
> This stems from the following commit:
> 
> commit b78f4a596692f6805e796a4c13f2d921b8a95166
> Author: Ricardo Koller <ricarkol@google.com>
> Date:   Thu Jun 10 18:10:15 2021 -0700
> 
>     KVM: selftests: Rename vm_handle_exception
>     
>     Rename the vm_handle_exception function to a name that indicates more
>     clearly that it installs something: vm_install_exception_handler.
>     
>     Reported-by: kernel test robot <oliver.sang@intel.com>
>     Suggested-by: Marc Zyngier <maz@kernel.org>
>     Suggested-by: Andrew Jones <drjones@redhat.com>
>     Signed-off-by: Ricardo Koller <ricarkol@google.com>
>     Reviewed-by: Andrew Jones <drjones@redhat.com>
>     Signed-off-by: Marc Zyngier <maz@kernel.org>
>     Link: https://lore.kernel.org/r/20210611011020.3420067-2-ricarkol@google.com

Yes, that's my change (again). Thanks you both for handling it.

Thanks,
Ricardo

> 
> If there is a stable branch with this patch on it, I can take it in
> the kvmarm tree and fix it up myself. Otherwise, Paolo could take the
> stable branch at [1] (or even that particular commit which is right on
> top of v5.13-rc4) and do a similar fixup. Just let me know.
> 
> Thanks,
> 
> 	M.
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=kvm-arm64/selftest/debug
> 
> -- 
> Without deviation from the norm, progress is not possible.