From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7E06C4743C for ; Wed, 23 Jun 2021 09:51:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 734896112D for ; Wed, 23 Jun 2021 09:51:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 734896112D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6AB066B0036; Wed, 23 Jun 2021 05:51:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 65ABB6B0070; Wed, 23 Jun 2021 05:51:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5226E6B0071; Wed, 23 Jun 2021 05:51:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id 199E16B0036 for ; Wed, 23 Jun 2021 05:51:04 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 54C8A181AC9B6 for ; Wed, 23 Jun 2021 09:51:04 +0000 (UTC) X-FDA: 78284520048.04.1758F71 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 2B335400038F for ; Wed, 23 Jun 2021 09:51:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wX68kOPzYETyqJ2SCKqkqr7ukc9cCZeyMzMIUFAMr1E=; b=XjutMCRefnRt22zx8OdxtQ4Jsg G0r0exLUeLlGZZJ2j24THQD6fRqFPEuAXiq0Dshb3s0GUgZe+QEUorXxMlYKxO4F9zyL4Fdk8CfZn v4KNESEHhSvdB46CAz7mlCGzgJ6WCEZU4UVb4k3uOjmUmzIsk+1rqrhiC517KTkOCglo+8RiMqYxT SX/9lMehzoV76Ms83Y5kVTb3Bfw1/KyPX3p5zmrQ4il5X37RrzfaDgStrud1IT6P/mZ6oT2eltFM4 Pb6u9YvlQngryCf4uIS+9F1fizTp83sRZNIXMfVQHDLh1etXSGYUqxY+bO2yydSUeCT84kL5yT4k1 8XHyxp9w==; Received: from [2001:4bb8:188:3e21:6594:49:139:2b3f] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvzWH-00FHgM-KV; Wed, 23 Jun 2021 09:50:13 +0000 Date: Wed, 23 Jun 2021 11:50:04 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 36/46] mm/filemap: Add readahead_folio() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-37-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-37-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XjutMCRe; dmarc=none; spf=none (imf10.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org X-Stat-Signature: 36bi1ujr3ase5zyo44hj1513r4senhmf X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2B335400038F X-HE-Tag: 1624441864-273031 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 22, 2021 at 01:15:41PM +0100, Matthew Wilcox (Oracle) wrote: > The pointers stored in the page cache are folios, by definition. > This change comes with a behaviour change -- callers of readahead_folio() > are no longer required to put the page reference themselves. This matches > how readpage works, rather than matching how readpages used to work. The way this stores and retrieves different but compatible types from the same xarray is a little nasty. But I guess we'll have to live with it for now, so: Reviewed-by: Christoph Hellwig