From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E704FC4743C for ; Wed, 23 Jun 2021 09:45:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9CFA260725 for ; Wed, 23 Jun 2021 09:45:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CFA260725 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9994C8D0001; Wed, 23 Jun 2021 05:45:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 970676B0073; Wed, 23 Jun 2021 05:45:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85F578D0001; Wed, 23 Jun 2021 05:45:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0151.hostedemail.com [216.40.44.151]) by kanga.kvack.org (Postfix) with ESMTP id 545616B0072 for ; Wed, 23 Jun 2021 05:45:20 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7D1451AB73 for ; Wed, 23 Jun 2021 09:45:20 +0000 (UTC) X-FDA: 78284505600.16.1ACE2E8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id 20294600057F for ; Wed, 23 Jun 2021 09:45:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GP93UPkC0hitfxxYgCn7L4t08K/y+OYO9CnmPnYe08Y=; b=MhsBbYroqBJd2MoDpQGLPRoKEZ vJiwFt2VPW7m0BMFpjrgKDSmDUCN8kJMPVEHK6nOR1GmDiOimvhFdVVUH49FaJK6dXlH986l6egSp 0/2A2czQ4bTCZlMON1ohIUKz4REPRL2L+FvddLerAyDWPtYwTz4fYWB12ZoRWd7GwLDrJiQYv+JOt jbBHQ6PlIyi1UCdMSUwPzE4DPLuQB5se590lRcEh89R9aNRxml6iK0s2VSi1J4eu2130ubjEziOFw Zsvj8lEr8TC+Em7GJ3a9dh5kjbIro5RGTrcqnhodRiX8fm6e3hWCGH2n+60dHDkyljws0hWTp54nu ZBEBxm3g==; Received: from [2001:4bb8:188:3e21:6594:49:139:2b3f] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvzQh-00FHHv-7U; Wed, 23 Jun 2021 09:44:33 +0000 Date: Wed, 23 Jun 2021 11:44:18 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 32/46] mm/writeback: Add folio_account_redirty() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-33-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-33-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 20294600057F Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=MhsBbYro; spf=none (imf25.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-Stat-Signature: knx446yrpu9814gkmbxp88jpcw4j8r6b X-HE-Tag: 1624441520-543836 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 22, 2021 at 01:15:37PM +0100, Matthew Wilcox (Oracle) wrote: > Account the number of pages in the folio that we're redirtying. > Turn account_page_dirty() into a wrapper around it. Also turn > the comment on folio_account_redirty() into kernel-doc and > edit it slightly so it makes sense to its potential callers. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig