From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF353C48BC2 for ; Wed, 23 Jun 2021 09:30:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 708886044F for ; Wed, 23 Jun 2021 09:30:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 708886044F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6522C6B0011; Wed, 23 Jun 2021 05:30:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 629276B0036; Wed, 23 Jun 2021 05:30:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F0796B006C; Wed, 23 Jun 2021 05:30:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0160.hostedemail.com [216.40.44.160]) by kanga.kvack.org (Postfix) with ESMTP id 177F76B0011 for ; Wed, 23 Jun 2021 05:30:44 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2BC961813E4D9 for ; Wed, 23 Jun 2021 09:30:44 +0000 (UTC) X-FDA: 78284468808.35.7CBC411 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id D1EDB40003AF for ; Wed, 23 Jun 2021 09:30:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NU7eentD395rdHeDZnxtO6t94JfTEFM9vaCy6vjeiLE=; b=TpyRcfJAQcJETLpJhvymhsCd9K lmpYZgQoE+WXW7WlWJSdxAyarKrD/3Mh3ZqcJmy2ApK1wEwpJ4uYUYNpmc8fJxlpw7DyQMpis76YI BH5hnix8ZqRL/sL1wtXPr/CKDmbTd7vjwv2Hzm52mlcNX6YS+u4m74YbmPd4Sftpe8vReBEZJQvzt 3fQ353Kpzakay+T+ZTY18CZdQZzV318cCqwAGaE/d5dldyX0bIawT+DVdAU187PMSqLo6wB/du6uH oWPmXJfHPeH77er7UQ3jFafrVNpMLU1AaX5cyJbCHmDynATXHZnyh92L8LF1pe297SFEjGbd48HkZ KRXJtKuQ==; Received: from 089144193030.atnat0002.highway.a1.net ([89.144.193.30] helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvzCE-00FGQZ-TG; Wed, 23 Jun 2021 09:29:27 +0000 Date: Wed, 23 Jun 2021 11:27:12 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 27/46] mm/writeback: Add __folio_mark_dirty() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-28-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-28-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=TpyRcfJA; spf=none (imf10.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D1EDB40003AF X-Stat-Signature: b41hm67s74ypff16sy5uxd16is57ebz1 X-HE-Tag: 1624440643-229019 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 22, 2021 at 01:15:32PM +0100, Matthew Wilcox (Oracle) wrote: > Turn __set_page_dirty() into a wrapper around __folio_mark_dirty() (which > can directly cast from page to folio because we know that set_page_dirty() > calls filesystems with the head page). Convert account_page_dirtied() > into folio_account_dirtied() and account the number of pages in the folio. Is it really worth micro-optimizing a transitional function like that? I'd rather eat the overhead of the compound_page() call over adding hacky casts like this.