From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB916C2B9F4 for ; Thu, 17 Jun 2021 14:04:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 32880613BA for ; Thu, 17 Jun 2021 14:04:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32880613BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B94326B0071; Thu, 17 Jun 2021 10:04:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B6B6A6B0072; Thu, 17 Jun 2021 10:04:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A333E6B0073; Thu, 17 Jun 2021 10:04:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0111.hostedemail.com [216.40.44.111]) by kanga.kvack.org (Postfix) with ESMTP id 6F2EF6B0071 for ; Thu, 17 Jun 2021 10:04:38 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 04E88181AEF07 for ; Thu, 17 Jun 2021 14:04:38 +0000 (UTC) X-FDA: 78263386236.33.2AFF3D0 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf19.hostedemail.com (Postfix) with ESMTP id 1D8009001E53 for ; Thu, 17 Jun 2021 14:04:23 +0000 (UTC) Received: by mail-pl1-f177.google.com with SMTP id e1so2978615plh.8 for ; Thu, 17 Jun 2021 07:04:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=m08QhGbjsqNMKDfakqlQtcqTK06PXTezleRaulhxGzY=; b=lUWkoeD4MiFsevJjayo/38vNE7ZcF3Oxzw/b1Q07FkRc7ABIzvQDeAtOro7WvCfVrO +VJiaMYJWwbbZat1lQItgBdYyGP9y7+FW4bSanRqQ+5ocg8rG6DhPe63YNfFFMucSoq/ 1dwu701UdFYBSLnDG01vwkNtz5Ll7cMqNVi2HgAosjZ+h/TcBaznbunrF/ePq5Ki2nas mpJ+ADs4ZeMjYHk4HBtHkQ5PHbNQyAOcC6+SzcpJkxox/ri31d301yaoSmcy/5zcJnl+ iIgVGGd+lg7Rc02efWHJigJQDevZu4jTyPSQoCg626+ngc5b4j9YIYIkqhKSsoy7qgYd 6C/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=m08QhGbjsqNMKDfakqlQtcqTK06PXTezleRaulhxGzY=; b=S/HAVGgetAqBXB+A3vkBjp5a3op+/ezv1iH+ALU2H9SDx9Y41isU5ilO+UbvOG/Bz0 rb72jOJJAd7lQHk9gtMddSWWEwi7vvggiyWJlo/dDh7sY9/kANKN1earef9pbry+J3Y6 6IDWTUt7pgXxXLaI84ZwIjQ5rUJx65jHL9241S9eTeT1wrVna91A8E4SSwHO3GAon+vI KqIh8Kk57y0SKOFjT4INICVIKBHKTiAUcfB/eZQcYDJO+xT/n1vrIJknwzIT+zhn6IDO PvJs56yV0z84JoDoRWf6GadyHGpIZen+J57vcKfRu2iSu2hUFkYIbvI8ZFNFpC+fx222 cl3A== X-Gm-Message-State: AOAM530Ac+dwYtw3CfenVnOKOQ0piMYbkuScxyBqQP5CH5zuSd+2o008 BtJE2WMQBoE04p/9/Ft6deM= X-Google-Smtp-Source: ABdhPJw3GdT62IZuD4bx51NMgvLf/wsXCZbpE/gH+uomRAWk1xAMH0zRsTzXvPIjNue6X91FmIaDAA== X-Received: by 2002:a17:90b:4b49:: with SMTP id mi9mr16281017pjb.219.1623938676419; Thu, 17 Jun 2021 07:04:36 -0700 (PDT) Received: from localhost ([61.69.135.108]) by smtp.gmail.com with ESMTPSA id c5sm5652006pfn.144.2021.06.17.07.04.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jun 2021 07:04:34 -0700 (PDT) Date: Fri, 18 Jun 2021 00:04:31 +1000 From: Balbir Singh To: Daniel Axtens Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kasan-dev@googlegroups.com, elver@google.com, akpm@linux-foundation.org, andreyknvl@gmail.com, linuxppc-dev@lists.ozlabs.org, christophe.leroy@csgroup.eu, aneesh.kumar@linux.ibm.com Subject: Re: [PATCH v15 0/4] KASAN core changes for ppc64 radix KASAN Message-ID: References: <20210617093032.103097-1-dja@axtens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210617093032.103097-1-dja@axtens.net> Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=lUWkoeD4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of bsingharora@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=bsingharora@gmail.com X-Rspamd-Server: rspam02 X-Stat-Signature: px5iicspu5oz3numhkmuuorou3xhrrzn X-Rspamd-Queue-Id: 1D8009001E53 X-HE-Tag: 1623938663-344052 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 17, 2021 at 07:30:28PM +1000, Daniel Axtens wrote: > Building on the work of Christophe, Aneesh and Balbir, I've ported > KASAN to 64-bit Book3S kernels running on the Radix MMU. I've been > trying this for a while, but we keep having collisions between the > kasan code in the mm tree and the code I want to put in to the ppc > tree. > > This series just contains the kasan core changes that we need. These > can go in via the mm tree. I will then propose the powerpc changes for > a later cycle. (The most recent RFC for the powerpc changes is in the > v12 series at > https://lore.kernel.org/linux-mm/20210615014705.2234866-1-dja@axtens.net/ > ) > > v15 applies to next-20210611. There should be no noticeable changes to > other platforms. > > Changes since v14: Included a bunch of Reviewed-by:s, thanks > Christophe and Marco. Cleaned up the build time error #ifdefs, thanks > Christophe. > > Changes since v13: move the MAX_PTR_PER_* definitions out of kasan and > into pgtable.h. Add a build time error to hopefully prevent any > confusion about when the new hook is applicable. Thanks Marco and > Christophe. > > Changes since v12: respond to Marco's review comments - clean up the > help for ARCH_DISABLE_KASAN_INLINE, and add an arch readiness check to > the new granule poisioning function. Thanks Marco. > > Daniel Axtens (4): > kasan: allow an architecture to disable inline instrumentation > kasan: allow architectures to provide an outline readiness check > mm: define default MAX_PTRS_PER_* in include/pgtable.h > kasan: use MAX_PTRS_PER_* for early shadow tables > The series seems reasonable Reviewed-by: Balbir Singh